From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FBF0A034C; Thu, 1 Sep 2022 19:23:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E90040693; Thu, 1 Sep 2022 19:23:11 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2053.outbound.protection.outlook.com [40.107.212.53]) by mails.dpdk.org (Postfix) with ESMTP id B38C940684 for ; Thu, 1 Sep 2022 19:23:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHOSc9Rng2sPeAE+ohps5G54tS4yM4cTobNx+5dJyHuPS8cSFnX8VRIzPNcJCNG4RtQMGOJps5B2MduQgBVcSgS+SRVPS5CjF6Tgm+FQmF3qvlCD8YvEbVcI+Oo45Nt/sAqooa2v9MBfDLPYhSRfGxifyBLy9RvzHAcsYaMrJ721dCtmRSNmaClRJYR7BS27snV6XFtYML9UzsXBKxs7x/iIJUlV+cW/3Zvs3UdfI3A9sLu0PAYePMo9lazCfJ/afUb6LbNJ2bWryXLuw48MA1xrydtNJ/0mQbpnqFVYMNrpVWq26vQrRzcwHl2sphjV1xBLo/msaKoA9w9/jTMHGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZOE6KQwOTUkMdBNk72gkIlu/wVXycxCGPkZWUrk9hk=; b=nneQweZjwxmcdyGJ5Tvnet1ie4xnG+AI5m2bVmzC4JQ5gfAARA4D9BUW4yVmHWGZ10b3/VB5eM7mVk3GO/5Op6+jy/5IsAs5m5WKw0M7p87n4y5E7wA/AHb7aAtyzpKcHUjvqOhsGluJcVpW03vIkrHexcCnbAz2OIozssExQyjRY7pHg2rhoz88j8yZsgv8fznv8J1CuOcilH4IFKAnmnJsy3pYL9zFspXVrBvYSzgUbk9jhjH9SSdyB6JxV49DWYWw9Pmg1IEmmi8srV5lE1VaZXkNv7NxLlc8NHw50DPDHzpZGvmOt6LHAtlQGUx835d9s0kRgaBzetA/c/xJWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YZOE6KQwOTUkMdBNk72gkIlu/wVXycxCGPkZWUrk9hk=; b=HtuZZSH1k70tKTi6/2I+InsF6u+l0EGKS+eXu4hFiV2MYA50YZZX8wCyBqv5BSIvPXYqqf8Tr69k/egONJomBU+fQ1zjEdi56aGXkX6OziPWHK/DvWux/m4t+b0Rg+M6oAa7uRVszkew9H8lklOQ7+TCyROAd4gL9lX8ETJ0x0c= Received: from DS7PR05CA0088.namprd05.prod.outlook.com (2603:10b6:8:56::14) by BN7PR02MB4052.namprd02.prod.outlook.com (2603:10b6:406:fb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 17:23:06 +0000 Received: from DM3NAM02FT056.eop-nam02.prod.protection.outlook.com (2603:10b6:8:56:cafe::89) by DS7PR05CA0088.outlook.office365.com (2603:10b6:8:56::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Thu, 1 Sep 2022 17:23:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT056.mail.protection.outlook.com (10.13.4.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 17:23:05 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 18:22:52 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 1 Sep 2022 18:22:52 +0100 Envelope-to: bruce.richardson@intel.com, david.marchand@redhat.com, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, haiyue.wang@intel.com, junfeng.guo@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com Received: from [10.71.194.74] (port=9723) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oTnu0-0008KO-Au; Thu, 01 Sep 2022 18:22:52 +0100 Message-ID: <63861264-aa90-e082-560b-a97d0ac7f5c5@xilinx.com> Date: Thu, 1 Sep 2022 18:22:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 03/10] net/gve: support device initialization Content-Language: en-US To: , David Marchand , Thomas Monjalon , Andrew Rybchenko CC: , , , Haiyue Wang , Junfeng Guo , , References: <20220729193042.2764633-2-xiaoyun.li@intel.com> <20220829084127.934183-1-junfeng.guo@intel.com> <20220829084127.934183-4-junfeng.guo@intel.com> From: Ferruh Yigit In-Reply-To: <20220829084127.934183-4-junfeng.guo@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a916b60-8198-407b-397b-08da8c3ea20f X-MS-TrafficTypeDiagnostic: BN7PR02MB4052:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KaP9k3Pb3xFM1lenLMHF764oedHjA0JQhATnWIMUH+RPfM/wM/hqCIFvrmmIiT/AfjwBFUf/8s+xkQMLEJBNylINd+zl/z9bzB/ctFx1W0dPVFt3cbyTYmsVfzr6DxWNHtifFZoy92vDGgvMd8Uzs/CyJXXE8l6dFUMbxgEzgW1/kdbj5z8EePgsTs8KzGriAaxd/Edyt3lzLTOsbm5gDKYB37qagSh4qBpEOnklEfzU4NE1w2JDK2/yCNhD9d0jMOnEaql932I4XniG/ofZQqaXx6BETvJW+OYsNct71Gw2Rbi5fOFvY65P6fTwEnA+tG9aDTS/ozgt/OEp0seu1YSjWtpz+JB4eTqeHNCJaaD2xCXvi8TDQGmt6qmTYxKfkQytUdkQAfSJqYpanDFCh5ZBGRZXp6LovqZccxap5xLnFl1HQMd18xvJuAFH1fvW3HPoJe4aH6gXOSfYxb58LBionEVqsMWqG0iIxr+8jp8i6cPa+ayRE6nLJDK4LJp6NSFtemObAsZ4P/TaVHB0TTiZvBj6Nf9CkRDlHzIArwjIyuq0vQFCCvXEgAh2un6wZvZG/LLkVEGS2aRRG0qhDeQuqsqBS4yItMYBm4GW6ndm+bkdHsSpfXr5IWObY8M1/sGC+AkFq3DHOBdCsT/IAfc/SODiXs4Kl2rUj0HTt8iPRZvCCYm0dBJW/zUbaH5KKDrEHIYbI7N+go1YKiHHWjGQggnrav+wOs/QDx9sf6IcDBfXDvmh0Y+UILS79UwZQM9U+n/lFhTscPwBZFLwRbgfqWzrkrsXe9ZVPR7eyY1AqtTxx1nYc1itwaHtasa+PxqegAYKh75IettOeZZYiQ== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(376002)(36840700001)(40470700004)(46966006)(426003)(47076005)(356005)(4744005)(44832011)(70586007)(70206006)(336012)(186003)(2616005)(7636003)(40480700001)(9786002)(36756003)(7416002)(31686004)(2906002)(8676002)(4326008)(5660300002)(8936002)(31696002)(478600001)(82310400005)(26005)(110136005)(41300700001)(53546011)(54906003)(40460700003)(36860700001)(316002)(82740400003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 17:23:05.8770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a916b60-8198-407b-397b-08da8c3ea20f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT056.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB4052 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/29/2022 9:41 AM, Junfeng Guo wrote: > diff --git a/drivers/net/gve/version.map b/drivers/net/gve/version.map > new file mode 100644 > index 0000000000..c2e0723b4c > --- /dev/null > +++ b/drivers/net/gve/version.map > @@ -0,0 +1,3 @@ > +DPDK_22 { > + local: *; > +}; It should be 'DPDK_23' now. @Bruce, @David, @Thomas, @Andrew, This is one of the common errors as far as I can see, and many times the .map is just empty and required because of the build process. Can we add a build system magic to let libraries/drivers use a common template for the .map file, unless library/driver needs something special? This prevents this trivial error also reduces overhead for the 'yy.mm-rc0' commit.