From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 34E065B02 for ; Tue, 27 Jan 2015 15:22:21 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id x12so15057314wgg.4 for ; Tue, 27 Jan 2015 06:22:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4FwUS85Lu4ggRIeBCZVOylHL2xn4Ggi5aJ2rTjYjpV8=; b=ad51CPVYEQfOGk6G+kxlRiZsP/u7AEaxccgipfrIujeouF1wttUK0DEU8agms6D+P4 TKX40weZLkpCla0SzTHxUqiNQftTiO4FdZRPSQe6ztx9BczuDaJQX6ScDQi84jReNmAh m3N3Uzh352Ctz3fo/ct3ask8NZFKWNiFqJdkfB28tNsrEQjQnZ1WfTJIfTJuP2gwaw/Z 4nXzysLroTe2BBtPhakeGpvq7vWIV8HgENb1XQo+l7wZN0DPFk+uQGqkbDJaWRiyD+MJ 0O0OlVa7xRku8OFOkW7JeCwcbt3adVUEfhu2J74x0yGv9trRqvPp3Fvtlb1MV5nk9s72 3DhA== X-Gm-Message-State: ALoCoQmD/h3kHawKQRFzZvLDw17yTKHIXUatQSOObjD/y9JJayzEn8C6L7y1JV+O8qH2Io6JhOYk X-Received: by 10.180.21.162 with SMTP id w2mr7539546wie.42.1422368540990; Tue, 27 Jan 2015 06:22:20 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u13sm2014083wjr.26.2015.01.27.06.22.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 06:22:20 -0800 (PST) From: Thomas Monjalon To: Daniel Mrzyglod Date: Tue, 27 Jan 2015 15:21:53 +0100 Message-ID: <6392453.J7yAtK8u6B@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1422368268-10068-1-git-send-email-danielx.t.mrzyglod@intel.com> References: <1422368268-10068-1-git-send-email-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] test: fix missing NULL pointer checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 14:22:21 -0000 2015-01-27 15:17, Daniel Mrzyglod: > In test_sched, we are missing NULL pointer checks after calls to create the > mempool and to allocate an mbuf. Add in these checks using TEST_ASSERT_NOT_NULL macros. You are adding checks *and* replacing VERIFY by TEST_ASSERT_NOT_NULL. It would be better to explain why you do these replacements. Please don't forget to answer the "why" question in the commit logs. Thanks -- Thomas