From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 66F0C1B26E for ; Sun, 22 Oct 2017 13:00:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E969B20961; Sun, 22 Oct 2017 07:00:36 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 22 Oct 2017 07:00:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lKULgorjc8NojKpni7b6Ek1Rq1 t7nN+QCCPN978qjR0=; b=CuSlCJkhNjDhEnenhMGHsYv/EBJeLFQL58ZqrnoFaO S76cTv1Wkq2nY4QEGodekIQeOACf3vXx0Ir78rl6yrdWKilv/JYR3qPxtkbpUMv/ L/vXOocxOQFNDVdvlAgv8tRgsgwyEstU3vs3gE4XNqSyd/m4uOnWh+0+1pWrFt8a 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=lKULgo rjc8NojKpni7b6Ek1Rq1t7nN+QCCPN978qjR0=; b=M0Wl8WB8FlvYQWK/a0eqw9 cQtEbR9+rSuu3o3XH9Y+gmS1fKJztxfouKe01eqIcfn9qT6r1LyZT7zn3hhoDOU3 isHaeK/hUlCddoa6Ktct0Hoe//ZSNRmBGvbtYp72w7QvLD9irjBLLKKaDUz57OOC rM0+IuysQQ5F9MffLzfaA9QzNhoppe65f4ddufymTU3AU7MPkYL0xWhLwSQQIGNy o78jda0zgJFj2mvYolQuXVqsP1gK1oeHBQVvtLs+mGwK2ti8MOcghSMaaFps7N7v 21WsGqdOw6GS9rM3ugi0QbKNNHNiyAoO+MRPGcJz72fDUy5k8xd/fFQlsPAPKX+A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E39724732; Sun, 22 Oct 2017 07:00:36 -0400 (EDT) From: Thomas Monjalon To: Aviad Yehezkel Cc: "De Lara Guarch, Pablo" , dev@dpdk.org, "Gonzalez Monroy, Sergio" , "aviadye@mellanox.com" , "borisp@mellanox.com" , "akhil.goyal@nxp.com" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "Doherty, Declan" , "liranl@mellanox.com" , "nelio.laranjeiro@6wind.com" Date: Sun, 22 Oct 2017 13:00:35 +0200 Message-ID: <6394702.IaL1MEG4G8@xps> In-Reply-To: <522e9051-1390-f0b3-9796-8f4e8c323c62@dev.mellanox.co.il> References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il> <522e9051-1390-f0b3-9796-8f4e8c323c62@dev.mellanox.co.il> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2017 11:00:38 -0000 22/10/2017 09:21, Aviad Yehezkel: > On 10/20/2017 12:50 PM, De Lara Guarch, Pablo wrote: > > From: aviadye@dev.mellanox.co.il > >> From: Aviad Yehezkel > >> > >> Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") > >> Cc: pablo.de.lara.guarch@intel.com > > > > You should CC stable here. > > You referred me to http://dpdk.org/doc/guides/contributing/patches.html > I followed the documentation: > " > When fixing a regression, it is required to reference the id of the > commit which introduced the bug, and put the original author of that > commit on CC. Yiu can generate the required lines using the following > git alias, which print the commit SHA and the author of the original code: > git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h > (\"%s\")%nCc: %ae'" > " > Please explain when to use above alias and when to put stable or > something else. It seems it is not described in the chapter 5. It is mentioned only in chapter 6: http://dpdk.org/doc/guides/contributing/stable.html#the-stable-mailing-list But when running devtools/check-git-log.sh as described in chapter 5: http://dpdk.org/doc/guides/contributing/patches.html#checking-the-patches You should see this: Is it candidate for Cc: stable@dpdk.org backport? It is using devtools/git-log-fixes.sh to get patches which are fixing older releases. Short answer: You must add "Cc: stable@dpdk.org" just below "Fixes:" if the bug was introduced in an older release. It will trigger the patch to be backported in maintenance releases. It is the responsibility of the tree maintainer to check this tag, and add or remove it, if he thinks the backport requirement was not properly considered.