From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 26DD754AE for <dev@dpdk.org>; Wed, 3 Oct 2018 10:43:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6AC4D20CA5; Wed, 3 Oct 2018 04:43:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 03 Oct 2018 04:43:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=edeR78og5/cIG2Q/Z1wGfFT65YR8tNtUaVn1e+TbcVA=; b=ibKcO+4YuXFG MT1UB2UbNHN3QO9R99SKr19v4kWULJl6POQ5gz4UiTqrFk2H981WwK6OU10g40YP DCX4lRRpfbMBeQfWqkct0qEkPmjt8klbpuuZPbD+6uF3ab/f71kQjSt16cyksJku ZVfygTt/02IGK+L6w7cJLjPr/v8qDhA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=edeR78og5/cIG2Q/Z1wGfFT65YR8tNtUaVn1e+Tbc VA=; b=fiG71jltsyix4lvVUm1GSbHrWWQknuVcCtFcaE5EKWg+OuUZDliMhRgH1 1NoGCKzKLNw9p4hBDIqL2yxMO80wH4jWIg6pxK+IwmsFk1Z+Iwndk2BYVmXTj5gm uKgeiJBcmn+emlPS5aPDDYnmwd4NLTqBctGeMFRatE2ip5nP4NS7D44HG8yETtLN U6NNJ4Z7qORi0QARsgi8B1MpPaKb058W6CfjsigtQg2m27xLTT81/2kS/XT8C1+d GjekFEl6wcEVh3chqhC5LfZIb+cNWbCRrqShyOLQ2vD4ZylbJo9gq2t6rmeCrSWR wv63hoWEsRTb8iHGUEp0Soby8af+Q== X-ME-Sender: <xms:E4G0W3dZxcnqv55OM4Ou2wnKOaGbn5iKpa35UQce1Qu2ghmio1NIVA> X-ME-Proxy: <xmx:E4G0W5XIDPcdLuQoYPFUWUU4hbmWOx9sO1YyA70WBDVu6iq8pWAx8A> <xmx:E4G0W2-uw1_UL42gGgWg9_d8dzMITEOcVTzYive7zErqn0R118A4eA> <xmx:E4G0W-4Pz2dialwe9XheZEo9oksHaSSCJdzy1sdD5R0QTR72kbKIYQ> <xmx:E4G0W3leXNi9j_hsBNQjbALrUIAwTeQ7rhlmle8FBmwQtEkc4AmpTA> <xmx:E4G0W5F1OYQpLP9Yeb-KqJZDt9jAmUCE5LaYNrd9qRexnAlQ4JThZg> <xmx:FIG0W_9Q4nYRFV9-wVdnmB5sTsTeuUHbxEO2aKI_JPfM-UAzsKd5Kg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D81CCE49DF; Wed, 3 Oct 2018 04:42:58 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ktraynor@redhat.com, Neil Horman <nhorman@redhat.com> Date: Wed, 03 Oct 2018 10:42:57 +0200 Message-ID: <6399878.QKedUUF0h3@xps> In-Reply-To: <6205dfd2-e14f-94dd-c621-ed9313dc8fba@intel.com> References: <20180907222727.20521-1-thomas@monjalon.net> <20180928162144.1972-4-thomas@monjalon.net> <6205dfd2-e14f-94dd-c621-ed9313dc8fba@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 03 Oct 2018 08:43:01 -0000 02/10/2018 12:28, Ferruh Yigit: > On 9/28/2018 5:21 PM, Thomas Monjalon wrote: > > These functions are quite old and are the only available replacement > > for the deprecated attach/detach functions. > > > > Note: some new functions may (again) replace these hotplug functions, > > in future, with better parameters. > > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > --- > > lib/librte_eal/common/eal_common_dev.c | 7 ++++--- > > lib/librte_eal/common/include/rte_dev.h | 11 ++--------- > > lib/librte_eal/rte_eal_version.map | 4 ++-- > > Can remove "-DALLOW_EXPERIMENTAL_API" (or "allow_experimental_apis = true" for > meson) from drivers/raw/ifpga_rawdev when these APIs are not experimental anymore. > For reference: https://patches.dpdk.org/patch/45836/ Yes we could remove this flag in this patch. But the next series would add it again: https://patches.dpdk.org/patch/45601/ So I think it is not worth for now. > It is easy to know when to add "-DALLOW_EXPERIMENTAL_API" but it is hard to know > when to remove one, some helper should be good there. Yes, we should try to clean up those flags regularly after each -rc1 release. But we don't have any tooling for that.