答复: [PATCH v2 11/18] net/r8169: implement Rx path

[王颢 <howard_wang@realsil.com.cn>]

Dear Stephen,

These CamelCase are from our linux kernel drivers. In order to maintain consistency with Linux kernel drivers and facilitate maintenance, our DPDK PMD has adopted this naming convention. May we continue using CamelCase?

Best Regards,
Howard Wang

-----邮件原件-----
发件人: Stephen Hemminger <stephen@networkplumber.org> 
发送时间: 2024年10月18日 0:11
收件人: 王颢 <howard_wang@realsil.com.cn>
抄送: dev@dpdk.org; pro_nic_dpdk@realtek.com
主题: Re: [PATCH v2 11/18] net/r8169: implement Rx path


External mail.



On Thu, 17 Oct 2024 14:31:53 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:

> +/*
> + * The overhead from MTU to max frame size.
> + * Considering VLAN so a tag needs to be counted.
> + */
> +#define RTL_ETH_OVERHEAD (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + 
> +VLAN_TAG_SIZE)
> +
> +#define ETH_HLEN        14
> +#define VLAN_HLEN       4
> +#define Jumbo_Frame_9k  (9 * 1024 - ETH_HLEN - VLAN_HLEN - 
> +RTE_ETHER_CRC_LEN)

You might want to consider using the defines in rte_ether.h

Also please don't use CamelCase unless it is coming from some other place (ie cloning of headers from base code).