* [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch
@ 2021-04-23 8:12 Min Hu (Connor)
2021-06-24 7:45 ` Thomas Monjalon
2021-06-24 11:33 ` Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Min Hu (Connor) @ 2021-04-23 8:12 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, thomas
From: Chengwen Feng <fengchengwen@huawei.com>
Some drivers may return errcode when switch allmulticast mode, so it's
necessary to check the return code.
Fixes: b34801d1aa2e ("kni: support allmulticast mode set")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
lib/kni/rte_kni.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c
index 9dae6a8..aa9b5b7 100644
--- a/lib/kni/rte_kni.c
+++ b/lib/kni/rte_kni.c
@@ -514,6 +514,8 @@ kni_config_promiscusity(uint16_t port_id, uint8_t to_on)
static int
kni_config_allmulticast(uint16_t port_id, uint8_t to_on)
{
+ int ret;
+
if (!rte_eth_dev_is_valid_port(port_id)) {
RTE_LOG(ERR, KNI, "Invalid port id %d\n", port_id);
return -EINVAL;
@@ -523,11 +525,16 @@ kni_config_allmulticast(uint16_t port_id, uint8_t to_on)
port_id, to_on);
if (to_on)
- rte_eth_allmulticast_enable(port_id);
+ ret = rte_eth_allmulticast_enable(port_id);
else
- rte_eth_allmulticast_disable(port_id);
+ ret = rte_eth_allmulticast_disable(port_id);
+ if (ret != 0)
+ RTE_LOG(ERR, KNI,
+ "Failed to %s allmulticast mode for port %u: %s\n",
+ to_on ? "enable" : "disable", port_id,
+ rte_strerror(-ret));
- return 0;
+ return ret;
}
int
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch
2021-04-23 8:12 [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch Min Hu (Connor)
@ 2021-06-24 7:45 ` Thomas Monjalon
2021-06-24 11:33 ` Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-06-24 7:45 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Min Hu (Connor), ajit.khaparde, stephen
Waiting for review
23/04/2021 10:12, Min Hu (Connor):
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> Some drivers may return errcode when switch allmulticast mode, so it's
> necessary to check the return code.
>
> Fixes: b34801d1aa2e ("kni: support allmulticast mode set")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> lib/kni/rte_kni.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c
> index 9dae6a8..aa9b5b7 100644
> --- a/lib/kni/rte_kni.c
> +++ b/lib/kni/rte_kni.c
> @@ -514,6 +514,8 @@ kni_config_promiscusity(uint16_t port_id, uint8_t to_on)
> static int
> kni_config_allmulticast(uint16_t port_id, uint8_t to_on)
> {
> + int ret;
> +
> if (!rte_eth_dev_is_valid_port(port_id)) {
> RTE_LOG(ERR, KNI, "Invalid port id %d\n", port_id);
> return -EINVAL;
> @@ -523,11 +525,16 @@ kni_config_allmulticast(uint16_t port_id, uint8_t to_on)
> port_id, to_on);
>
> if (to_on)
> - rte_eth_allmulticast_enable(port_id);
> + ret = rte_eth_allmulticast_enable(port_id);
> else
> - rte_eth_allmulticast_disable(port_id);
> + ret = rte_eth_allmulticast_disable(port_id);
> + if (ret != 0)
> + RTE_LOG(ERR, KNI,
> + "Failed to %s allmulticast mode for port %u: %s\n",
> + to_on ? "enable" : "disable", port_id,
> + rte_strerror(-ret));
>
> - return 0;
> + return ret;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch
2021-04-23 8:12 [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch Min Hu (Connor)
2021-06-24 7:45 ` Thomas Monjalon
@ 2021-06-24 11:33 ` Ferruh Yigit
2021-11-08 10:56 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2021-06-24 11:33 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: thomas
On 4/23/2021 9:12 AM, Min Hu (Connor) wrote:
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> Some drivers may return errcode when switch allmulticast mode, so it's
> necessary to check the return code.
>
> Fixes: b34801d1aa2e ("kni: support allmulticast mode set")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch
2021-06-24 11:33 ` Ferruh Yigit
@ 2021-11-08 10:56 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-11-08 10:56 UTC (permalink / raw)
To: Min Hu (Connor); +Cc: dev, Ferruh Yigit
24/06/2021 13:33, Ferruh Yigit:
> On 4/23/2021 9:12 AM, Min Hu (Connor) wrote:
> > From: Chengwen Feng <fengchengwen@huawei.com>
> >
> > Some drivers may return errcode when switch allmulticast mode, so it's
> > necessary to check the return code.
> >
> > Fixes: b34801d1aa2e ("kni: support allmulticast mode set")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks.
Sorry for the delay, it has been forgotten.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-08 10:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 8:12 [dpdk-dev] [PATCH] kni: check code of allmulticast mode switch Min Hu (Connor)
2021-06-24 7:45 ` Thomas Monjalon
2021-06-24 11:33 ` Ferruh Yigit
2021-11-08 10:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).