DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Harman Kalra <hkalra@marvell.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [PATCH v2 02/43] eal: add BSD version of queue.h
Date: Mon, 25 Aug 2025 18:54:00 +0800	[thread overview]
Message-ID: <63b03620-8893-4336-a85d-e5c6883e994b@huawei.com> (raw)
In-Reply-To: <20250825034126.12046-3-stephen@networkplumber.org>

On 8/25/2025 11:38 AM, Stephen Hemminger wrote:
> The version of sys/queue.h on Linux from glibc was derived
> from an older version of BSD and is missing several key macros
> such as LIST_FOREACH_SAFE. This leads to drivers re-implementing
> the macros (sometimes badly) and other bugs.
> Introduce a version of queue.h derived from the current FreeBSD.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

...

> 
> diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
> index 243a3c2959..097042dd22 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -324,12 +324,12 @@ Structure Declarations
>  Queues
>  ~~~~~~
>  
> -Use queue(3) macros rather than rolling your own lists, whenever possible.
> +Use queue(3) macros defined in <rte_queue.h> rather than rolling your own lists.

rte_queue.h -> rte_bsd_queue.h

>  Thus, the previous example would be better written:
>  
>  .. code-block:: c
>  
> - #include <sys/queue.h>
> + #include <rte_queue.h>

rte_queue.h -> rte_bsd_queue.h

>  
>   struct foo {
>           LIST_ENTRY(foo) link;      /* Use queue macros for foo lists. */
> diff --git a/doc/guides/rel_notes/release_25_11.rst b/doc/guides/rel_notes/release_25_11.rst
> index ccad6d89ff..586a3cff28 100644
> --- a/doc/guides/rel_notes/release_25_11.rst
> +++ b/doc/guides/rel_notes/release_25_11.rst
> @@ -55,6 +55,9 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
>  
> +* Added ``rte_queue.h`` which is clone of BSD queue.h header that is
> +  portable across all OS's.

rte_queue.h -> rte_bsd_queue.h

...

  reply	other threads:[~2025-08-25 10:54 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 23:27 [RFC 00/47] resolve issues with sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 01/47] eal: add BSD version of queue.h Stephen Hemminger
2025-08-19  8:00   ` Bruce Richardson
2025-08-19  8:37   ` Thomas Monjalon
2025-08-19 15:24     ` Stephen Hemminger
2025-08-19 15:29       ` Thomas Monjalon
2025-08-19 15:40         ` Bruce Richardson
2025-08-19 16:03           ` Stephen Hemminger
2025-08-19 16:07             ` Bruce Richardson
2025-08-19 17:46               ` Stephen Hemminger
2025-08-19 17:44         ` Stephen Hemminger
2025-08-18 23:27 ` [RFC 02/47] net/nfp: fix use after free Stephen Hemminger
2025-08-18 23:27 ` [RFC 03/47] eal: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 04/47] test: remove unnecessary inclusion of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 05/47] testpmd: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 06/47] dumpcap: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 07/47] proc-info: remove unnecessary sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 08/47] doc: suggest bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 09/47] test-pipeline: remove unnecessary use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 10/47] test-eventdev: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 11/47] test-bbdev, test-cmdline, test-mldev: don't use sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 12/47] examples: replace use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 13/47] hash: do not include sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 14/47] lpm: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 15/47] log: replace use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 16/47] ethdev: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 17/47] bpf: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 18/47] mempool: do not need sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 19/47] lib: remove use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 20/47] bus/fslmc: use rte_tailq.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 21/47] drivers/bus: replace use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 22/47] net/qede: use bsd_queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 23/47] net/bnxt: remove use of sys/queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 24/47] net/intel: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 25/47] net/mlx5: remove unnecessary include " Stephen Hemminger
2025-08-18 23:27 ` [RFC 26/47] net/tap: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 27/47] net/axgbe: replace use " Stephen Hemminger
2025-08-18 23:27 ` [RFC 28/47] net/bnx2x: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 29/47] net/bonding: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 30/47] net/cxgbe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 31/47] net/enic: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 32/47] net/failsafe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 33/47] net/memif: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 34/47] net/mlx4: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 35/47] net/ngbe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 36/47] net/ntnic: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 37/47] net/sfc: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 38/47] net/softnic: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 39/47] net/thunderx: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 40/47] net/txgbe: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 41/47] net/vdev_netvsc: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 42/47] net/vmxnet3: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 43/47] net/zxdh: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 44/47] net/dpaa2: " Stephen Hemminger
2025-08-18 23:27 ` [RFC 45/47] eal: remove no longer used windows version of queue.h Stephen Hemminger
2025-08-18 23:27 ` [RFC 46/47] net/mvpp2: replace local definition of FOREACH_SAFE Stephen Hemminger
2025-08-18 23:27 ` [RFC 47/47] drivers/raw: replace with TAILQ_FOREACH_SAFE Stephen Hemminger
2025-08-19  8:01 ` [RFC 00/47] resolve issues with sys/queue.h Bruce Richardson
2025-08-25  3:38 ` [PATCH v2 00/43] Introduce more complete queue.h macros Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 01/43] net/nfp: fix use after free Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 02/43] eal: add BSD version of queue.h Stephen Hemminger
2025-08-25 10:54     ` fengchengwen [this message]
2025-08-25  3:38   ` [PATCH v2 03/43] test: remove unnecessary inclusion of sys/queue.h Stephen Hemminger
2025-08-25  6:55     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 04/43] test-pipeline: remove unnecessary use " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 05/43] test-eventdev: use rte_bsd_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 06/43] test-bbdev, test-cmdline, test-mldev: don't use sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 07/43] app/testpmd: use rte_bsd_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 08/43] apps: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 09/43] examples: replace use of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 10/43] ethdev: " Stephen Hemminger
2025-08-25  6:48     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 11/43] lib: remove " Stephen Hemminger
2025-08-25  7:05     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 12/43] drivers/bus: replace " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 13/43] net/nfp: use rte_bsd_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 14/43] net/qede: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 15/43] net/bnxt: remove use of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 16/43] net/intel: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 17/43] net/mlx5: remove unnecessary include " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 18/43] net/mlx4: replace use " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 19/43] net/tap: remove unnecessary include " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 20/43] net/axgbe: replace use " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 21/43] net/bnx2x: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 22/43] net/bonding: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 23/43] net/cxgbe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 24/43] net/enic: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 25/43] net/failsafe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 26/43] net/memif: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 27/43] net/ngbe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 28/43] net/ntnic: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 29/43] net/sfc: " Stephen Hemminger
2025-08-25  6:47     ` Andrew Rybchenko
2025-08-25  3:38   ` [PATCH v2 30/43] net/softnic: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 31/43] net/thunderx: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 32/43] net/txgbe: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 33/43] net/vdev_netvsc: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 34/43] net/vmxnet3: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 35/43] net/zxdh: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 36/43] net/dpaa2: " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 37/43] net/mvpp2: replace local definition of FOREACH_SAFE Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 38/43] raw/ifpga: replace with TAILQ_FOREACH_SAFE Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 39/43] drivers/vdpa: replace use of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 40/43] drivers/common: remove " Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 41/43] drivers/crypto: remove use of sys_queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 42/43] drivers/event: remove include of sys/queue.h Stephen Hemminger
2025-08-25  3:38   ` [PATCH v2 43/43] eal: remove no longer used windows version " Stephen Hemminger
2025-08-25 15:10     ` Andre Muezerie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63b03620-8893-4336-a85d-e5c6883e994b@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=skori@marvell.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).