From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id F17CF1B265 for ; Tue, 14 Nov 2017 17:23:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3580; q=dns/txt; s=iport; t=1510676632; x=1511886232; h=from:to:cc:subject:date:message-id:mime-version; bh=AnF/y3XIikybpy7Q+BWilr9jwjQzFzKzlqjRCTIlxIg=; b=cMWjRU7AyefC2n834DU1sUJoCbxkMPioa6ImV/4xPgx3h/q9X7tBZpIz yGSLOTRedFydzqoeFwy6xzf2H587AkdkzDy1NMxrrRkLUWaGaU1ZCMG0A xj3Fe/mB5iq/juwbOQWsmAgC1CDCsg3kL5SWNvCakXiNaAtnJ5KZnUClo c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D3AADqFwta/4sNJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYJEcmRuLo4WojxYhHGCEQqEC4EwhQM/GAEBAQEBAQEBAWsdC4V?= =?us-ascii?q?MBkwSAQx0JgEEDg2JN2StHTqLEgEBAQEBAQEBAQEBAQEBAQEBAQEBHoM0ggeBV?= =?us-ascii?q?ZAjBaI0ApR7k0tIlTYCERkBgTgBHziBc3oVgy6EXohqAYEQAQEB?= X-IronPort-AV: E=Sophos;i="5.44,395,1505779200"; d="scan'208,217";a="323525821" Received: from alln-core-6.cisco.com ([173.36.13.139]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Nov 2017 16:23:50 +0000 Received: from XCH-RTP-019.cisco.com (xch-rtp-019.cisco.com [64.101.220.159]) by alln-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id vAEGNoxf026430 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL) for ; Tue, 14 Nov 2017 16:23:50 GMT Received: from xch-rtp-017.cisco.com (64.101.220.157) by XCH-RTP-019.cisco.com (64.101.220.159) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 14 Nov 2017 11:23:49 -0500 Received: from xch-rtp-017.cisco.com ([64.101.220.157]) by XCH-RTP-017.cisco.com ([64.101.220.157]) with mapi id 15.00.1320.000; Tue, 14 Nov 2017 11:23:49 -0500 From: "Hanoch Haim (hhaim)" To: "dev@dpdk.org" CC: "Hanoch Haim (hhaim)" Thread-Topic: rte_mbuf.h / rte_pktmbuf_prefree_seg / rte_atomic16 Thread-Index: AdNdZPKUrSncJyohTsWoSg/IoLfrRw== Date: Tue, 14 Nov 2017 16:23:49 +0000 Message-ID: <63b5253280db4d39b5ca8efc3182e280@XCH-RTP-017.cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [64.103.125.33] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] rte_mbuf.h / rte_pktmbuf_prefree_seg / rte_atomic16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 16:23:52 -0000 Hi All, I've found a minor issue in the function "rte_pktmbuf_prefree_seg" This code is located here : /dpdk/lib/librte_mbuf/rte_mbuf.h - } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) =3D=3D 0) Should be : + } else if (likely(rte_mbuf_refcnt_update(m, -1) =3D=3D 0)) { This depends on RTE_MBUF_REFCNT_ATOMIC define Thanks, Hanoh