From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E30A424D1; Wed, 12 Jun 2024 10:50:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F4BD402AB; Wed, 12 Jun 2024 10:50:29 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2067.outbound.protection.outlook.com [40.107.244.67]) by mails.dpdk.org (Postfix) with ESMTP id 41C65402A8 for ; Wed, 12 Jun 2024 10:50:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTmQN9p+VSzhq/oD2FOi/ZLVjRYS04D3KPApDbYf0RyfN34IZcov7kwg+p4rndDmxc2ZT6bNsIAwBdOOtvOSWvWiMmtZM74sQCk+9axHfRlnM2BjBLobe2BOJPvOo2ZovP3acxujmgWlO11UK22JCFPxT5qgAE1GlISJnQ2fN8G5fOxoQb0j681V/l6q/U4dm7Q5qcbFS7yY8Gli0roCoyWGB+VW1Vf/+/ScYA5bQZD92JP5kB1XMtbWNGPPgLk+7e8Byk8/OCrxyXj2xumMuxJ0JOQC7ux070Qyez0aTRcfO1ZwklFd0vKiFKYqiQndkhe3Pvs48aFzz6T3XEERVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7doSg1wNJ1bFhXZcQdv24yjqUe58CxK8N/8S6hM30Mo=; b=bOuqK8joIRbeLDW4il2hxcQQzJuf4wDLhJ3QK249TqRpuUBAQYPKva1k8GpUNI47ofnw8R1zFXrAZTys29ggz+vXnC6XJZChti2C3eGc5Oe3L2s01CTEM05krfFYn8pyn3oaawTVcLXvWDWfYI0WOdDctnAQHecJF4oAMyIbJ6QzRUj1dGA3rKjJcFrRU1LgHGU6m0bFK0JPgICdnVx0xw8ANRYlaK8O9Cp9m4Cg6s6zAJ2M9rcHm+xUeejAkH/oTkSJrwUSpwk0HXnRYMHx++9lwgqgKHhrT+CsK1MAYBOpS9kr9n6Z9OXvL1hwPkZJCKDkDC4T3V3vf9ONjGTHuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7doSg1wNJ1bFhXZcQdv24yjqUe58CxK8N/8S6hM30Mo=; b=PGgKdruL1fxS3T9VyatGBrXAtRaSqbL4tmwDFbnMJLX+dBcw+00odq0rI5qhbgoBL69pISCpJk5Cz916eNh2BcGaPlgEj0hJmPR/6vVlps2u5KEP1eO1gt/Jc4zqCavJRns9CwEJyOL2DA7zMhOiPMIic82PBx6b2kSwtf3ljgk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH7PR12MB6980.namprd12.prod.outlook.com (2603:10b6:510:1ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.37; Wed, 12 Jun 2024 08:50:24 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::5b9:d5fd:8122:7c77]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::5b9:d5fd:8122:7c77%5]) with mapi id 15.20.7633.036; Wed, 12 Jun 2024 08:50:24 +0000 Message-ID: <63c8c331-f602-4b52-9420-b62bee733c5c@amd.com> Date: Wed, 12 Jun 2024 09:50:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/17] net/ntnic: Add registers for NapaTech SmartNiC To: Serhii Iliushyk , "dev@dpdk.org" Cc: Christian Koue Muf , "andrew.rybchenko@oktetlabs.ru" , Mykola Kostenok References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240603161822.59552-1-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0139.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::14) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH7PR12MB6980:EE_ X-MS-Office365-Filtering-Correlation-Id: c5192e3a-2a08-4605-af3c-08dc8abcb307 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230032|1800799016|366008|376006; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NHorSnR6di9DQ0RCdzhXYWRtQ2JleWxCUHVvYkZycFBBY1F2NEovMnk1enNV?= =?utf-8?B?R2M4aEZxTk5uaW41VXhUT0NtQUZHUFhqSExJTjQxaEJUS2RSdUh4Q2VldXVT?= =?utf-8?B?YXU4Z253bit0VzBpQXgwbkd5OXU5VytUa2U2Njc5M3RSN3RUQ3pZMGE2c09r?= =?utf-8?B?MGZ2Ym5oU1RsK2pDZVlSMXJsbVZIZjRvSE8rZEVsV0FjYnNBUlRkTlVZSE5B?= =?utf-8?B?b1pKUXdLMG85WUFIUVZON2hzcUJSNTBwNzNFa2pBZnFDcklmNmhyeC9RYUYw?= =?utf-8?B?S2dFeGo0WUFKUGJZRWplb2ZzNmhCN09hWVVmTG9IeldEM1QvVVZ5SjFYc0dW?= =?utf-8?B?S2h2RERyaFRXTXN2dTRDWTk4RjFnL2Y5VWIwU0FEZDl2RkdVU3ZmQWxGWkZH?= =?utf-8?B?UGZUZENPYmdjYUx0S3orSlpTZTh2eW44VC8rYmhzYm5uMGZjbnE5VEkwSmcw?= =?utf-8?B?YVg5TUVWYlc1UWVsRnJNeDkvZm9pOGdrcXRGZVptNW9XdEFWcWVnenVoSnlY?= =?utf-8?B?OUkzMFV2blJlbWpjOVpSOUNjTzI0a2xhSHhsMVlwRHZvM05YM0M2cEZHL0R2?= =?utf-8?B?eGorRGNDcDNyVElGejYyZzNwcWhXak1PNEJaanh6YWJhTUMwcVBUdFpqenRG?= =?utf-8?B?U0xlcHNEUEt4SFBXM2ptUjhnTVdqSVY5N0tPMnlZTytpSUJHSFA3R29BMm4z?= =?utf-8?B?WE40OFAvZlhBbmFJRzhoWXNKeitmbHNDVGltRTdkWHB3NHBNUjFVdTU1OTZj?= =?utf-8?B?dWlZWThlZWt3c2FJUWNab0pRMUJTYzBjSlI4M1g5YzRDVWVrVng2ZEFoMUsx?= =?utf-8?B?eU1GL0pRRE5kODN3V08xb2UyTDFRaG9yZ3l3dHhyRWJZZm1RWTBnbmxUZ2JI?= =?utf-8?B?RWtRQmZYZHZaZmpTWjRmZTBocXdOenhxeGpDU3QxSUk1cG1rUDNGVHcvdFlt?= =?utf-8?B?WEhYbFVlYmd6SlJaS2NndVYzVkw5ZXQwTENqQjhycmlaekg3V21vN242cTVs?= =?utf-8?B?ejh5SCt6U1huT2hrWndFdVV6VFpCQ3lXNGtrL2t2SjdmbDBqTFNmekl3Ykpy?= =?utf-8?B?UXVtcVFENm5pdkVJOGhiU3RHb3dkYW14T2hGandQZ3VHbFB5akZoN3I1LzNQ?= =?utf-8?B?Ti9Pemt1ZGZNR29WV3NIWFY2a2ZyaWdLZEZqLzh0dTh2UmZwMVJZdy9wYnlJ?= =?utf-8?B?UDNPWGRvMHV0SkFwM2J3dms5bUdySjg0NTIzNE5VcDVVa2V1TXg5WXJYbzZm?= =?utf-8?B?N1pLTERGakd2YjJralhveEovVlhMaXlCcmlqWThuYnIxbzJLVDFTMlJsRkRp?= =?utf-8?B?dm5Zc2c1YW5EZnB5Wkl6SS94RzJMSzNVVXlYdHNCMWRIR3VwSmljYU5jSi9Z?= =?utf-8?B?c09lWEV0ZER6RFJRZWx2T05zdEQ5N0pJb3RtSDhoRm12QlYxcEZNNDNnZUxJ?= =?utf-8?B?cER6ek5yWVgyK2lJZ3hVOTFJanpqdXY2U25uMnkzNjhWUnNpSEdyaVBJUDVY?= =?utf-8?B?QVJhdmVEOVZwQVIvdXowa0RLcWZDN2ZlbkpFTDhsWmdEemVGSXhxaXo1Y0tl?= =?utf-8?B?TUhFd0x4YjdKdXU1cm8rcHUyYk5mQ1Zkalp1SzBhWXpjQlZNK2hQSkZ1bVNJ?= =?utf-8?B?Z242WURKNEozbWlVMFZHNXIzamY0UUNPYmhBYUJmRlZncjI3TkN1dGVZNC80?= =?utf-8?B?WFpaUjRxaWp2NnRYNGRZakxtNnJ5aUZrZFVsdEVsWGlTQ2RRYnJmc3RMeWxI?= =?utf-8?Q?7y2Pca3rMaZOpH5Gu45yDuuLhbuQ0vS4dKJnMtZ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230032)(1800799016)(366008)(376006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T040SVM2NGFTbEVyc01rVzNBeDVDVGNaTStQL1piTDZuWFFKSk8wMEVncXZt?= =?utf-8?B?V3RrdzRleUw2WTlOOWtMNmRBcEFUWDQvUDFuNGsrLzlYQy81dkhuQjNwWlhT?= =?utf-8?B?RGZRM2JiV0I2MHh2MnZOeWV5aUdFRCtYdlY1WGlUbWQ3RXZITXlZL2w2cHg3?= =?utf-8?B?WGw5YzRUSWtZQ0theWZMTG9BcDgxWStHSms1SWgwbTBCMWtyREZ3dnB4RjMx?= =?utf-8?B?MlhRSFlEVnJzMUltZ3JOcVNTZnh4c1hwTlNjdEs3L1F2WjJkUWM5OTRmMGp3?= =?utf-8?B?dW1wbGExNGtROVo4dFgyMGVKN1NmdHkzemxxREI4Znc5cVI3Z3lGUHpLbTdP?= =?utf-8?B?dCtyVXlrQzFRbU8yaVg4UGVNOVh3clk4ckJ1aE95QXR4aitJTjMzWjNuSkJ2?= =?utf-8?B?OE9xY0pDZzFYMyt1SmFCRVFQMFVEcU03eGYwbjBPdlgvbzJXSkphZzI3dFVm?= =?utf-8?B?ZmVmcjlyMDEvUHVsaXpibDQ5N0FYNmxxOTNBTkUwQlI4cnNSbzFhTjdnNUxD?= =?utf-8?B?OHoyRGY4ZkdqU2MrMXQ0RTRuK3M2ZzdIVVhGRUF1MDdnL21WVkY4WHpjMW9m?= =?utf-8?B?RTZoR3lwVFhNcW94WHpGY1o1UUVxaWFsNmNrbzBCK050WjZ5U2UzWTlVdWNJ?= =?utf-8?B?QzFBL3gyblpUSEUrblhwcEs4cVl2dHdyOTkrVjBlazdnNlptd08vcVZPN2dJ?= =?utf-8?B?RzQxa2piM1I2RUN3dC9TbEtYZlFMZjE1QnMyQ0pFbkxwUW13c1VZT1gxQ3Fq?= =?utf-8?B?YmJndWgveDNZRTNpbWt2UmZnQVdmcDQ1L1c5VFg2QWVoMXVTYVpLL0diQkRR?= =?utf-8?B?L0VLbkFpczE4TzdldjVtc2x2UkE2bWs4M0k4TEZwbWhYOW9CRnBSdEcvVWlZ?= =?utf-8?B?SmJ3ZjVnR2s5U3JXaU1xdENWTCtwZFd6bXZ6cmdJSENrRUJXd1dqZXh2WUZC?= =?utf-8?B?bTE5MStiUEsvV1RSdjgyK1JTR1YxRGw3Q0VJM0RFMDJlRjlzcjRLMm5LVlFH?= =?utf-8?B?Mmh3c2g3aXQrdmJoS2hLK29LTFM5ZEVQZ0ZiMXVQTmpnTkxFVGJIYjFyMXF2?= =?utf-8?B?RTlBV0prd0RIbEw1Q1RmM1N3elVwbUEzY3U0VlpWMWJwT3hDSXRkcytMeWVI?= =?utf-8?B?SXRzWFkySW9FZVV4U0RUenlCWFUzUEtzU29qcnc0MUkveXVCelhIVUZoRVlB?= =?utf-8?B?TTh4a1BXRTh2OUhUU09pMFFvR2pKZjRLQm56YVFCSllQR2I4Um4xMVNFVStP?= =?utf-8?B?TDZXWFp0aFhwL1NOYlFRZi9vR3lsVlNRVHlJZ0tnNjgyeW9Rb3ZpdSs2VjlH?= =?utf-8?B?WHNQcGI1aUZ4VSsrdlFiNEwxbmFUQ1g5dm1ucHZ6d2F2dTdTTWY5WHFaWnRn?= =?utf-8?B?djF5UXB0YXUvdlNUSVhGdEFFMFVxcEpRM2lHbWMzMDE0MUdHamxWTXNuVlRa?= =?utf-8?B?bElBNVJpdExpWjhJWFNYYWE4aFY0SXU4ci9JU3laZ2V5VXNNY2RHclFiMnF2?= =?utf-8?B?SnZ4U2RZNWtXazZlcGoya216ekFndGlPQXdLNFpmVHhrdjJtSXMzRk9mUmQw?= =?utf-8?B?WHNsMHp6V2pEc211Z214RXk4S2l3T2tVdDJhTCtyWmFNQzFHdVBaT2YvbU5K?= =?utf-8?B?QlJQcjFlTGNRa1pLVjhES2paN0pUeXRZUHlaaGkxVS84WTExc2R2L2FLNXE2?= =?utf-8?B?cGVSM0Q1azJ2QkNiY2dVZFZINXdOSG13YTljbU5WRm5BVFYvbndRbTJNRDNu?= =?utf-8?B?VXhBVFpha0VaRFlGaG16OUxKRGx3WnFualJETjVJODNwNXVBQ0JBRFJmOVcx?= =?utf-8?B?R01KSjlPL1BNOXZnR0dQRnprNkRPc0VGaTVqaGtrRm44SmVrdHMzeGk1NTlz?= =?utf-8?B?K05VTUVuTk40M2tiQ2hGcFdLR0NMeWwydVRmQW9pUFV6MVg3d3NGcVNZYW9V?= =?utf-8?B?T3EvTVNERExtYWhDNGUyQ3h5aFFCak9JdlZRd2tFY1UybXRsTmRmTWZtZW1p?= =?utf-8?B?bXNUM1hOS1V4SHF4VXhlZW0wSmZ0TW4zU04yOU43Vjh0N0szNTV2bmRKSjRa?= =?utf-8?B?VjNkcDFlOTdXMGVYOHFKWStVMXlENVN0WUZGaHBYVXg4WjZJTnlSQTh2Sjk1?= =?utf-8?Q?ygrBkFpe6ylXgFHoHd0lvepTy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5192e3a-2a08-4605-af3c-08dc8abcb307 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 08:50:24.3806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yssBouMhzbcUlMQebsiYJmS5sTTFOhTQgFPk9hCoxwvR5tRPB8JEAq+IyMx08ucU X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6980 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2024 2:03 PM, Serhii Iliushyk wrote: Moved down. Please don't top post. > > ------------------------------------------------------------------------ > *From:* Mykola Kostenok > *Sent:* 04 June 2024 13:29 > *To:* Serhii Iliushyk ; dev@dpdk.org > *Cc:* Christian Koue Muf ; > andrew.rybchenko@oktetlabs.ru ; > ferruh.yigit@amd.com > *Subject:* RE: [PATCH v3 01/17] net/ntnic: Add registers for NapaTech > SmartNiC >   > Recheck-request: iol-unit-amd64-testing, iol-compile-amd64-testing, > iol-unit-arm64-testing, iol-compile-arm64-testing > >> -----Original Message----- >> From: Serhii Iliushyk >> Sent: Monday, June 3, 2024 7:18 PM >> To: dev@dpdk.org >> Cc: Mykola Kostenok ; Christian Koue Muf >> ; andrew.rybchenko@oktetlabs.ru; >> ferruh.yigit@amd.com >> Subject: [PATCH v3 01/17] net/ntnic: Add registers for NapaTech SmartNiC >> >> The NTNIC PMD does not rely on a kernel space Napatech driver, >> thus all defines related to the register layout is part of the PMD >> code, which will be added in later commits. >> >> Signed-off-by: Serhii Iliushyk >> --- >>  .../supported/nthw_fpga_9563_055_039_0000.c   | 3488 > > Hi Ferruh, > > We have sent a patch set which includes base PMD driver for NapaTech > smartNiC for DPDK v24.07. > > This time, driver has limited basic functionality(Link up only) and we > have made refactoring to split it into smaller patches. > Extended functionality is planned for upstream to the next release DPDK > 24.11. > > Patches have passed the CI but there are several code style warnings > which we assumed as false-positive. > Could you please take a look at these patches and suggest us how we can > procced with it? > > Hi Serhii, Thanks for the rework. Still there are some big chunk of code added without being used. Some auto generated code and register definition files are understandable, but there are lots of .c files as well adding lots of new functions as a bunch, out of any context. It is not possible for anyone to detect any unused code or review them without knowing where/how they are actually used. (To put with a simple analogy, you are staring to build an apartment by putting windows and doors in place first.) I will progress with the series, as it is more pragmatic to have it merged than keeping out of tree. There will be more comments on patches, but in high-level, primary comment is please don't include anything not used/necessary for this initial functionality. Everything can be merged later when they are actually needed/used. Btw, I can see some of the checkpatch warnings are valid, can you please go through them? > > Disclaimer: This email and any files transmitted with it may contain > confidential information intended for the addressee(s) only. The > information is not to be surrendered or copied to unauthorized persons. > If you have received this communication in error, please notify the > sender immediately and delete this e-mail from your system. > And it would be nice if you can get rid of above disclaimer, it doesn't make sense in an open-source contribution.