From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 8E010A49C for ; Fri, 27 Apr 2018 16:36:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 147F84023112; Fri, 27 Apr 2018 14:36:43 +0000 (UTC) Received: from [10.36.112.44] (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6430D112C243; Fri, 27 Apr 2018 14:36:42 +0000 (UTC) To: Ciara Loftus , dev@dpdk.org References: <1524838798-5445-1-git-send-email-ciara.loftus@intel.com> From: Maxime Coquelin Message-ID: <63cf2950-e7e6-deee-e84a-645cce2c4222@redhat.com> Date: Fri, 27 Apr 2018 16:36:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524838798-5445-1-git-send-email-ciara.loftus@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Apr 2018 14:36:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Apr 2018 14:36:43 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] net/vhost: Initialise vid to -1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 14:36:43 -0000 On 04/27/2018 04:19 PM, Ciara Loftus wrote: > rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before > the first call to the new_device callback. A vid value >=0 suggests the > device is active which is not the case in this instance. Initialise vid > to a negative value to prevent this. > > Signed-off-by: Ciara Loftus > --- > drivers/net/vhost/rte_eth_vhost.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index 99a7727..f47950c 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -1051,6 +1051,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id, > return -ENOMEM; > } > > + vq->vid = -1; > vq->mb_pool = mb_pool; > vq->virtqueue_id = rx_queue_id * VIRTIO_QNUM + VIRTIO_TXQ; > dev->data->rx_queues[rx_queue_id] = vq; > Reviewed-by: Maxime Coquelin Thanks, Maxime