From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BBC30A0C44;
Mon, 12 Apr 2021 15:35:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 82C701411D4;
Mon, 12 Apr 2021 15:35:40 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by mails.dpdk.org (Postfix) with ESMTP id 4DE481411D1;
Mon, 12 Apr 2021 15:35:38 +0200 (CEST)
IronPort-SDR: cJb1QZUDbAwkAFlPFjthDBOGgtGOY1CVyo5G2LiBCpeucWhDQz1wcHgDYCri5ya5XyG2z/Yok5
mpEn25wm3shw==
X-IronPort-AV: E=McAfee;i="6000,8403,9952"; a="279492498"
X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="279492498"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
12 Apr 2021 06:35:36 -0700
IronPort-SDR: zm/yoRZBtzEqdZ6VIAoPXJXT2TyIKLCW7T0YJWR++29EFPn9NtYtANs4TKrauHC4Thid+3L85x
PxoeOd+K5kIg==
X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="460170808"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.254])
([10.213.203.254])
by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
12 Apr 2021 06:35:34 -0700
To: Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>, Tal Shnaiderman <talshn@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Asaf Penso <asafp@nvidia.com>,
Wisam Monther <wisamm@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>,
David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>
References: <20210411122136.2560-1-talshn@nvidia.com>
<SN6PR12MB2750A29D422DE720B920218CCF709@SN6PR12MB2750.namprd12.prod.outlook.com>
<a3b6adeb-ee92-d141-d149-11bd8d7638fc@intel.com> <3237657.no5xmyL5GM@thomas>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <63ee5eb4-0388-87a5-683f-007d47180bb5@intel.com>
Date: Mon, 12 Apr 2021 14:35:30 +0100
MIME-Version: 1.0
In-Reply-To: <3237657.no5xmyL5GM@thomas>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing
__rte_internal tags in exported functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 4/12/2021 2:06 PM, Thomas Monjalon wrote:
> 12/04/2021 14:59, Ferruh Yigit:
>> On 4/12/2021 12:25 PM, Raslan Darawsheh wrote:
>>> Hi,
>>>
>>> From: Tal Shnaiderman <talshn@nvidia.com>
>>>>
>>> Removed __ from the commit title to fix wrong headline format issue.
>>>
>>>> Several functions introduced in the addition of the Windows support to
>>>> mlx5 were missing the __rte_internal tag although being exported.
>>>>
>>>> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
>>>> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on
>>>> Windows")
>>>> Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
>>>
>>> Patch applied to next-net-mlx,
>>>
>>
>> Can we merge this directly to main repo?
>> Since debug build is broken without it.
>
> Which debug option?
> It is broken since when?
>
>
"meson --buildtype=debug build && ninja -C build" is broken [1], I thought that
is why this patch is done at first place.
Some checks are done now only in the debug mode, since checks are reduced to
developer mode [2].
It become visible when .def file removed [3], since that is when symbols are
added to the .map file.
[1]
FAILED: drivers/rte_common_mlx5.sym_chk
.../meson --internal exe --capture drivers/rte_common_mlx5.sym_chk --
.../buildtools/check-symbols.sh .../drivers/common/mlx5/version.map
drivers/librte_common_mlx5.a
mlx5_os_umem_reg is not flagged as internal
but is listed in version map
Please add __rte_internal to the definition of mlx5_os_umem_reg
mlx5_os_umem_dereg is not flagged as internal
but is listed in version map
Please add __rte_internal to the definition of mlx5_os_umem_dereg
[2]
Commit 720dfda4551e ("build: limit symbol checks to developer mode")
[3]
Commit 56ea803e878e ("build: remove Windows export symbol list")