From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2815928EE for ; Mon, 22 May 2017 14:44:44 +0200 (CEST) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id A19658005C; Mon, 22 May 2017 12:44:43 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx2-us3.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 1CC6D60049; Mon, 22 May 2017 12:44:43 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id B201260087; Mon, 22 May 2017 12:44:40 +0000 (UTC) Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 22 May 2017 13:44:36 +0100 To: Ferruh Yigit , , "Sergio Gonzalez Monroy" References: <1495023908-10977-1-git-send-email-arybchenko@solarflare.com> <1495116004-11761-1-git-send-email-arybchenko@solarflare.com> <1495116004-11761-3-git-send-email-arybchenko@solarflare.com> <45b5b0a6-a5be-88d7-734f-c2b1dd1b31be@intel.com> <4e8bdd9d-e26d-0cb6-9e0f-68df9f42c5d3@intel.com> From: Andrew Rybchenko Message-ID: <63f69c97-74a5-1044-2409-4181f34fb2b1@solarflare.com> Date: Mon, 22 May 2017 15:44:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <4e8bdd9d-e26d-0cb6-9e0f-68df9f42c5d3@intel.com> X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23084.003 X-TM-AS-Result: No--3.331500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1495457083-2Riz1x2fZ4HB Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/sfc: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 12:44:44 -0000 On 05/22/2017 03:36 PM, Ferruh Yigit wrote: > On 5/22/2017 1:07 PM, Andrew Rybchenko wrote: >> On 05/22/2017 02:29 PM, Ferruh Yigit wrote: >>> On 5/18/2017 3:00 PM, Andrew Rybchenko wrote: >>>> Signed-off-by: Andrew Rybchenko >>>> Reviewed-by: Andy Moreton >>> <...> >>> >>>> diff --git a/drivers/net/sfc/sfc_ef10_rx.c b/drivers/net/sfc/sfc_ef10_rx.c >>>> index 1484bab..60812cb 100644 >>>> --- a/drivers/net/sfc/sfc_ef10_rx.c >>>> +++ b/drivers/net/sfc/sfc_ef10_rx.c >>>> @@ -699,7 +699,7 @@ struct sfc_dp_rx sfc_ef10_rx = { >>>> .type = SFC_DP_RX, >>>> .hw_fw_caps = SFC_DP_HW_FW_CAP_EF10, >>>> }, >>>> - .features = 0, >>>> + .features = SFC_DP_RX_FEAT_MULTI_PROCESS, >>> Why this flag is needed, I mean why multi process support is not always >>> enabled by default? >> libefx-based datapath intensively uses function pointers (primary >> process function pointers stored in data structures). So, it does not >> work in multi process. > But this currently added always, if I don't miss anything. And only > checked once in secondary path and error returned if not set. > > Is there any code path that behaves different based on this flag? Or any > case that this flags shouldn't be set? sfc_efx_rx (and sfc_efx_tx) does not have the flag. > What happens if this flag removed, and assumed it is always set? (this > and tx version of this flag) Init in the secondary process fails if datapath chosen by the primary process does not have the flag. >>> <...>