From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiaoyun Li <xiaoyun.li@intel.com>,
thomas@monjalon.net, helin.zhang@intel.com, damarion@cisco.com,
ray.kinsella@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd
Date: Fri, 28 Sep 2018 09:33:02 +0100 [thread overview]
Message-ID: <63ff72cb-59d8-a222-c38b-94c2f32f34b1@intel.com> (raw)
In-Reply-To: <20180928034331.25147-1-xiaoyun.li@intel.com>
On 9/28/2018 4:43 AM, Xiaoyun Li wrote:
> Some users want to use their own epoll instances to control both
> DPDK rxq interrupt fds and their own other fds. So added a function
> to get rxq interrupt fd based on port id and queue id.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
<...>
> @@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int op, void *data);
> int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
> int epfd, int op, void *data);
>
> +int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id,
> + int *fd);
Hi Xiaoyun,
API is missing documentation, please add doxygen comments.
New APIs need to be experimental, at least for one release.
Also can you please add it to .map file otherwise shared lib build will fail
next prev parent reply other threads:[~2018-09-28 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 3:43 Xiaoyun Li
2018-09-28 8:33 ` Ferruh Yigit [this message]
2018-09-28 9:08 ` Li, Xiaoyun
2018-09-28 10:05 ` [dpdk-dev] [PATCH v2] " Xiaoyun Li
2018-09-28 12:46 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2018-09-29 1:57 ` Li, Xiaoyun
2018-09-29 2:12 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2018-10-02 10:48 ` Ferruh Yigit
2018-10-04 15:31 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ff72cb-59d8-a222-c38b-94c2f32f34b1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=damarion@cisco.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=ray.kinsella@intel.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).