From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B85691B108 for ; Fri, 28 Sep 2018 10:33:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 01:33:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,314,1534834800"; d="scan'208";a="261160932" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.3.51]) ([10.252.3.51]) by orsmga005.jf.intel.com with ESMTP; 28 Sep 2018 01:33:03 -0700 To: Xiaoyun Li , thomas@monjalon.net, helin.zhang@intel.com, damarion@cisco.com, ray.kinsella@intel.com, dev@dpdk.org References: <20180928034331.25147-1-xiaoyun.li@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <63ff72cb-59d8-a222-c38b-94c2f32f34b1@intel.com> Date: Fri, 28 Sep 2018 09:33:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928034331.25147-1-xiaoyun.li@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 08:33:06 -0000 On 9/28/2018 4:43 AM, Xiaoyun Li wrote: > Some users want to use their own epoll instances to control both > DPDK rxq interrupt fds and their own other fds. So added a function > to get rxq interrupt fd based on port id and queue id. > > Signed-off-by: Xiaoyun Li <...> > @@ -2719,6 +2719,9 @@ int rte_eth_dev_rx_intr_ctl(uint16_t port_id, int epfd, int op, void *data); > int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id, > int epfd, int op, void *data); > > +int rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id, > + int *fd); Hi Xiaoyun, API is missing documentation, please add doxygen comments. New APIs need to be experimental, at least for one release. Also can you please add it to .map file otherwise shared lib build will fail