* [PATCH] doc: add removal note for power empty poll API
@ 2022-08-02 15:22 Reshma Pattan
2022-08-30 9:23 ` Hunt, David
2022-10-05 8:44 ` [PATCH v2] " Reshma Pattan
0 siblings, 2 replies; 11+ messages in thread
From: Reshma Pattan @ 2022-08-02 15:22 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, David Hunt
Add removal note for experimental empty poll API.
CC: David Hunt <david.hunt@intel.com>
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
doc/guides/prog_guide/power_man.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index 98cfd3c1f3..2e47d87cbb 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -192,6 +192,12 @@ User Cases
----------
The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
+Removal Note
+------------
+The experimental empty poll APIs will be removed from the library in a future DPDK release.
+Suggest to use new lcore poll busyness APIs added in 22.11.
+
+
Ethernet PMD Power Management API
---------------------------------
--
2.27.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] doc: add removal note for power empty poll API
2022-08-02 15:22 [PATCH] doc: add removal note for power empty poll API Reshma Pattan
@ 2022-08-30 9:23 ` Hunt, David
2022-10-05 8:44 ` [PATCH v2] " Reshma Pattan
1 sibling, 0 replies; 11+ messages in thread
From: Hunt, David @ 2022-08-30 9:23 UTC (permalink / raw)
To: Reshma Pattan, dev
On 02/08/2022 16:22, Reshma Pattan wrote:
> Add removal note for experimental empty poll API.
>
> CC: David Hunt <david.hunt@intel.com>
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> doc/guides/prog_guide/power_man.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
> index 98cfd3c1f3..2e47d87cbb 100644
> --- a/doc/guides/prog_guide/power_man.rst
> +++ b/doc/guides/prog_guide/power_man.rst
> @@ -192,6 +192,12 @@ User Cases
> ----------
> The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
>
> +Removal Note
> +------------
> +The experimental empty poll APIs will be removed from the library in a future DPDK release.
> +Suggest to use new lcore poll busyness APIs added in 22.11.
> +
> +
> Ethernet PMD Power Management API
> ---------------------------------
>
Hi Reshma,
Yes, these APIs will be superseded by the newer poll busyness telemetry.
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] doc: add removal note for power empty poll API
2022-08-02 15:22 [PATCH] doc: add removal note for power empty poll API Reshma Pattan
2022-08-30 9:23 ` Hunt, David
@ 2022-10-05 8:44 ` Reshma Pattan
2022-10-05 12:27 ` Thomas Monjalon
2022-10-07 13:40 ` [PATCH v3] " Reshma Pattan
1 sibling, 2 replies; 11+ messages in thread
From: Reshma Pattan @ 2022-10-05 8:44 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, David Hunt
Add removal note for experimental empty poll API.
CC: David Hunt <david.hunt@intel.com>
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
doc/guides/prog_guide/power_man.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index 98cfd3c1f3..9a40242dd0 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -192,6 +192,12 @@ User Cases
----------
The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
+Removal Note
+------------
+The experimental empty poll APIs will be removed from the library in a future
+DPDK release.
+
+
Ethernet PMD Power Management API
---------------------------------
--
2.31.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] doc: add removal note for power empty poll API
2022-10-05 8:44 ` [PATCH v2] " Reshma Pattan
@ 2022-10-05 12:27 ` Thomas Monjalon
2022-10-07 13:54 ` Pattan, Reshma
2022-10-07 13:40 ` [PATCH v3] " Reshma Pattan
1 sibling, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-10-05 12:27 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, David Hunt
05/10/2022 10:44, Reshma Pattan:
> Add removal note for experimental empty poll API.
>
> CC: David Hunt <david.hunt@intel.com>
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
[...]
> --- a/doc/guides/prog_guide/power_man.rst
> +++ b/doc/guides/prog_guide/power_man.rst
> @@ -192,6 +192,12 @@ User Cases
> ----------
> The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
>
> +Removal Note
> +------------
> +The experimental empty poll APIs will be removed from the library in a future
> +DPDK release.
It looks common in this file to forget the empty line after a title,
but please don't forget it.
I am surprised Sphinx is not complaining.
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v2] doc: add removal note for power empty poll API
2022-10-05 12:27 ` Thomas Monjalon
@ 2022-10-07 13:54 ` Pattan, Reshma
0 siblings, 0 replies; 11+ messages in thread
From: Pattan, Reshma @ 2022-10-07 13:54 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Hunt, David
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
-- snip --
> > +Removal Note
> > +------------
> > +The experimental empty poll APIs will be removed from the library in
> > +a future DPDK release.
>
> It looks common in this file to forget the empty line after a title, but please
> don't forget it.
>
Good catch, this is addressed in v3 now .
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3] doc: add removal note for power empty poll API
2022-10-05 8:44 ` [PATCH v2] " Reshma Pattan
2022-10-05 12:27 ` Thomas Monjalon
@ 2022-10-07 13:40 ` Reshma Pattan
2022-10-31 15:26 ` Thomas Monjalon
2022-11-02 12:31 ` [PATCH v4] doc: add removal warning " Reshma Pattan
1 sibling, 2 replies; 11+ messages in thread
From: Reshma Pattan @ 2022-10-07 13:40 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, David Hunt
Add removal note for experimental empty poll API.
CC: David Hunt <david.hunt@intel.com>
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
doc/guides/prog_guide/power_man.rst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index 98cfd3c1f3..3b0c3373a1 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -192,6 +192,14 @@ User Cases
----------
The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
+
+Removal Note
+------------
+
+The experimental empty poll APIs will be removed from the library in a future
+DPDK release.
+
+
Ethernet PMD Power Management API
---------------------------------
--
2.31.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] doc: add removal note for power empty poll API
2022-10-07 13:40 ` [PATCH v3] " Reshma Pattan
@ 2022-10-31 15:26 ` Thomas Monjalon
2022-11-02 12:35 ` Pattan, Reshma
2022-11-02 12:31 ` [PATCH v4] doc: add removal warning " Reshma Pattan
1 sibling, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2022-10-31 15:26 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, David Hunt
07/10/2022 15:40, Reshma Pattan:
> --- a/doc/guides/prog_guide/power_man.rst
> +++ b/doc/guides/prog_guide/power_man.rst
> @@ -192,6 +192,14 @@ User Cases
> ----------
> The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
>
> +
> +Removal Note
> +------------
> +
> +The experimental empty poll APIs will be removed from the library in a future
> +DPDK release.
After more thoughts, I think it would be better highlighted if moved
at the beginning of the section "Empty Poll API".
It could a note block or a warning.
Also, could we explain how it is replaced?
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v3] doc: add removal note for power empty poll API
2022-10-31 15:26 ` Thomas Monjalon
@ 2022-11-02 12:35 ` Pattan, Reshma
0 siblings, 0 replies; 11+ messages in thread
From: Pattan, Reshma @ 2022-11-02 12:35 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Hunt, David
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
<snip>
> > +Removal Note
> > +------------
> > +
> > +The experimental empty poll APIs will be removed from the library in
> > +a future DPDK release.
>
> After more thoughts, I think it would be better highlighted if moved at the
> beginning of the section "Empty Poll API".
> It could a note block or a warning.
>
> Also, could we explain how it is replaced?
>
The empty poll API will be removed completely, because dpdk now has power pmd modes i.e. monitor, scale and pause which can be used for power saving over empty poll API.
V4 is sent now.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4] doc: add removal warning for power empty poll API
2022-10-07 13:40 ` [PATCH v3] " Reshma Pattan
2022-10-31 15:26 ` Thomas Monjalon
@ 2022-11-02 12:31 ` Reshma Pattan
2022-11-02 12:41 ` [PATCH v5] " Reshma Pattan
1 sibling, 1 reply; 11+ messages in thread
From: Reshma Pattan @ 2022-11-02 12:31 UTC (permalink / raw)
To: dev; +Cc: thomas, David Hunt, Reshma Pattan
Add removal warning for experimental empty poll API.
CC: David Hunt <david.hunt@intel.com>
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
doc/guides/prog_guide/power_man.rst | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index daad4d644d..88029bd079 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -110,6 +110,14 @@ The power management mechanism is used to save power when performing L3 forwardi
Empty Poll API
--------------
+Removal Warning
+~~~~~~~~~~~~~~~
+
+The experimental empty poll APIs will be removed from the library in a future
+DPDK release. The empty poll mechanism is superseded by the power pmd modes
+i.e. monitor, pause and scale.
+
+
Abstract
~~~~~~~~
@@ -192,6 +200,7 @@ User Cases
----------
The mechanism can applied to any device which is based on polling. e.g. NIC, FPGA.
+
Ethernet PMD Power Management API
---------------------------------
--
2.25.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v5] doc: add removal warning for power empty poll API
2022-11-02 12:31 ` [PATCH v4] doc: add removal warning " Reshma Pattan
@ 2022-11-02 12:41 ` Reshma Pattan
2022-11-15 15:35 ` Thomas Monjalon
0 siblings, 1 reply; 11+ messages in thread
From: Reshma Pattan @ 2022-11-02 12:41 UTC (permalink / raw)
To: dev; +Cc: thomas, Reshma Pattan, David Hunt
Add removal warning for experimental empty poll API.
CC: David Hunt <david.hunt@intel.com>
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
doc/guides/prog_guide/power_man.rst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst
index daad4d644d..0898426fba 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -110,6 +110,14 @@ The power management mechanism is used to save power when performing L3 forwardi
Empty Poll API
--------------
+Removal Warning
+~~~~~~~~~~~~~~~
+
+The experimental empty poll APIs will be removed from the library in a future
+DPDK release. The empty poll mechanism is superseded by the power pmd modes
+i.e. monitor, pause and scale.
+
+
Abstract
~~~~~~~~
--
2.31.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] doc: add removal warning for power empty poll API
2022-11-02 12:41 ` [PATCH v5] " Reshma Pattan
@ 2022-11-15 15:35 ` Thomas Monjalon
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2022-11-15 15:35 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, David Hunt
02/11/2022 13:41, Reshma Pattan:
> Add removal warning for experimental empty poll API.
>
> CC: David Hunt <david.hunt@intel.com>
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-11-15 15:35 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 15:22 [PATCH] doc: add removal note for power empty poll API Reshma Pattan
2022-08-30 9:23 ` Hunt, David
2022-10-05 8:44 ` [PATCH v2] " Reshma Pattan
2022-10-05 12:27 ` Thomas Monjalon
2022-10-07 13:54 ` Pattan, Reshma
2022-10-07 13:40 ` [PATCH v3] " Reshma Pattan
2022-10-31 15:26 ` Thomas Monjalon
2022-11-02 12:35 ` Pattan, Reshma
2022-11-02 12:31 ` [PATCH v4] doc: add removal warning " Reshma Pattan
2022-11-02 12:41 ` [PATCH v5] " Reshma Pattan
2022-11-15 15:35 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).