From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Haiyue Wang <haiyue.wang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Harman Kalra <hkalra@marvell.com>,
Rasesh Mody <rmody@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>,
Maciej Czekaj <mczekaj@marvell.com>,
Jian Wang <jianwang@trustnetic.com>,
Rosen Xu <rosen.xu@intel.com>,
Tianfei zhang <tianfei.zhang@intel.com>,
David Marchand <david.marchand@redhat.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
Date: Fri, 27 Aug 2021 14:30:44 +0200 [thread overview]
Message-ID: <6419779.oJmSqRMgos@thomas> (raw)
In-Reply-To: <CALBAE1My=w3KP2ChTLJKAdg8QAUidYcmapseEkwzA8C-bawxVg@mail.gmail.com>
17/08/2021 14:54, Jerin Jacob:
> On Tue, Aug 17, 2021 at 5:59 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Fri, Jul 30, 2021 at 01:05:48PM +0530, jerinj@marvell.com wrote:
> > > From: Jerin Jacob <jerinj@marvell.com>
> > >
> > > Since meson 0.59.0 version, the extract_all_objects() API
> > > need to pass explicit boolean value.
> > >
> > > To remove the following warning[1], added explicit `true` for
> > > extract_all_objects() use in codebase whever there is
> > > no argument.
> > >
> > > [1]
> > > WARNING: extract_all_objects called without setting recursive
> > > keyword argument. Meson currently defaults to
> > > non-recursive to maintain backward compatibility but
> > > the default will be changed in the future.
> > >
> >
> > Technically this is changing the default behaviour since it previously
> > defaulted to "false". However, since there should be no recursion involved
> > here anyway, I don't think it matters, correct?
>
> Yes. To be on the safer side, I just put "true" in case some drivers
> using for a recursive way.
Bruce, are you OK with the change?
next prev parent reply other threads:[~2021-08-27 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 5:24 [dpdk-dev] [PATCH] drivers: remove meson 0.46.0 warning jerinj
2021-07-30 7:35 ` [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0 jerinj
2021-08-17 12:29 ` Bruce Richardson
2021-08-17 12:54 ` Jerin Jacob
2021-08-27 12:30 ` Thomas Monjalon [this message]
2021-08-27 12:55 ` Bruce Richardson
2021-08-27 14:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6419779.oJmSqRMgos@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=haiyue.wang@intel.com \
--cc=hkalra@marvell.com \
--cc=irusskikh@marvell.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=mczekaj@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).