From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 827414402B;
	Tue, 14 May 2024 13:30:52 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6EF4F40608;
	Tue, 14 May 2024 13:30:52 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id D51C2402EB
 for <dev@dpdk.org>; Tue, 14 May 2024 13:30:51 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 488001007;
 Tue, 14 May 2024 04:31:16 -0700 (PDT)
Received: from [10.57.4.224] (unknown [10.57.4.224])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 890C53F641;
 Tue, 14 May 2024 04:30:50 -0700 (PDT)
Message-ID: <6429a5ad-b017-4b78-bab2-7d669166197f@arm.com>
Date: Tue, 14 May 2024 12:30:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] dts: clean up config types
Content-Language: en-GB
To: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240509105704.1162449-1-luca.vizzarro@arm.com>
 <20240509105704.1162449-3-luca.vizzarro@arm.com>
 <CAOb5WZaAyBCH4UwfJu6O3HFMtFNdPZvSf9VDv_hYsBSV1ipGUg@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAOb5WZaAyBCH4UwfJu6O3HFMtFNdPZvSf9VDv_hYsBSV1ipGUg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 13/05/2024 17:12, Juraj Linkeš wrote:
>> diff --git a/dts/framework/testbed_model/traffic_generator/__init__.py b/dts/framework/testbed_model/traffic_generator/__init__.py
>> @@ -39,8 +39,8 @@ def create_traffic_generator(
>>       Returns:
>>           A traffic generator capable of capturing received packets.
>>       """
>> -    match traffic_generator_config.traffic_generator_type:
>> -        case TrafficGeneratorType.SCAPY:
>> +    match traffic_generator_config:
>> +        case ScapyTrafficGeneratorConfig():
>>               return ScapyTrafficGenerator(tg_node, traffic_generator_config)
>>           case _:
>>               raise ConfigurationError(
> 
> Just one minor ask, could you fix the error string to an f-string?

Ack.