From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id D8546326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 12:12:35 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id w43so206874247wrb.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 03:12:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=B2V0faeTtPwjevXQZapUrvV1+xK8t9jDhUg4q3M+4DU=;
 b=pwhn5vXxp59klTVCYGDhBIR0mmW62Wq8M3hrMmjGx02DiGv3a4uFw/yC5zFbg4b8YA
 tBcZW53CjG6V1zy8xC4Cp3Vm3xx/qQHvWPnqgDu04JRvtNLfHW0NyPyur4y1Hn5z343G
 W4Hz3hpxtfps06i3Jq1ktxR1yVgnB6v/47j+mbiU4Bt0c19T7ITuWJiljz/XtuR8Iuke
 ylANV9uQrP+I8iaXS7u/SZR9+88+xM8GzaWgO3hV72WTE+atl/4KUd+fLGv/7n6eFy5n
 ghxkEP3Jkhw8Ho7e3m4cmswhv93U7XTO83AIpvCK8JgN7JyhU2J34xb8gqmJ+1+AR67N
 AOqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=B2V0faeTtPwjevXQZapUrvV1+xK8t9jDhUg4q3M+4DU=;
 b=ocENgQYr7TvKMrd5UM93UB/xxis4Kb6D/zMD+/0ndD5qHzkrpjVaDxVLt3Kz/zaE3Q
 E2JJgiyQX0TZdDK9Wsi8+E8YcFOPWyBUNG0YIxfXaPyNMLUEcCU31/iHpsNW5V4yo+q8
 CGL3dxH3nJ9qvOx08tDunb+2sd+AnDNTx+ZC9+kwEJNL632j3kwmM8M7MABgw/ziBbAe
 4XY/jsEk7zDf/VmvtyVOWvIvStGlc88FHcA5KTABS9kbqcwePmi3kDkqiAwee2S4mmkr
 sI0rFz70Xv8tGRuhpjH49MR1Dm68QnHIRjy1lSYjqPfXg+MTH7oMexQU6ToGR4u0fPrd
 Cciw==
X-Gm-Message-State: AFeK/H2CbROd83aik6YsEJfNz1uXrT4ej154o/P/wvUJlMdlx5INYguP5gOwc96sxiQ63g2G
X-Received: by 10.28.181.78 with SMTP id e75mr7436520wmf.105.1491300755384;
 Tue, 04 Apr 2017 03:12:35 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id j2sm19157775wrd.26.2017.04.04.03.12.34
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 04 Apr 2017 03:12:34 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org
Date: Tue, 04 Apr 2017 12:12:33 +0200
Message-ID: <6430789.TYnjRxi5iG@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20170331020913.19004-1-qi.z.zhang@intel.com>
References: <20170331020913.19004-1-qi.z.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 0/2] clean up interrupt handle
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Apr 2017 10:12:36 -0000

Hi,

2017-03-30 22:09, Qi Zhang:
> It seems its not necessary to register an intr_handle for interrupt callback 
> function. "void* cb_arg" shows enough when be used to pass the object that 
> contain the information be required to handle the interrupt event( A typical
> way which is implemented by almost all driver is by passing a rte_ethdev 
> instance). The patch change the prototype of rte_intr_callback_fn by removing
> the uncessary intr_handle paramter.
> 
> v3:
> - update bnx2x driver which is missed in v1,v2
> 
> v2:
> - seperate patch 1 in v1 into 2 patches.
> - correct some commit log.
> 
> Qi Zhang (2):
>   eal: clean up interrupt handle
>   app/test: update test code

Several comments:

* You forgot to use --in-reply-to, so it is not convenient to check the history.

* Please keep the the prior acked-by in your patches if there are.

* There is another miss in this patch:

drivers/net/mlx5/mlx5_ethdev.c:1259:10:
fatal error: incompatible pointer types passing
'void (struct rte_intr_handle *, void *)'
to parameter of type 'rte_intr_callback_fn'
(aka 'void (*)(void *)') [-Wincompatible-pointer-types]
    mlx5_dev_interrupt_handler,

* The second patch is clearly not up to date as the file
app/test/test_interrupts.c has moved.