* [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods
2020-02-17 11:35 [dpdk-dev] [PATCH 0/2] improve Travis coverage Thomas Monjalon
@ 2020-02-17 11:35 ` Thomas Monjalon
2020-02-17 14:06 ` Thomas Monjalon
2020-02-17 16:42 ` Aaron Conole
2020-02-17 11:35 ` [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
` (2 subsequent siblings)
3 siblings, 2 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 11:35 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana
The kernel modules are not built by default since below commit.
The Travis CI matrix can be simplified
by removing the redundant option enable_kmods=false,
and by removing some jobs which become redundant.
Note: there is no benefit in checking kmods in Travis Ubuntu.
Anyway different kernel versions and distributions are needed,
and the Technical Board is looking at moving the Linux kmods
out of this repository.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
.travis.yml | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 22539d8238..19422d4b3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -38,8 +38,6 @@ before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh
env:
- DEF_LIB="static"
- DEF_LIB="shared"
- - DEF_LIB="static" OPTS="-Denable_kmods=false"
- - DEF_LIB="shared" OPTS="-Denable_kmods=false"
- DEF_LIB="shared" RUN_TESTS=1
matrix:
@@ -50,13 +48,13 @@ matrix:
apt:
packages:
- *build_32b_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1
+ - env: DEF_LIB="static" AARCH64=1
compiler: gcc
addons:
apt:
packages:
- *aarch64_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1
+ - env: DEF_LIB="shared" AARCH64=1
compiler: gcc
addons:
apt:
@@ -75,13 +73,7 @@ matrix:
packages:
- *extra_packages
- *doc_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: gcc
- addons:
- apt:
- packages:
- - *extra_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
+ - env: DEF_LIB="static" EXTRA_PACKAGES=1
compiler: gcc
addons:
apt:
@@ -106,18 +98,6 @@ matrix:
packages:
- *extra_packages
- *doc_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: clang
- addons:
- apt:
- packages:
- - *extra_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: clang
- addons:
- apt:
- packages:
- - *extra_packages
- env: DEF_LIB="static"
arch: arm64
compiler: gcc
@@ -146,7 +126,7 @@ matrix:
apt:
packages:
- *required_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
+ - env: DEF_LIB="shared" BUILD_DOCS=1
arch: arm64
compiler: gcc
addons:
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods
2020-02-17 11:35 ` [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
@ 2020-02-17 14:06 ` Thomas Monjalon
2020-02-17 16:42 ` Aaron Conole
1 sibling, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 14:06 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Aaron Conole, Michael Santana, david.marchand
17/02/2020 12:35, Thomas Monjalon:
> The kernel modules are not built by default since below commit.
> The Travis CI matrix can be simplified
> by removing the redundant option enable_kmods=false,
> and by removing some jobs which become redundant.
>
> Note: there is no benefit in checking kmods in Travis Ubuntu.
> Anyway different kernel versions and distributions are needed,
> and the Technical Board is looking at moving the Linux kmods
> out of this repository.
Missed this line:
Fixes: 91a861e54164 ("config: disable Linux kernel modules by default")
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods
2020-02-17 11:35 ` [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-17 14:06 ` Thomas Monjalon
@ 2020-02-17 16:42 ` Aaron Conole
2020-02-17 16:46 ` Bruce Richardson
1 sibling, 1 reply; 17+ messages in thread
From: Aaron Conole @ 2020-02-17 16:42 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Michael Santana
Thomas Monjalon <thomas@monjalon.net> writes:
> The kernel modules are not built by default since below commit.
> The Travis CI matrix can be simplified
> by removing the redundant option enable_kmods=false,
> and by removing some jobs which become redundant.
>
> Note: there is no benefit in checking kmods in Travis Ubuntu.
> Anyway different kernel versions and distributions are needed,
> and the Technical Board is looking at moving the Linux kmods
> out of this repository.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Looks good to me, but do you think there's no benefit to even compiling
the kernel modules that get shipped?
Otherwise,
Acked-by: Aaron Conole <aconole@redhat.com>
> .travis.yml | 28 ++++------------------------
> 1 file changed, 4 insertions(+), 24 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 22539d8238..19422d4b3c 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -38,8 +38,6 @@ before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh
> env:
> - DEF_LIB="static"
> - DEF_LIB="shared"
> - - DEF_LIB="static" OPTS="-Denable_kmods=false"
> - - DEF_LIB="shared" OPTS="-Denable_kmods=false"
> - DEF_LIB="shared" RUN_TESTS=1
>
> matrix:
> @@ -50,13 +48,13 @@ matrix:
> apt:
> packages:
> - *build_32b_packages
> - - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1
> + - env: DEF_LIB="static" AARCH64=1
> compiler: gcc
> addons:
> apt:
> packages:
> - *aarch64_packages
> - - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1
> + - env: DEF_LIB="shared" AARCH64=1
> compiler: gcc
> addons:
> apt:
> @@ -75,13 +73,7 @@ matrix:
> packages:
> - *extra_packages
> - *doc_packages
> - - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> - compiler: gcc
> - addons:
> - apt:
> - packages:
> - - *extra_packages
> - - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> + - env: DEF_LIB="static" EXTRA_PACKAGES=1
> compiler: gcc
> addons:
> apt:
> @@ -106,18 +98,6 @@ matrix:
> packages:
> - *extra_packages
> - *doc_packages
> - - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> - compiler: clang
> - addons:
> - apt:
> - packages:
> - - *extra_packages
> - - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> - compiler: clang
> - addons:
> - apt:
> - packages:
> - - *extra_packages
> - env: DEF_LIB="static"
> arch: arm64
> compiler: gcc
> @@ -146,7 +126,7 @@ matrix:
> apt:
> packages:
> - *required_packages
> - - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
> + - env: DEF_LIB="shared" BUILD_DOCS=1
> arch: arm64
> compiler: gcc
> addons:
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods
2020-02-17 16:42 ` Aaron Conole
@ 2020-02-17 16:46 ` Bruce Richardson
2020-02-17 18:00 ` Thomas Monjalon
0 siblings, 1 reply; 17+ messages in thread
From: Bruce Richardson @ 2020-02-17 16:46 UTC (permalink / raw)
To: Aaron Conole; +Cc: Thomas Monjalon, dev, Michael Santana
On Mon, Feb 17, 2020 at 11:42:37AM -0500, Aaron Conole wrote:
> Thomas Monjalon <thomas@monjalon.net> writes:
>
> > The kernel modules are not built by default since below commit.
> > The Travis CI matrix can be simplified
> > by removing the redundant option enable_kmods=false,
> > and by removing some jobs which become redundant.
> >
> > Note: there is no benefit in checking kmods in Travis Ubuntu.
> > Anyway different kernel versions and distributions are needed,
> > and the Technical Board is looking at moving the Linux kmods
> > out of this repository.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> Looks good to me, but do you think there's no benefit to even compiling
> the kernel modules that get shipped?
>
> Otherwise,
> Acked-by: Aaron Conole <aconole@redhat.com>
>
>
I think we need one compile that turns them on to test.
/Bruce
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods
2020-02-17 16:46 ` Bruce Richardson
@ 2020-02-17 18:00 ` Thomas Monjalon
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 18:00 UTC (permalink / raw)
To: Aaron Conole, Bruce Richardson; +Cc: dev, Michael Santana
17/02/2020 17:46, Bruce Richardson:
> On Mon, Feb 17, 2020 at 11:42:37AM -0500, Aaron Conole wrote:
> > Thomas Monjalon <thomas@monjalon.net> writes:
> >
> > > The kernel modules are not built by default since below commit.
> > > The Travis CI matrix can be simplified
> > > by removing the redundant option enable_kmods=false,
> > > and by removing some jobs which become redundant.
> > >
> > > Note: there is no benefit in checking kmods in Travis Ubuntu.
> > > Anyway different kernel versions and distributions are needed,
> > > and the Technical Board is looking at moving the Linux kmods
> > > out of this repository.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> >
> > Looks good to me, but do you think there's no benefit to even compiling
> > the kernel modules that get shipped?
> >
> > Otherwise,
> > Acked-by: Aaron Conole <aconole@redhat.com>
> >
> I think we need one compile that turns them on to test.
I don't think so.
Travis is compiling only on Ubuntu.
Kernel modules compilation must be tested on old kernels (RHEL)
and latest ones (Fedora).
^ permalink raw reply [flat|nested] 17+ messages in thread
* [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds
2020-02-17 11:35 [dpdk-dev] [PATCH 0/2] improve Travis coverage Thomas Monjalon
2020-02-17 11:35 ` [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
@ 2020-02-17 11:35 ` Thomas Monjalon
2020-02-17 18:00 ` Aaron Conole
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 0/2] improve Travis coverage Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage Thomas Monjalon
3 siblings, 1 reply; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 11:35 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana
The Travis compilation is missing some dependencies to build these PMDs:
- af_xdp (libbpf)
- ipn3ke (libfdt)
- mlx (libibverbs)
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 19422d4b3c..bb32c8edcc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,7 +24,7 @@ aarch64_packages: &aarch64_packages
extra_packages: &extra_packages
- *required_packages
- - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
+ - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
build_32b_packages: &build_32b_packages
- *required_packages
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds
2020-02-17 11:35 ` [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
@ 2020-02-17 18:00 ` Aaron Conole
2020-02-17 21:19 ` Thomas Monjalon
0 siblings, 1 reply; 17+ messages in thread
From: Aaron Conole @ 2020-02-17 18:00 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Michael Santana
Thomas Monjalon <thomas@monjalon.net> writes:
> The Travis compilation is missing some dependencies to build these PMDs:
> - af_xdp (libbpf)
> - ipn3ke (libfdt)
> - mlx (libibverbs)
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
I was going to wait until travis finished to ACK this but I think it's
okay. I'll check back in on it later.
Acked-by: Aaron Conole <aconole@redhat.com>
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 19422d4b3c..bb32c8edcc 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -24,7 +24,7 @@ aarch64_packages: &aarch64_packages
>
> extra_packages: &extra_packages
> - *required_packages
> - - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
> + - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
>
> build_32b_packages: &build_32b_packages
> - *required_packages
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds
2020-02-17 18:00 ` Aaron Conole
@ 2020-02-17 21:19 ` Thomas Monjalon
2020-02-17 21:38 ` Aaron Conole
0 siblings, 1 reply; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 21:19 UTC (permalink / raw)
To: dev; +Cc: Michael Santana, Aaron Conole, christian.ehrhardt, bluca
17/02/2020 19:00, Aaron Conole:
> Thomas Monjalon <thomas@monjalon.net> writes:
>
> > The Travis compilation is missing some dependencies to build these PMDs:
> > - af_xdp (libbpf)
> > - ipn3ke (libfdt)
> > - mlx (libibverbs)
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> I was going to wait until travis finished to ACK this but I think it's
> okay. I'll check back in on it later.
>
> Acked-by: Aaron Conole <aconole@redhat.com>
>
> > extra_packages: &extra_packages
> > - *required_packages
> > - - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
> > + - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
It failed because libbpf is not available:
Unable to locate package libbpf-dev
I will re-spin a v2 without libbpf (not enabling af_xdp PMD).
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds
2020-02-17 21:19 ` Thomas Monjalon
@ 2020-02-17 21:38 ` Aaron Conole
0 siblings, 0 replies; 17+ messages in thread
From: Aaron Conole @ 2020-02-17 21:38 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Michael Santana, christian.ehrhardt, bluca
Thomas Monjalon <thomas@monjalon.net> writes:
> 17/02/2020 19:00, Aaron Conole:
>> Thomas Monjalon <thomas@monjalon.net> writes:
>>
>> > The Travis compilation is missing some dependencies to build these PMDs:
>> > - af_xdp (libbpf)
>> > - ipn3ke (libfdt)
>> > - mlx (libibverbs)
>> >
>> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>
>> I was going to wait until travis finished to ACK this but I think it's
>> okay. I'll check back in on it later.
>>
>> Acked-by: Aaron Conole <aconole@redhat.com>
>>
>> > extra_packages: &extra_packages
>> > - *required_packages
>> > - - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
>> > + - [libbsd-dev, libbpf-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
>
> It failed because libbpf is not available:
> Unable to locate package libbpf-dev
>
> I will re-spin a v2 without libbpf (not enabling af_xdp PMD).
Okay. Feel free to keep my ack :)
^ permalink raw reply [flat|nested] 17+ messages in thread
* [dpdk-dev] [PATCH v2 0/2] improve Travis coverage
2020-02-17 11:35 [dpdk-dev] [PATCH 0/2] improve Travis coverage Thomas Monjalon
2020-02-17 11:35 ` [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-17 11:35 ` [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
@ 2020-02-17 22:33 ` Thomas Monjalon
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage Thomas Monjalon
3 siblings, 2 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 22:33 UTC (permalink / raw)
To: dev
Remove some useless jobs and add more packages
to build more PMDs in Travis.
v2: remove libbpf because not available
Thomas Monjalon (2):
ci: remove redundant configs disabling kmods
ci: enable more drivers in Travis builds
.travis.yml | 30 +++++-------------------------
1 file changed, 5 insertions(+), 25 deletions(-)
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] ci: remove redundant configs disabling kmods
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 0/2] improve Travis coverage Thomas Monjalon
@ 2020-02-17 22:33 ` Thomas Monjalon
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
1 sibling, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 22:33 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana, Jerin Jacob
The kernel modules are not built by default since below commit.
The Travis CI matrix can be simplified
by removing the redundant option enable_kmods=false,
and by removing some jobs which become redundant.
Note: there is no benefit in checking kmods in Travis Ubuntu.
Anyway different kernel versions and distributions are needed,
and the Technical Board is looking at moving the Linux kmods
out of this repository.
Fixes: 91a861e54164 ("config: disable Linux kernel modules by default")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Aaron Conole <aconole@redhat.com>
---
.travis.yml | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 22539d8238..19422d4b3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -38,8 +38,6 @@ before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh
env:
- DEF_LIB="static"
- DEF_LIB="shared"
- - DEF_LIB="static" OPTS="-Denable_kmods=false"
- - DEF_LIB="shared" OPTS="-Denable_kmods=false"
- DEF_LIB="shared" RUN_TESTS=1
matrix:
@@ -50,13 +48,13 @@ matrix:
apt:
packages:
- *build_32b_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1
+ - env: DEF_LIB="static" AARCH64=1
compiler: gcc
addons:
apt:
packages:
- *aarch64_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1
+ - env: DEF_LIB="shared" AARCH64=1
compiler: gcc
addons:
apt:
@@ -75,13 +73,7 @@ matrix:
packages:
- *extra_packages
- *doc_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: gcc
- addons:
- apt:
- packages:
- - *extra_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
+ - env: DEF_LIB="static" EXTRA_PACKAGES=1
compiler: gcc
addons:
apt:
@@ -106,18 +98,6 @@ matrix:
packages:
- *extra_packages
- *doc_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: clang
- addons:
- apt:
- packages:
- - *extra_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: clang
- addons:
- apt:
- packages:
- - *extra_packages
- env: DEF_LIB="static"
arch: arm64
compiler: gcc
@@ -146,7 +126,7 @@ matrix:
apt:
packages:
- *required_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
+ - env: DEF_LIB="shared" BUILD_DOCS=1
arch: arm64
compiler: gcc
addons:
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH v2 2/2] ci: enable more drivers in Travis builds
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 0/2] improve Travis coverage Thomas Monjalon
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
@ 2020-02-17 22:33 ` Thomas Monjalon
1 sibling, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-17 22:33 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana
The Travis compilation is missing some dependencies to build these PMDs:
- af_xdp (libbpf)
- ipn3ke (libfdt)
- mlx (libibverbs)
Note: libbpf is not yet available on Ubuntu.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Aaron Conole <aconole@redhat.com>
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 19422d4b3c..40268cd1be 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,7 +24,7 @@ aarch64_packages: &aarch64_packages
extra_packages: &extra_packages
- *required_packages
- - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
+ - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
build_32b_packages: &build_32b_packages
- *required_packages
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* [dpdk-dev] [PATCH v3 0/2] improve Travis coverage
2020-02-17 11:35 [dpdk-dev] [PATCH 0/2] improve Travis coverage Thomas Monjalon
` (2 preceding siblings ...)
2020-02-17 22:33 ` [dpdk-dev] [PATCH v2 0/2] improve Travis coverage Thomas Monjalon
@ 2020-02-18 21:20 ` Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
` (2 more replies)
3 siblings, 3 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-18 21:20 UTC (permalink / raw)
To: dev
Remove some useless jobs and add more packages
to build more PMDs in Travis.
v3: reword commit logs
v2: remove libbpf because not available
Thomas Monjalon (2):
ci: remove redundant configs disabling kmods
ci: enable more drivers in Travis builds
.travis.yml | 30 +++++-------------------------
1 file changed, 5 insertions(+), 25 deletions(-)
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH v3 1/2] ci: remove redundant configs disabling kmods
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage Thomas Monjalon
@ 2020-02-18 21:20 ` Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
2020-02-18 22:36 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage David Marchand
2 siblings, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-18 21:20 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana, Jerin Jacob
The kernel modules are not built by default since below commit.
The Travis CI matrix can be simplified
by removing the redundant option enable_kmods=false,
and by removing some jobs which are redundant.
Note: there is no benefit in checking kmods in Travis Ubuntu.
Anyway different kernel versions and distributions are needed,
and the Technical Board is looking at moving the Linux kmods
out of this repository.
Fixes: 91a861e54164 ("config: disable Linux kernel modules by default")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Aaron Conole <aconole@redhat.com>
---
.travis.yml | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 22539d8238..19422d4b3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -38,8 +38,6 @@ before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh
env:
- DEF_LIB="static"
- DEF_LIB="shared"
- - DEF_LIB="static" OPTS="-Denable_kmods=false"
- - DEF_LIB="shared" OPTS="-Denable_kmods=false"
- DEF_LIB="shared" RUN_TESTS=1
matrix:
@@ -50,13 +48,13 @@ matrix:
apt:
packages:
- *build_32b_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1
+ - env: DEF_LIB="static" AARCH64=1
compiler: gcc
addons:
apt:
packages:
- *aarch64_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1
+ - env: DEF_LIB="shared" AARCH64=1
compiler: gcc
addons:
apt:
@@ -75,13 +73,7 @@ matrix:
packages:
- *extra_packages
- *doc_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: gcc
- addons:
- apt:
- packages:
- - *extra_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
+ - env: DEF_LIB="static" EXTRA_PACKAGES=1
compiler: gcc
addons:
apt:
@@ -106,18 +98,6 @@ matrix:
packages:
- *extra_packages
- *doc_packages
- - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: clang
- addons:
- apt:
- packages:
- - *extra_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
- compiler: clang
- addons:
- apt:
- packages:
- - *extra_packages
- env: DEF_LIB="static"
arch: arm64
compiler: gcc
@@ -146,7 +126,7 @@ matrix:
apt:
packages:
- *required_packages
- - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
+ - env: DEF_LIB="shared" BUILD_DOCS=1
arch: arm64
compiler: gcc
addons:
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread* [dpdk-dev] [PATCH v3 2/2] ci: enable more drivers in Travis builds
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
@ 2020-02-18 21:20 ` Thomas Monjalon
2020-02-18 22:36 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage David Marchand
2 siblings, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-18 21:20 UTC (permalink / raw)
To: dev; +Cc: Aaron Conole, Michael Santana
The Travis compilation is missing some dependencies to build all PMDs.
More PMDs are enabled in Travis which runs Ubuntu Bionic Beaver (18.04):
- ipn3ke (libfdt)
- mlx (libibverbs)
The next Ubuntu LTS, Focal Fossa (20.04) will allow to support more:
- af_xdp (libbpf)
- Intel crypto (libipsec-mb 0.53)
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Aaron Conole <aconole@redhat.com>
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 19422d4b3c..40268cd1be 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,7 +24,7 @@ aarch64_packages: &aarch64_packages
extra_packages: &extra_packages
- *required_packages
- - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4, abigail-tools]
+ - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4, abigail-tools]
build_32b_packages: &build_32b_packages
- *required_packages
--
2.25.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [dpdk-dev] [PATCH v3 0/2] improve Travis coverage
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 0/2] improve Travis coverage Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 1/2] ci: remove redundant configs disabling kmods Thomas Monjalon
2020-02-18 21:20 ` [dpdk-dev] [PATCH v3 2/2] ci: enable more drivers in Travis builds Thomas Monjalon
@ 2020-02-18 22:36 ` David Marchand
2 siblings, 0 replies; 17+ messages in thread
From: David Marchand @ 2020-02-18 22:36 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Aaron Conole, Bruce Richardson
On Tue, Feb 18, 2020 at 10:20 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Remove some useless jobs and add more packages
> to build more PMDs in Travis.
>
> v3: reword commit logs
> v2: remove libbpf because not available
>
> Thomas Monjalon (2):
> ci: remove redundant configs disabling kmods
> ci: enable more drivers in Travis builds
>
> .travis.yml | 30 +++++-------------------------
> 1 file changed, 5 insertions(+), 25 deletions(-)
About enabling kmod compilation again, this can be done in a followup patch.
For the series,
Acked-by: David Marchand <david.marchand@redhat.com>
Rebased on master, cache for abi checks jobs deleted.
Series applied.
--
David Marchand
^ permalink raw reply [flat|nested] 17+ messages in thread