From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9797C2904 for ; Wed, 28 Jun 2017 17:50:05 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 08:50:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,276,1496127600"; d="scan'208";a="1165700039" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2017 08:50:02 -0700 To: Shreyansh Jain , dev@dpdk.org Cc: hemant.agrawal@nxp.com References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com> From: Ferruh Yigit Message-ID: <643705f9-1bc9-67bc-6339-e7902c65c3ba@intel.com> Date: Wed, 28 Jun 2017 16:50:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1497591668-3320-36-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 35/38] net/dpaa: add support for packet type parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 15:50:06 -0000 On 6/16/2017 6:41 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +static const uint32_t * > +dpaa_supported_ptypes_get(struct rte_eth_dev *dev) > +{ > + static const uint32_t ptypes[] = { > + /*todo -= add more types */ > + RTE_PTYPE_L2_ETHER, > + RTE_PTYPE_L3_IPV4, > + RTE_PTYPE_L3_IPV4_EXT, > + RTE_PTYPE_L3_IPV6, > + RTE_PTYPE_L3_IPV6_EXT, > + RTE_PTYPE_L4_TCP, > + RTE_PTYPE_L4_UDP, > + RTE_PTYPE_L4_SCTP > + }; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (dev->rx_pkt_burst == dpaa_eth_queue_rx) Isn't this only rx function exists? Is this check required? > + return ptypes; > + return NULL; > +} > > static int dpaa_eth_dev_start(struct rte_eth_dev *dev) > { > @@ -159,6 +180,10 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_vfs = 0; > dev_info->max_vmdq_pools = ETH_16_POOLS; > dev_info->flow_type_rss_offloads = DPAA_RSS_OFFLOAD_ALL; > + dev_info->rx_offload_capa = > + (DEV_RX_OFFLOAD_IPV4_CKSUM | > + DEV_RX_OFFLOAD_UDP_CKSUM | > + DEV_RX_OFFLOAD_TCP_CKSUM); I guess this patch also enable L3/L4 Rx checksum offload, can you please update commit log. And should ol_flags set with one of the PKT_RX_IP_CKSUM_BAD, PKT_RX_IP_CKSUM_GOOD, PKT_RX_IP_CKSUM_NONE? Also with L4 versions of these? <...> > + > + m->tx_offload = annot->parse.ip_off[0]; > + m->tx_offload |= (annot->parse.l4_off - annot->parse.ip_off[0]) > + << DPAA_PKT_L3_LEN_SHIFT; This is a received mbuf right? Is it required to set tx_offload flag? > + > + /* Set the hash values */ > + m->hash.rss = (uint32_t)(rte_be_to_cpu_64(annot->hash));> + m->ol_flags = PKT_RX_RSS_HASH; > + > + /* Check if Vlan is present */ > + if (prs & DPAA_PARSE_VLAN_MASK) > + m->ol_flags |= PKT_RX_VLAN_PKT; I guess PKT_RX_VLAN_STRIPPED is the preferred flag now. <...>