From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9014EA0A0C; Sun, 8 Aug 2021 13:14:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CF3440683; Sun, 8 Aug 2021 13:14:52 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C36B04067E; Sun, 8 Aug 2021 13:14:50 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A47255C011C; Sun, 8 Aug 2021 07:14:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 08 Aug 2021 07:14:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= c7CKjgROPaNTioZrHcggvxU4dKZVj+4pIodj7gNUiNc=; b=Z6rleZh6hfu0e4XF 8qmf4KpdT5xjilx+/tQzv4yjRV+2Goxp/zSbHNL48eyzmZyrpl8cJZLBl8WWxs/c 7NQUMxtMuKAvciVXlOAIRCvGm2gkmOjbvZZc6o4Yj01Tvit0QUsBod/vw+uMphc3 BYtumEoEu4bme0nv6Ngdy5ciSvUxkDPjX+SMJc6GFOJPn5lGR9RiKSv4qqcZKYmI 3DXxq5wefEttulxI9CVpcuv+8F07lRMpCb1I6qoUza8rz3dUriym6l9RoQbrV5oE zL/OseyTnuwQwirWBhVv6k0P7YBSPRGxpDGClu8bzinN8EI+aohHEqVfrHZtTWaL vBiqKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=c7CKjgROPaNTioZrHcggvxU4dKZVj+4pIodj7gNUi Nc=; b=ROjwrXPVlkAiTMiGG2iwxvC6k4xi99hJAnBcKux/bQZBj3pM6rv8237Gw lPNkoXbAh2abS650WF6yNtipudxvqCbWi/bXAO6vF3BaG3tFxlQapU53+dq9JI4K tkmUu9VYv5vslxZ0h9K2CBKD53qOj6kzgkbApFix5X0TdM9Z2MZg2VBi2FLtqWVg Lau9V9waDrm2+e3bucNRpvp8UvF4UUm1wOUbJq4n5f/UmZoOjEVHsE+NrQmftbiQ EAOna9hJ5IL+LWpmf5peLmlpIgm91Kr28Py6m6LoGa6ku72WIO6vB+gP7AQ8EinB QJKHPcQvisf0WXDexlyOMm2UT3VLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 07:14:32 -0400 (EDT) From: Thomas Monjalon To: Xueming Li Cc: dev@dpdk.org, stable@dpdk.org, Christian Ehrhardt , david.marchand@redhat.com, Luca Boccassi Date: Sun, 08 Aug 2021 13:14:31 +0200 Message-ID: <6438723.YY6MpAsgIJ@thomas> In-Reply-To: <20210630063416.9550-1-xuemingl@nvidia.com> References: <20210616040324.311461-1-xuemingl@nvidia.com> <20210630063416.9550-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] devtools: fix version pattern for fix search X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/06/2021 08:34, Xueming Li: > When scanning fixes from current(HEAD) branch, local tags were included > and reported as version. For example: > $ git tag --contains --merged > 20.11_backport_202010506 // user tag > v20.11 > v20.11.1 > > This patch matches DPDK officail version pattern in search, selects > the most early tag. Official tag pattern: "v." > > Fixes: 752d8e097ec1 ("scripts: show fixes with release version of bug") > Cc: Thomas Monjalon > Cc: stable@dpdk.org > > Signed-off-by: Xueming Li > Reviewed-by: Christian Ehrhardt > --- > devtools/git-log-fixes.sh | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 210c8dcf25..153ba5b438 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -38,12 +38,13 @@ range="$*" > # get major release version of a commit > commit_version () # > { > + local VER="v*.*" Which tag is it supposed to match? What would not be matched? What about something like v19.11.8 ? What about the above example 20.11_backport_202010506? > # use current branch as history reference > local refbranch=$(git rev-parse --abbrev-ref HEAD) > - local tag=$( (git tag -l --contains $1 --merged $refbranch 2>&- || > + local tag=$( (git tag -l "$VER" --contains $1 --sort=creatordate --merged $refbranch 2>&- || Why adding "--sort=creatordate" ? It is not mentioned in the commit log. > # tag --merged option has been introduced in git 2.7.0 > # below is a fallback in case of old git version > - for t in $(git tag -l --contains $1) ; do > + for t in $(git tag -l "$VER" --contains $1) ; do > git branch $refbranch --contains $t | > sed "s,.\+,$t," > done) |