From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id AE9E81150;
 Wed, 19 Dec 2018 04:13:26 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 6A0851568;
 Tue, 18 Dec 2018 22:13:25 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 18 Dec 2018 22:13:25 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=aKl2z/TluWRbLXxJnVuH+l9dLnVSXIUfl4ba8bhZNNw=; b=ZAid6zXlyt6j
 8k7/1o9kGoOf1vkgzYohjD+RwUMR83qWXQ0mXzNsljr4itLCRBQsTqndczvdO7VU
 kQY83uAuPNKI7iIjbwcKl9tprsj/BVvY61VdZsgYgPWLLMu42k9tdBkGEMM9vyDN
 y3o9r7L0c4/UVwfFY3zhwIBNYEhfKHE=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=aKl2z/TluWRbLXxJnVuH+l9dLnVSXIUfl4ba8bhZN
 Nw=; b=DCutBRg/5mvsNvzPAaCKX9oQ88HarOf7XQEIMiAghO+kuiyLl0PpYxoGP
 nNmPu1OEhkEaFDE17tcD3LW7h8XTX8X2M/CyvqsHUEvzQyGSmANhrvU0DlFNEhzk
 uxSARiqILjV7V9V2QGZKCRtVjsN9QUnvViqfFuaSmEjaIP3PjAr6MfU1LUxiyWko
 s/PEt11DZ8U1twavlRfPKo+8ONQuzv0jM+wL4pSjZQks3TVUCmX+7ggmlDMcChVz
 2lXmneyt66Y/7Wm09cRjYvrDV3a59FLru2kE1q1voLA7GV5/P+8uetsqtnAKDN+J
 NRqui5eY6l8upUPstX2VPuuySM/nA==
X-ME-Sender: <xms:VLcZXNLnHbqbtADS3xdexgKDb-ZBBHmT-ZaHyuLq6vLR2IP2uqwC1Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeiledgvdejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef
 tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg
 hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu
 oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd
 efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:VLcZXLcElIvxP56-diOsr6eXER6c2z6AVgf0ancZZmDd7BHhixKDNg>
 <xmx:VLcZXEbJyZGSC5Fl3AkRMT8SWN6d55tTRgWNGhbTYt74yMRsR27q7g>
 <xmx:VLcZXLWsdBdXl4HRDMEVPqYe4XqaPtw7lk7-lhEjBSC-htRyQ3u6tA>
 <xmx:VbcZXDvR20e_R-sjEduGZTR9aNIb3-kfUBkaGrT1S87wyGlTN8fGMg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6606810106;
 Tue, 18 Dec 2018 22:13:23 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 vipin.varghese@intel.com, stable@dpdk.org
Date: Wed, 19 Dec 2018 04:13:22 +0100
Message-ID: <6439206.RFcLErheRT@xps>
In-Reply-To: <7096e585fd36399cea92dd32fe1f19b051697bec.1542124270.git.anatoly.burakov@intel.com>
References: <88cced4f601c44c6203b9adb09abacdce0b3a260.1542122595.git.anatoly.burakov@intel.com>
 <7096e585fd36399cea92dd32fe1f19b051697bec.1542124270.git.anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on
	initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 03:13:27 -0000

13/11/2018 16:54, Anatoly Burakov:
> When creating process data structures, EAL will create many files
> in EAL runtime directory. Because we allow multiple secondary
> processes to run, each secondary process gets their own unique
> file. With many secondary processes running and exiting on the
> system, runtime directory will, over time, create enormous amounts
> of sockets, fbarray files and other stuff that just sits there
> unused because the process that allocated it has died a long time
> ago. This may lead to exhaustion of disk (or RAM) space in the
> runtime directory.
> 
> Fix this by removing every unlocked file at initialization that
> matches either socket or fbarray naming convention. We cannot be
> sure of any other files, so we'll leave them alone. Also, remove
> similar code from mp socket code.
> 
> We do it at the end of init, rather than at the beginning, because
> secondary process will use primary process' data structures even
> if the primary itself has died, and we don't want to remove those
> before we lock them.
> 
> Bugzilla ID: 106
> 
> Cc: stable@dpdk.org
> 
> Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks