From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 241CBA2F70 for ; Tue, 8 Oct 2019 13:05:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 501D21C1F8; Tue, 8 Oct 2019 13:05:12 +0200 (CEST) Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id 2B1991C123 for ; Tue, 8 Oct 2019 13:05:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1175; q=dns/txt; s=iport; t=1570532711; x=1571742311; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=I9VOXa/ZFDXl3YygM0TK0dJgDSGugQq4ZI6HERlvmK8=; b=Hlm6LeWQrrM37GSr43LGHhIo7d/LFiQeiThYpk52oQG0gezJO0amnApo swXVKkxDJRNHhP/wmrPjQ6318oxDnjBTHxKcNJXvp5VK9UYfb9aFJ9yxD lJqTp8b2dfVs+fP20o3Jlklfz2yb8VUcPXzObMLgLpeAKPM2JPZJ02JAF w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAABzbJxd/4cNJK1mGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQEBAQEBEQEBAQEBAQEBAQEBgWcEAQEBAQELAYIdgXIqCow7iE+ZK4F?= =?us-ascii?q?7CQEBAQwBAS8BAYRAAoJDIzQJDgIDCQEBBAEBAQIBBQRthS0MhUsBAQEBAzo?= =?us-ascii?q?yCgMMBAIBCBEEAQEfEDIdCAIEAQ0FCIUlrHOCJ4pEgTQBjA0YgX+EIz6ELh2?= =?us-ascii?q?FXgSPNJ4OCh2CBZUSI4I6lwaOLYE/l3cCERWBMiA5gVhwFYMnUBAUiASIEUM?= =?us-ascii?q?xkEiBIwEB?= X-IronPort-AV: E=Sophos;i="5.67,270,1566864000"; d="scan'208";a="643278921" Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 08 Oct 2019 11:05:09 +0000 Received: from XCH-RCD-001.cisco.com (xch-rcd-001.cisco.com [173.37.102.11]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x98B59Ir007477 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 8 Oct 2019 11:05:09 GMT Received: from xch-aln-004.cisco.com (173.36.7.14) by XCH-RCD-001.cisco.com (173.37.102.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 8 Oct 2019 06:05:09 -0500 Received: from xch-aln-004.cisco.com ([173.36.7.14]) by XCH-ALN-004.cisco.com ([173.36.7.14]) with mapi id 15.00.1473.003; Tue, 8 Oct 2019 06:05:09 -0500 From: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" To: "Phil Yang (Arm Technology China)" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , Honnappa Nagarahalli , "Damjan Marion (damarion)" , nd , "Gavin Hu (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier Thread-Index: AQHVW/3zzaAsyGi130SZ5JUheRsAdadQ2Dvg Date: Tue, 8 Oct 2019 11:05:09 +0000 Message-ID: <643c7eb281aa4b1e832f9d7f34af741f@XCH-ALN-004.cisco.com> References: <1566817214-26599-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.61.163.177] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Outbound-SMTP-Client: 173.37.102.11, xch-rcd-001.cisco.com X-Outbound-Node: alln-core-2.cisco.com Subject: Re: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > -----Original Message----- > > From: dev On Behalf Of Phil Yang > > Sent: Monday, August 26, 2019 7:00 PM > > To: jgrajcia@cisco.com; dev@dpdk.org > > Cc: thomas@monjalon.net; jerinj@marvell.com; Honnappa Nagarahalli > > ; damarion@cisco.com; nd > > > Subject: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way > > barrier > > > > Using 'rte_mb' to synchronize the shared ring head/tail between > > producer and consumer will stall the pipeline and damage performance > > on the weak memory model platforms, such like aarch64. Meanwhile > > update the shared ring head and tail are observable and ordered between > CPUs on IA. > > > > Optimized this full barrier with the one-way barrier can improve the > > throughput. On aarch64 n1sdp server this patch make testpmd throughput > > boost 2.1%. On Intel E5-2640, testpmd got 3.98% performance gain. > > > > Signed-off-by: Phil Yang > > Reviewed-by: Gavin Hu The patch is looking good, but 'MEMIF_VERSION_MAJOR' in memif.h needs to be set to 3 as ring pointers are no longer volatile.