From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Liron Himi <lironh@marvell.com>,
wangyunjian <wangyunjian@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "jerry.lilijun@huawei.com" <jerry.lilijun@huawei.com>,
"xudingke@huawei.com" <xudingke@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix memory leak in error path
Date: Fri, 23 Oct 2020 17:31:33 +0100 [thread overview]
Message-ID: <64413c49-7548-9f1a-f336-54edd870ee70@intel.com> (raw)
In-Reply-To: <DM5PR18MB2214E16C575EB0E975D2272DC61D0@DM5PR18MB2214.namprd18.prod.outlook.com>
On 10/22/2020 7:40 AM, Liron Himi wrote:
<...>
> Subject: [EXT] [dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path
>
> External Email
>
> ----------------------------------------------------------------------
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> In mrvl_create() allocated memory for 'mtr', we don't free it when profile get fails and it will lead to memory leak.
>
> We can get profile at the beginning of the function to fix it, before calling mtr = rte_zmalloc_socket().
>
> Fixes: cdb53f8da628 ("net/mvpp2: support metering")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Acked-by: Liron Himi <lironh@marvell.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-23 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 4:25 [dpdk-dev] " wangyunjian
2020-10-22 6:40 ` [dpdk-dev] [EXT] " Liron Himi
2020-10-23 16:31 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64413c49-7548-9f1a-f336-54edd870ee70@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=lironh@marvell.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).