From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 2D237902
 for <dev@dpdk.org>; Fri, 19 Jun 2015 15:36:41 +0200 (CEST)
Received: by wiga1 with SMTP id a1so19381579wig.0
 for <dev@dpdk.org>; Fri, 19 Jun 2015 06:36:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=1YJrEizkNJZR1gbJKQjNwCEaIoJqbTZjcSLnv0+FNDc=;
 b=FhoqfCX9yjJcOkQ47NBgh/wjo0k+i2EFZPHxk7RswtB5G+ry2lAB5GbNJU4xKrt0rK
 zYStpFF3aKD2xlZrkc1TtHtxZv1oAFopo8wJJNaGwnVx3hNwbrALVDJewKs+l9HpfEhD
 q5EBpoF4PNhCJNXIxQSGW5zQYkiFkTwIrpocdPQAMTN28kt+emG8j2/RZYhDqycf+z6/
 vjKNACl3NxUuqcp3rVycnIRdzDxP/gSxCJF0lAx0mcfO/tF/HPQyIcP0LB56+qsh4cJh
 p5ykBaRgBx2F0NLU2qv/j0T9+p3BkTKAmAiB5KnmrGMiISnCd4pvCyLx2bgQFklT7UBW
 5Qhw==
X-Gm-Message-State: ALoCoQm+j5z6u4GphAmsQgO+EqDM/6EHizJmGyjG942LLcG/iDFErEfbWoMng1MMC7+Ev3kRRhzb
X-Received: by 10.180.101.138 with SMTP id fg10mr6802635wib.46.1434721001028; 
 Fri, 19 Jun 2015 06:36:41 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ka7sm17113799wjc.36.2015.06.19.06.36.39
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 19 Jun 2015 06:36:40 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 19 Jun 2015 15:35:38 +0200
Message-ID: <6446943.entjzpE8eR@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <20150618100016.GA7972@bricha3-MOBL3>
References: <1433250693-23644-1-git-send-email-roman.dementiev@intel.com>
 <10408699.ljKKKDUIsH@xps13> <20150618100016.GA7972@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] spinlock: add support for HTM lock
	elision for x86
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jun 2015 13:36:41 -0000

2015-06-18 11:00, Bruce Richardson:
> On Wed, Jun 17, 2015 at 11:29:49PM +0200, Thomas Monjalon wrote:
> > Introducing rte_cpuflags.h in this header breaks the compilation of
> > the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y.
> > Indeed, it triggers the -pedantic flag which is not supported by rte_cpuflags.h.
> > Maybe it's time to fix this header?
> 
> Do all our headers need to support the pedantic C flag? I don't believe this
> was a previous requirement for header files. The mlx4 driver appears to be the
> only place in the dpdk.org codebase where the flag actually appears - and even
> then the flag disabled in mlx.c where the dpdk headers are actually included.
> 
>   73 /* DPDK headers don't like -pedantic. */$
>   74 #ifdef PEDANTIC$
>   75 #pragma GCC diagnostic ignored "-pedantic"$
>   76 #endif$
>   77 #include <rte_config.h>$
> 	.....

You're right. It seems this disabling doesn't work.

> I'm just not convinced that rte_cpuflags needs to be fixed at all here.

Yes, it's probably simpler to remove the -pedantic flag.