From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gregory@weka.io>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 37694A0E0
 for <dev@dpdk.org>; Fri, 26 May 2017 18:14:57 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id d127so25033361wmf.0
 for <dev@dpdk.org>; Fri, 26 May 2017 09:14:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google;
 h=from:to:cc:subject:date:message-id:organization:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=zr7SKSMnvmr2r+AxX8XCBiu7JS66QjQniEsFua0mXAk=;
 b=0rBfPf+44ZylFYiJPYvMLs7o5VHk636NqtyXZt7tadSu7Xa4XzT7FW0u3hAQggw61+
 yA6wVL2oKWV9U2zZsHBVHgpRyzqMI9zN1SOFvIJEO6uaE8V3VAqTXZH6oKK/URerhiUQ
 PiEzSnf1XowfIB0V/EIfsW+wY2uluuPDqZDe4=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=zr7SKSMnvmr2r+AxX8XCBiu7JS66QjQniEsFua0mXAk=;
 b=cFQO8WG/12DXtqRiwkeIG3xlSkLq25TuvhrAAXE2+CZAULmL9kkfrRCXd2d2ok/Ngk
 JrNS5sHKRZvp7gKiTbvWNbbIzBtKOkfFX8dNZ7M75CnA35NIOOMgkI4hcBnUhA3qBELB
 jLJKRl5pbMMBdvhGCs6sgT2Iw4yxmC1UTdmW7VlwGkIASPq47cRas9U5IQx51KYrJMca
 GFvZAwSmIsmWWGQrrViTVcaxCOh0uKXIcpfVJlu+hnuQMgKvi0oLpdlkrBZKCI5YVAZv
 KKYEqrpIUybo2YraDmnYB8j2dUKLyFFlBf3SlbyotoE7c03WTOSUNEKOIfaXAE4eAlPw
 lCcw==
X-Gm-Message-State: AODbwcBl1qn2SabWiWHzVKpe+vOgLoUtG+lPV/jSxWsmUvZfXg1HclSn
 /cYR9ljHdgG6UEnW
X-Received: by 10.28.163.2 with SMTP id m2mr2859755wme.3.1495815297649;
 Fri, 26 May 2017 09:14:57 -0700 (PDT)
Received: from polaris.localnet (bzq-84-109-69-99.red.bezeqint.net.
 [84.109.69.99])
 by smtp.gmail.com with ESMTPSA id u198sm12803447wmd.29.2017.05.26.09.14.56
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 26 May 2017 09:14:56 -0700 (PDT)
From: Gregory Etelson <gregory@weka.io>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>
Date: Fri, 26 May 2017 19:14:55 +0300
Message-ID: <6458984.zlYVzvDLUS@polaris>
Organization: Weka.IO
In-Reply-To: <20170526085321.75582301@xeon-e3>
References: <106841857.Z7q1jSDIte@polaris> <2910302.37N35vC6kd@polaris>
 <20170526085321.75582301@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 16:14:58 -0000

I did not look into VFIO driver yet

Regards,
Gregory

On Friday, 26 May 2017 18:53:21 IDT Stephen Hemminger wrote:
> On Fri, 26 May 2017 09:17:33 +0300
> Gregory Etelson <gregory@weka.io> wrote:
> 
> > Thank you.
> > 
> > Regards,
> > Gregory
> > 
> > On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote:
> > > On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote:
> > > 
> > > Hi Gregory,
> > > 
> > > The patch is useful for LiquidIO PMD as we can avoid VF FLR request to
> > > PF. One comment inline..
> > > 
> > > [..]
> > > > > >  
> > > > > > +static int
> > > > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > > > > > +{
> > > > > > +       int ret;
> > > > > > +       struct rte_uio_pci_dev *udev = info->priv;
> > > > > > +       struct pci_dev *dev = udev->pdev;
> > > > > > +       ret = __pci_reset_function(dev);
> > > 
> > > s/__pci_reset_function/pci_reset_function
> > > 
> > > > > > +       dev_info(&dev->dev, "pci_reset_function %s \n",
> > > > > > +                 ret == 0 ? "succeded" : "failed");
> > > > > > +       return 0;
> > > > > > +}
> > > [..]
> > > 
> > > Thanks,
> > > Shijith
> > > 
> > 
> 
> What does VFIO do?
> 
> It looks like in vfio case pci_enable is held off until open and pci_disable is done
> on close. There are other things that may need to be done to make close work
> correctly. Like turning of msix. Also reset may not always be possible.
>