From: "Burakov, Anatoly" <anatoly.burakov@intel.com> To: David Hunt <david.hunt@intel.com>, dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH v4 3/6] power: rename public structs Date: Fri, 22 Jan 2021 12:15:35 +0000 Message-ID: <6459584c-1535-0cbc-6847-001a4bec60ad@intel.com> (raw) In-Reply-To: <20210121172201.22582-4-david.hunt@intel.com> On 21-Jan-21 5:21 PM, David Hunt wrote: > From: Bruce Richardson <bruce.richardson@intel.com> > > rename the public structs to have an rte_power_ prefix and > add them to version.map in experimental section. > > Fixes: 210c383e247b ("power: packet format for vm power management") > Fixes: cd0d5547e873 ("power: vm communication channels in guest") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > Signed-off-by: David Hunt <david.hunt@intel.com> > > --- > changes in v4 > * Improve sizeof's > * add the 2 functions to the version.map file > --- <snip> > diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h > index c500c0cda..c9ab7bae8 100644 > --- a/lib/librte_power/rte_power_guest_channel.h > +++ b/lib/librte_power/rte_power_guest_channel.h > @@ -11,7 +11,10 @@ extern "C" { > #include <stdint.h> > #include <stdbool.h> > > -/* --- Incoming messages --- */ > +#define MAX_VFS 10 > +#define VM_MAX_NAME_SZ 32 > +#define MAX_VCPU_PER_VM 8 > +#define HOURS 24 > These and other defines are in public header, and they're not under RTE_ namespace. To avoid clashes with user code, I would suggest either adding an RTE_ prefix, or maybe #undef'ing them at the end of the file. -- Thanks, Anatoly
next prev parent reply other threads:[~2021-01-22 12:15 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-17 11:36 [dpdk-dev] [PATCH v1] power: fix make build for power apps David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH 0/6] " David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 1/6] power: create guest channel public header file David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 0/6] power: fix make build for power apps David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 1/6] power: create guest channel public header file David Hunt 2021-01-20 15:09 ` Burakov, Anatoly 2021-01-20 15:12 ` David Hunt 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 0/6] power: fix make build for power apps David Hunt 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 2/6] power: make channel msg functions public David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 3/6] power: rename public structs David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 4/6] power: rename defines David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 5/6] power: add new header file to export list David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 6/6] power: clean up includes David Hunt 2021-01-29 10:30 ` [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps Thomas Monjalon 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 2/6] power: make channel msg functions public David Hunt 2021-01-22 12:12 ` Burakov, Anatoly 2021-02-22 9:53 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 3/6] power: rename public structs David Hunt 2021-01-22 12:15 ` Burakov, Anatoly [this message] 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-28 22:57 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2021-02-22 9:56 ` Ferruh Yigit 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 4/6] power: rename defines David Hunt 2021-01-22 13:50 ` Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-dev] [PATCH v4 5/6] power: add new header file to export list David Hunt 2021-01-22 13:51 ` Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-dev] [PATCH v4 6/6] power: clean up includes David Hunt 2021-01-22 13:53 ` Burakov, Anatoly 2021-01-29 10:27 ` [dpdk-dev] [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps Thomas Monjalon 2021-02-24 14:54 ` [dpdk-dev] [PATCH] power: remove duplicated symbols from map file Ferruh Yigit 2021-02-25 9:11 ` David Marchand 2021-02-25 10:41 ` Ferruh Yigit 2021-02-25 10:44 ` David Marchand 2021-02-25 10:54 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 2021-02-25 14:38 ` David Marchand 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 2/6] power: make channel msg functions public David Hunt 2021-01-20 14:26 ` Burakov, Anatoly 2021-01-20 15:08 ` David Hunt 2021-01-20 15:23 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 3/6] power: rename public structs David Hunt 2021-01-20 14:27 ` Burakov, Anatoly 2021-01-20 15:03 ` David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 4/6] power: rename defines David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 5/6] power: add new header file to export list David Hunt 2021-01-20 14:28 ` Burakov, Anatoly 2021-01-20 15:01 ` David Hunt 2021-01-20 15:17 ` Burakov, Anatoly 2021-01-20 15:08 ` Bruce Richardson 2021-01-20 15:18 ` Burakov, Anatoly 2021-01-20 15:29 ` David Hunt 2021-01-20 15:43 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 6/6] power: clean up includes David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 2/6] power: make channel msg functions public David Hunt 2021-01-19 14:31 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2021-01-19 14:51 ` David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 3/6] power: rename public structs David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 4/6] power: rename defines David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 5/6] power: add new header file to export list David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 6/6] power: clean up includes David Hunt 2021-01-13 11:08 ` [dpdk-dev] [PATCH 0/6] power: fix make build for power apps Burakov, Anatoly 2021-01-13 11:14 ` David Hunt 2021-01-13 11:18 ` Burakov, Anatoly 2021-01-13 13:25 ` David Hunt 2021-01-13 17:30 ` Burakov, Anatoly
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6459584c-1535-0cbc-6847-001a4bec60ad@intel.com \ --to=anatoly.burakov@intel.com \ --cc=bruce.richardson@intel.com \ --cc=david.hunt@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git