From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2C814532C for ; Tue, 18 Jul 2017 16:24:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B4E5620926; Tue, 18 Jul 2017 10:24:23 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 18 Jul 2017 10:24:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=koKUGkEiU0dlNsu LsIayHBkb7zk6WYR2vHFQiyp4WJQ=; b=sknJ09C2bMywQIvMwBeMd+SSrOQJfCo OVi6zo8ufD/+6KnrQoV9DsgFoM+GHipfxBz/gYO8KKsbNknGWT/TcK0YMkcL1H0i rp/cY94Rg5dLrf0qNDkfx6xDuANwLhHAqsoFB1/aqYi8T0XTckfwajGWQOxHRtpw 06q+MvdpNp+0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=koKUGkEiU0dlNsuLsIayHBkb7zk6WYR2vHFQiyp4WJQ=; b=hYlAsgZl 6XIULpSp549//Vte0soA2pcwau2U3J1ebazbFfC84I4Hw/68kGrFW76EmVg9mb0a wjJXvglCCZRVKznt/en9EBVqol0jhX2t1CE810Pwo9DTilwCgbZIMGRxGMNlYIyW kBCLJ0MkMajEr4r2yGF2aLs4cNnju+qcPMUQrlaO1BnAJXvvsqnS4Rxlo2yQqyhe h9heizDS1X59jJaFzgS+spKVAZxpBO9Hkp1m4sfabfqaRfKMdwIi3uhTgDram8Dz 6WnPZ0zvt54HtYg4u4deY8O3mR4sxS4H44++Jg2OLfT92Jbr7lzy49Aoe66pdLAm FDFtJEhkNfoxzw== X-ME-Sender: X-Sasl-enc: 13JfL3cg/O12REBZ/9ZqWwhWOU39trJMN7ysFGWg5Ovi 1500387863 Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E3CA2418A; Tue, 18 Jul 2017 10:24:23 -0400 (EDT) From: Thomas Monjalon To: Changpeng Liu Cc: dev@dpdk.org Date: Tue, 18 Jul 2017 17:24:20 +0300 Message-ID: <6467798.dkg9oKoERO@xps> In-Reply-To: <1500106836-20010-1-git-send-email-changpeng.liu@intel.com> References: <1499491297-17800-1-git-send-email-changpeng.liu@intel.com> <1500106836-20010-1-git-send-email-changpeng.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost: introduce a new vhost-user-scsi sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 14:24:24 -0000 Hi, 15/07/2017 11:20, Changpeng Liu: > --- /dev/null > +++ b/examples/vhost_scsi/scsi_spec.h > @@ -0,0 +1,488 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright (c) Intel Corporation. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#ifndef _SCSI_SPEC_H > +#define _SCSI_SPEC_H This file is full of specification values. Ideally it should be included from somewhere else. If not possible, please add a comment in this file to explain where it comes from. Is it copied from other projects? Is there a link to the specification?