From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EE87A0A02; Thu, 25 Mar 2021 09:01:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E44240693; Thu, 25 Mar 2021 09:01:03 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 45CA64067B for ; Thu, 25 Mar 2021 09:01:02 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 374235C0090; Thu, 25 Mar 2021 04:00:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 25 Mar 2021 04:00:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 5oZxtTU7VcFSHPIfJ3JY3aX/3IESMmDnq6Cvmur2/T4=; b=fuRoHR7+07uAXGmB gmGeZAUCv6BZhyPPMBZj3qMXvcEHXZ9i+Vh/368fudIfR9A0UDveGQ91N21VZLuQ yCZ51hyRxGpNvFo0D1zWq/D4NUqNBikYntq4KE5F1NZiUE5LrIFg46nOVwIFr0uF XyJmE7PdmutHe9V5TWMPGOOgkYF2D36+b2dPnHKiwhn3YUkb8J/We08iRPRTuQL5 6LEESUXM77R5V/SbzgLEGHExvAxR3bCUHZoP9J6pc7tyb4eScHgkDqS7xefRov5+ E8bkz5W79OUIIYtrP9605tziltQYdo0Dm3QGTIk1WfI5CtABszbsPWpkiS8jBDbA D4iPLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5oZxtTU7VcFSHPIfJ3JY3aX/3IESMmDnq6Cvmur2/ T4=; b=lAt4bTSeuBpYgYIRrinGfdcLWNY6qotyrm1NnE19NZ/VB2dsLOcBKNBcZ fLpVj5Vl3j2bBxvZ86Z+Yo7u0IDJUM1jf7SryQxNlQcYNiO48HyIP0KfRC5c8x7Z RiUkIgfQBI+9RzZ3FkgL2DgecUoEsT9DeduIZLhCa8R4cLPIu0ACAi1gCciNA6y1 YH2sXklA75TEVBmRAm58KKWUCYiuAhrRAG6L2TupwcY+x5f6xRg40X81ZWS6jph4 cd6+pQjJ4L9YIE9l8w/ikxystwpqrg5FANfE5rgRsyCO7Po3fUTbOPqXjE9DMiEl 3JL42IYiiNIfXI/flkkN+j/cH1SwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegledguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtuf ertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfe eglefghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeejjedrudefgedr vddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 609AF1080066; Thu, 25 Mar 2021 04:00:57 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: Dmitry Kozlyuk , dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stephen@networkplumber.org, drc@linux.vnet.ibm.com Date: Thu, 25 Mar 2021 09:00:54 +0100 Message-ID: <6471682.gLmPldMPvt@thomas> In-Reply-To: <20210325000942.GA22319@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210325014147.2a2f5749@sovereign> <20210325000942.GA22319@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/03/2021 01:09, Tyler Retzlaff: > On Thu, Mar 25, 2021 at 01:41:47AM +0300, Dmitry Kozlyuk wrote: > > 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff: > > > > Can't speak for Seastar and Click, but we never hit this particular issue. > > What is the minimal complete example to reproduce? > > interesting, i did a bit more digging and it is clear why. i'm consuming > headers and crt that have been enhanced to enforce c++ standards > compliance. after dumping the preprocessed output i suspect this cannot > be reproduced with the publicly available headers it seems i'm the only > "beneficiary" heh. > > so the minimal example is really just to #include after including > say rte_windows.h but it won't reproduce for public users of the sdk. > > if there is a great deal of concern with respect to compatibility i > guess as the single consumer who has this problem i can just #undef asm > since we don't use inline asm anyway. > > thoughts? No please don't do this. There is an issue in DPDK which must be fixed. It seems your patch is correct, I am waiting for confirmation of others.