From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79980A0548; Mon, 20 Sep 2021 11:48:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0D5540DF7; Mon, 20 Sep 2021 11:48:23 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2F21940DF5 for ; Mon, 20 Sep 2021 11:48:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="223141799" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="223141799" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 02:48:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="556043127" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 20 Sep 2021 02:48:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 02:48:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 20 Sep 2021 02:48:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 20 Sep 2021 02:48:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkvkArBbZC6jYk4l+/eY5/o7FbnnX6UKtfQBWcrZ0lI0H6VCWv82yAs9X+xJPmx+uC/Z/nP2mRtd2eWeS0ZASCCghulM3Y2+hWCc8wVLtuIeOTbt26bLSsce6Ncguck1prTnYsDDeWr1piBT0nw5RbVY4qW1ipTfL8duJ9UrnH61RQPLIyO6+f1EXA3FVw5Ufhn1HrfhgPtvlHtZ6NgbDMpxw1LNw6E2HyCXiIxe7HdBNNIwhegXY3K5DwIBCcf65uuaTH9nS/7JLrxdp7csakJknX5Ics0f6MXBD/7BWCn8K1Xr4JgpDmvMelE1TAkGHk7Dk1NTjfSmhW+oqRjYBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UMolnUFWFdNnWX3eJiPr0pipSDBpb5U25qnCQsScOCs=; b=B0G34JtL0on7QIAIZfMdWtr6o5euK77mdzcoTOnmyLlCGPU8o4JnrHDVDlm8OBoHqdipIwjbNnU/l0G4TsY2CfG9h9oKke7hyN5oO6r6fVrs2AaDKQPbZfCzqz4y5Ebp2ILjKycsfXhsuztj8EAdaRKuMLYD99O/vSzJm/aqhclnfZuT+7FE7okR5omYqFR7yseUcHA/ooXeK30xaZ8L7pEZOJL+Llary4AGkKPmzBXkia2fjRZE9Xsp3HoYysZ9LNz7SF7KirTzMqDwcVCGXR9j332sILgmuxDunKv+mRDJ/sezF+Bghiwvf7nPqHrUYLtO/Vbr6EFZ4uXL+chozg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UMolnUFWFdNnWX3eJiPr0pipSDBpb5U25qnCQsScOCs=; b=YXEwSV8QiGfxMUeyaJLH8hrDlqC6Pt22aHOp3R7qeB7vj5Z+qfNxoZpkhyhrHy83WUw+u6rkWh1vYPhTXpdLvemdZhG7RWIb0LVLzuzwKc6Rz1wlBDT+sH/Sl8jYgvAJoLGlvHvrfamPAp84wwMSB5Qo5iFKbJbtg9kpO12J6YQ= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4807.namprd11.prod.outlook.com (2603:10b6:510:3a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Mon, 20 Sep 2021 09:48:20 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 09:48:20 +0000 To: Jie Wang , CC: , , References: <20210826070924.308368-1-jie1x.wang@intel.com> <20210827081740.365037-1-jie1x.wang@intel.com> <20210827081740.365037-3-jie1x.wang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <64739f26-8d21-ca49-a5fe-37c1c8abe96a@intel.com> Date: Mon, 20 Sep 2021 10:48:14 +0100 In-Reply-To: <20210827081740.365037-3-jie1x.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0084.eurprd03.prod.outlook.com (2603:10a6:6:30::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0084.eurprd03.prod.outlook.com (2603:10a6:6:30::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Mon, 20 Sep 2021 09:48:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d64ac41c-35f5-4d11-c761-08d97c1bc74d X-MS-TrafficTypeDiagnostic: PH0PR11MB4807: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s1FCdJ5HRkJa7a8GESBysGJjOUwjwgCX2YGlwTxVZmVAih/IhJ1sZr2acMqB6RGaw59SycJtRxwbg4NThaVIkH6V86sRA+rv8JVBuGOhg/wqIUU0Q14dgwNFhNrs59hng+TOdNyz1UhWPI1N6xKKxxk93sODnnEe3qrDblgYwIzUsJQnFWUFGml+NQKIaSFZw6z0+7Frg3KD+XIAZo0xoLwjk1qoZ3iAjTc0P7eyGRtVg5q1mnJCWc82JhvDVLfb7tuucQiiq/EuaV3BfN7+zvLs4W3LAyGXmPTiqCBEbhuHKEkdypJOhP04DDqfkZ0317uXUsLiN21z/sBdzG/oyRVaUih+nheEwXHWrgNwOlzR/ZBZAzvD2UaGh/n74fUCGxTxthhgqGLiIiDtg0lfkBpQtpO7nEl5JaOqUxeB1nTtWMaWlVPtEnrpBcUjcbkuNUIxEnEWngzTcF9LBYmV6PDlw9ollDmXjKgWU+AU3Esmaak9dtvaPjVsxXmshANES9tCtVnQoP4qndh6KpgyKSfIiXDFw03B8yGw0AtkUIaF/TNfS2JwgVZalTm0t8Pcw7pEUG9ws0iQKN/OOcqJSl9vuqUxcAyRmItqBt89zXBaFQ9A9fFrjPt+5w1jir84B7Fv9UMWeb8HLIi54mmJ90gsoGTwVHsLQSu+oxS4aAnkDc6MNP2PLVH1odaby6GQqOz46KGQlOtMPLxCUzmiTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(31686004)(6486002)(316002)(478600001)(44832011)(8936002)(2906002)(16576012)(186003)(83380400001)(66946007)(5660300002)(38100700002)(6666004)(66556008)(53546011)(31696002)(4326008)(8676002)(26005)(4744005)(956004)(36756003)(2616005)(66476007)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXZQT2lPWlJzUXI1cmNPKzhrQjJEK2JSTEREdGJKc3lEOFF2VE9wQzEramtv?= =?utf-8?B?bUdoNmVKc1k5QlhVTXFQTG9JN0QvR2Z3Yy9xQzRHekxBTlhLTXpiQWhqZE44?= =?utf-8?B?d1JVdld6TWxTYjhIQ2lNUWZJQkRtMmRWK1FSZHFYY3RDMWM2U2tobEczNzZP?= =?utf-8?B?T1NLYzc2ajNGSW5Za0pxelRVcTVhVTg5TlQwT3ZlcTlTWnVweFdEb2t4RzM1?= =?utf-8?B?eW9sTGVNTHFNK3U2cWZwZHJqTi85QW05RmNWMk50Rnk3dFZ5bGlOQXNSeE9T?= =?utf-8?B?aDMwRWowSVJVcEVHa1hSVHd1ZFVnMzVCaUV4dkZIT3BZcHoyc2NLNERoaFVw?= =?utf-8?B?Um51VTBiU09KdUVLNVVkWVJScTNsbzRRZTJPeS9YK21rWFdzU0JtRFh0SjRO?= =?utf-8?B?M1F1TXpNcGJGVHlicUx1N1VPT0xRcE0vdGNiWjE0eSt3WDZpTG55UWozZi9k?= =?utf-8?B?T3lmRlJLRDZkcXg3dm1OTm13UjgyUG1JWXVqMGZrVjdNYkUwRXR3RlBjTkdD?= =?utf-8?B?WTkwMlhSRkEyQVVVd3g5VHh0RWxVQWRwQVpWK2x1M21tck5RMFlPMXJsMm9h?= =?utf-8?B?Nkw1UFp1eC9wUjVoWEl1NWxEZlBNYkQ3THJRYmhhMG5LRGdYaHMzV0c0anNn?= =?utf-8?B?KzVoT0xSU0VlSDk1NEtqSGhPbGdoRUZhRjBDdkFNdm1hU1hoMm1WZmxLOFBp?= =?utf-8?B?WG9pa1RZTjFWeWYrbEJUMlFGVzJHRjkrZXFJeXFHR2J1ejFSYTJ1Ykx0QVFr?= =?utf-8?B?UDB2QzFjUndYK1kzZTNzaGRLZDdtbCswR2RQc3RNeFFZb0sxMk0yYmppYUU4?= =?utf-8?B?TkEwc3Y1b0dPK3FpSndUNVZnYVdSWHdnQmlkRWJyTm5PRUdsVHdsNjNiSjNC?= =?utf-8?B?dFZScmtjdko2a25oR0VmYUVUeGFKQnFpdzl2MkNiUHpnN3gvbXAwRVEwRWdu?= =?utf-8?B?VEdNTkw4dFVSNTNVQUZGM0h6ejRNNmtudVl5TDRnYnVVbSs2NFZSYWFmS2h6?= =?utf-8?B?SHd0YnUyaGR0TXJ2eGlzMXRCTTM4Z0hIVGV1VWRselBWOTFVdTRNNEUrN012?= =?utf-8?B?dThTTG9OVTVHQ1JNbGhXN0V3QUhiWCtwYWpVSFJ3aWw0M0FVU2lSRHRBOHFp?= =?utf-8?B?WHJsSnBvTUt6dytJd3A4YWxiZ09BdWppZUFYTllWTGsxYnVySGxJaFFkNHdO?= =?utf-8?B?d3J1QVRSSzBYQmRLNFMvd3p3VFpFalJNQ2QyYkZSaHYwbjZrZjFoYzBoc0lD?= =?utf-8?B?SE9TYVB2OWxqU3YyMVl4a3ZBcVlSY3kyRFdDVzA5K0VqV3VNeGlKYXljTWdi?= =?utf-8?B?azdrUi9aSlcwYzVYSlVYNGlPMUI3UmNrNXA3VXV6ampmaXNVNDhUTGNyZ0lN?= =?utf-8?B?Y200RmM5YzB0WWl4czlkdnVicUlaT3R3Rk8zVGVDbWl5TjREdWt5VFlUTExu?= =?utf-8?B?Nm45cFBhemZoWXkrZFoyb1cwaFdjOUdhVEpIbjhSMVd3dHBIbzlCcW0xSzBV?= =?utf-8?B?V2lmM01IQXNWa1k4V2VFanR0QllkK2NZdEplMnlzV3lTNHB5R05NN2g1MU9t?= =?utf-8?B?aWJBMVpIeWFaaVVESkN6dDhhakE3dDZrTHh3eHdiT1BwUWFWTFVPOS95TTNX?= =?utf-8?B?MVNocTFjRjRkYzZ2SFQwRzBzbG5UanpMZzhBMFRmYVBMK1JwaXRTSzhiZTR6?= =?utf-8?B?dDRZUzN3RmxzdmN5UGZwM2NqN29ybWV2WWs2UkNXOFk0b1VyVm9aVTdEem9h?= =?utf-8?Q?dj906NHOVDwl8hunuHcekMUq9LpYGhbGJECmI1r?= X-MS-Exchange-CrossTenant-Network-Message-Id: d64ac41c-35f5-4d11-c761-08d97c1bc74d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 09:48:20.0415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /gDGNtxjxoLwTqtwuMC9Ut3B+FlQBwYYJ+vNy0ztiN7TSreBeeyl3e4tdGMs1E8mHZGqIjzJ6NwtDvuPtPT/XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4807 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/27/2021 9:17 AM, Jie Wang wrote: > The driver may change offloads info into dev->data->dev_conf > in dev_configure which may cause port->dev_conf and port->rx_conf > contain outdated values. > > This patch updates the offloads info if it changes to fix this issue. > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > > Signed-off-by: Jie Wang <...> > + /* Apply Rx offloads configuration */ > + if (dev_conf_info.rxmode.offloads != > + port->dev_conf.rxmode.offloads) { > + port->dev_conf.rxmode.offloads = > + dev_conf_info.rxmode.offloads; > + for (k = 0; > + k < port->dev_info.max_rx_queues; > + k++) > + port->rx_conf[k].offloads = > + dev_conf_info.rxmode.offloads; If queue specific offloads are used, won't this overwrite it with port offload? Should we get queue config from device and update queue offloads with it?