* [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
@ 2017-11-19 4:55 Jerin Jacob
2017-12-12 14:33 ` Olivier MATZ
2017-12-12 15:12 ` santosh
0 siblings, 2 replies; 6+ messages in thread
From: Jerin Jacob @ 2017-11-19 4:55 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, santosh.shukla, Jerin Jacob
Use of rte_eal_mbuf_default_mempool_ops() API will
allow to override pool handler through "--mbuf-pool-ops-name"
eal command line argument.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
test/test/test_mempool_perf.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index 749b364ee..85b9f782d 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -313,6 +313,7 @@ test_mempool_perf(void)
struct rte_mempool *mp_cache = NULL;
struct rte_mempool *mp_nocache = NULL;
struct rte_mempool *default_pool = NULL;
+ const char *default_pool_ops;
int ret = -1;
rte_atomic32_init(&synchro);
@@ -336,6 +337,7 @@ test_mempool_perf(void)
if (mp_cache == NULL)
goto err;
+ default_pool_ops = rte_eal_mbuf_default_mempool_ops();
/* Create a mempool based on Default handler */
default_pool = rte_mempool_create_empty("default_pool",
MEMPOOL_SIZE,
@@ -344,21 +346,18 @@ test_mempool_perf(void)
SOCKET_ID_ANY, 0);
if (default_pool == NULL) {
- printf("cannot allocate %s mempool\n",
- RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ printf("cannot allocate %s mempool\n", default_pool_ops);
goto err;
}
- if (rte_mempool_set_ops_byname(default_pool,
- RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL)
+ if (rte_mempool_set_ops_byname(default_pool, default_pool_ops, NULL)
< 0) {
- printf("cannot set %s handler\n", RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ printf("cannot set %s handler\n", default_pool_ops);
goto err;
}
if (rte_mempool_populate_default(default_pool) < 0) {
- printf("cannot populate %s mempool\n",
- RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ printf("cannot populate %s mempool\n", default_pool_ops);
goto err;
}
@@ -378,7 +377,7 @@ test_mempool_perf(void)
/* performance test with 1, 2 and max cores */
printf("start performance test for %s (without cache)\n",
- RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+ default_pool_ops);
if (do_one_mempool_test(default_pool, 1) < 0)
goto err;
--
2.15.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
2017-11-19 4:55 [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection Jerin Jacob
@ 2017-12-12 14:33 ` Olivier MATZ
2018-01-18 14:12 ` Thomas Monjalon
2017-12-12 15:12 ` santosh
1 sibling, 1 reply; 6+ messages in thread
From: Olivier MATZ @ 2017-12-12 14:33 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, santosh.shukla
On Sun, Nov 19, 2017 at 10:25:31AM +0530, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> test/test/test_mempool_perf.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
My checkpatch sees this minor issue:
WARNING:TYPO_SPELLING: 'allow to' may be misspelled -
perhaps 'allow (without "to", see
http://english.stackexchange.com/questions/60271/grammatical-complements-for-allow/60285#60285)'?
I don't this it's critical, and the official checkpatch did not see it, so
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
2017-12-12 14:33 ` Olivier MATZ
@ 2018-01-18 14:12 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-01-18 14:12 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, Olivier MATZ, santosh.shukla
12/12/2017 15:33, Olivier MATZ:
> On Sun, Nov 19, 2017 at 10:25:31AM +0530, Jerin Jacob wrote:
> > Use of rte_eal_mbuf_default_mempool_ops() API will
> > allow to override pool handler through "--mbuf-pool-ops-name"
> > eal command line argument.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > test/test/test_mempool_perf.c | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
>
> My checkpatch sees this minor issue:
>
> WARNING:TYPO_SPELLING: 'allow to' may be misspelled -
> perhaps 'allow (without "to", see
> http://english.stackexchange.com/questions/60271/grammatical-complements-for-allow/60285#60285)'?
>
>
> I don't this it's critical, and the official checkpatch did not see it, so
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
2017-11-19 4:55 [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection Jerin Jacob
2017-12-12 14:33 ` Olivier MATZ
@ 2017-12-12 15:12 ` santosh
2018-01-17 23:18 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: santosh @ 2017-12-12 15:12 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: olivier.matz
On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
2017-12-12 15:12 ` santosh
@ 2018-01-17 23:18 ` Thomas Monjalon
2018-01-18 2:36 ` Jerin Jacob
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-01-17 23:18 UTC (permalink / raw)
To: Jerin Jacob; +Cc: dev, santosh, olivier.matz
12/12/2017 16:12, santosh:
>
> On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> > Use of rte_eal_mbuf_default_mempool_ops() API will
> > allow to override pool handler through "--mbuf-pool-ops-name"
> > eal command line argument.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Do you know why this patch is set as superseded in patchwork?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection
2018-01-17 23:18 ` Thomas Monjalon
@ 2018-01-18 2:36 ` Jerin Jacob
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2018-01-18 2:36 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, santosh, olivier.matz
-----Original Message-----
> Date: Thu, 18 Jan 2018 00:18:47 +0100
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org, santosh <santosh.shukla@caviumnetworks.com>,
> olivier.matz@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool
> ops selection
>
> 12/12/2017 16:12, santosh:
> >
> > On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> > > Use of rte_eal_mbuf_default_mempool_ops() API will
> > > allow to override pool handler through "--mbuf-pool-ops-name"
> > > eal command line argument.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> >
> > Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>
> Do you know why this patch is set as superseded in patchwork?
Changed back to new as it is intended to be.
It might have updated by mistake for the very similar patch heading
"test/mempool: improve default mempool ops selection"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-18 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-19 4:55 [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool ops selection Jerin Jacob
2017-12-12 14:33 ` Olivier MATZ
2018-01-18 14:12 ` Thomas Monjalon
2017-12-12 15:12 ` santosh
2018-01-17 23:18 ` Thomas Monjalon
2018-01-18 2:36 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).