From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 3B7A01B119 for ; Wed, 30 Jan 2019 12:28:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C908317DB; Wed, 30 Jan 2019 06:28:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 30 Jan 2019 06:28:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=hdzQHufai9787V72r9gSqS4+j42VS+uodGwfCgLYmD0=; b=Qr19llCkcUP+ ETjj4dhd/R1PLb6xg9vGj8fDLsr5LNBEzYmcK6OEZXgZjZIiedr3ySlcIQIXuGwQ NLwrcI8mUMtzOCm0LhQqWRcdOfGRZ5ecpxKSVpdo5wJdUPnxz8RG+De1LVrjxa8K 0TSD0x55ZDXI838HizUNxvf/H30E42g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hdzQHufai9787V72r9gSqS4+j42VS+uodGwfCgLYm D0=; b=TN0fy310axbiwmF4PC1eRCG+p/L+mjtN0mEE3NqFnVOYn6CKZildL2lj8 MelqXopXC8skqtYCV8USZLogOCsTvE3sMK0oAZyytTVZABspAvagwm6lXnk8zlZw f1/ikOHMslg4KQDmLqeUssHeLD8MkC4Wd234D9PVj6vzcjq1LtH7K208DTiZMV0C 21SOMcNDvUmPt6qY301J+zSpOE2IPoktni2nRfv654aU4ZhLNsYuaEYNvWAwFY8o zhM7VRKA7C2Ie9KakdEHrfIH00tC1n/7A4WOu3LHUoQnqhy4z9tvppJaf1pnssSe cBvTLz3P4T7xR9uRLn0leNCgn4Htg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeeggddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrihhnpegthhgvtghkph grthgthhgvshdrshhhnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EAA7100BB; Wed, 30 Jan 2019 06:28:01 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , David Marchand Cc: dev@dpdk.org, Qi Zhang Date: Wed, 30 Jan 2019 12:27:58 +0100 Message-ID: <6481538.UeMWjqPEGc@xps> In-Reply-To: <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com> References: <20190129153052.38634-1-ferruh.yigit@intel.com> <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 11:28:04 -0000 30/01/2019 12:17, Ferruh Yigit: > On 1/30/2019 9:58 AM, David Marchand wrote: > > The contributing guide does indicate you are supposed to run both > > checkpatches.sh and check-git-log.sh. > > I am pretty sure I missed this second step in the past.. > > > > How about calling check-git-log.sh from checkpatches.sh ? > > check-git-log.sh does not support patch files as input, so it would need > > support for it. > > That sounds good idea to have single script to run. It will never be only one script to run. There are more scripts in devtools and I plan to add more. Some checks can be done only once for a group of commits, and will be really too slow if run for each patch when merging a branch. About check-git-log, some tests cannot be possible outside of a git tree. Do you want to run it when checkpatches is run on git tree? Wouldn't it be confusing?