From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A32443C9F; Wed, 13 Mar 2024 12:21:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3D6440A84; Wed, 13 Mar 2024 12:21:46 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 3155B402B8 for ; Wed, 13 Mar 2024 12:21:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvNWKojY+XWgAaGhEzNbcGG7Cw+G+KY9Ws8azqBSE5dmn8gzg0plKdCPT4JavIK3gQeF0aL1V22NE34BLkyVcHjILK0YP4iyhahKsG01d97uZxt1LFhU/5/vn/fH2ewLcs7ofwuDgiqkLjTVj3HTogyyK6UeM3723p+bbN+9VbYYX1qKTH6JScvsweullZHw7VUjrulNP6PmpBuyWo7FASXHmUB70dGBzhkq9gFql7xSoY5MvbT4tyTJZ9ZSAqZXPTmrq1m2H29CG+WNpR5sbr2+M1069Rz3TGp7uDxJ0WXylU6chrSGETEZzEWST6Xv73q2lnUrjX+cKCDkhSw88w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uJtR8rZQrclKR7noS+RrCMb2Vmfjiqwnz+7jymqZ17E=; b=gJz3moWcaMwMvAB/NcskIklyiXFL481ifRE2yvM30dhiver2lB+ACxaXHKCXaeexyc+Ia7clb7FGbg8KWa0x64luITa28BdPaD4yMzPxrROydM3/zXUo1I+GmtaV5xz8ZS8RHh2nuzCEGek8OPzahJTKfbPRs7KG65Nu2qnQQCPDE3yElBGIdV8a5/hW2ASr59pZVagmr0PErI6nXTriwqYM3CtW6fkbpgjXXsF3KpOX/tIqjA5nYXhZu3LruCgm+siKBWHx/jyp8J7dlzT0McvWkGz5iAQgvhIgmtFLgT6QGsbka49zN5E731AuczQexTwS7gJzYRjLhCKyWzNMEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uJtR8rZQrclKR7noS+RrCMb2Vmfjiqwnz+7jymqZ17E=; b=IO8Bu9f3lukT3dOLATk60nHDJNioWYP2LmDJeUZiqnyoeTyVDAmGnXH7R9xy59mbB3ZkMTiD9n/AP4ibyHwZb2RmXigM49SoRT5o2GTOrtNishMGSgOue/Gxrq7H9DgW2q1LjgA1tCQgw2e0aEi/4BA10aNpzYkVjbOAY8zYnz0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7371.namprd12.prod.outlook.com (2603:10b6:806:29a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 11:21:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 11:21:43 +0000 Message-ID: <64842348-8742-4da0-a99f-ff57f9bde6d0@amd.com> Date: Wed, 13 Mar 2024 11:21:39 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/33] net/ena: restructure the llq policy setting process Content-Language: en-US To: "Brandes, Shai" Cc: "dev@dpdk.org" References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-8-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0622.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7371:EE_ X-MS-Office365-Filtering-Correlation-Id: ef6f451a-6ff2-44d8-ce2e-08dc434fc2fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HY/V5v67G3/5xjlihtMJcaP2oY2H5d+TliDgS/a0q88APwl679AoBXy5GhkG+9BthI3UauMtxVcjUBxh4/uYoynGFdl8sRbDtHhPi2GUR4B+mbs5YgUyXcnbKnjyOknuI5t6My/UitdzgB9aiF/Wl3Jl/Iu6Hh6n8I8QFiDyYoQuuYk4uaFDe6Esyt4ctaWaLUaYW1JwTZqR9vHH+bPQRWXxtnw2WxSgxEJn8IkPHHHoF8obqNxkeahdB2tKwIT59bTUrwHtvsJDAAbQinKMyuE9rdlVtRs2okPfaoeuxyhMQ7tCOBMLVgRwqkfHpTxNu9+60hHhYfXOwRMJOC4lUIiwp6ahgjY50s1kH9f5weuZFDnFx4PKzvgbYWRaEkf34bZdnxSW1KRQtjhYGsmesT/W4ZCKeJtjzgznrbRlv6qVWh9J2HDHMN9T6j7IpFyXnJBZ0JBF2oPNHk9Ncs45iWCDx2Q+Aoni27zXn//eO5W6Why4QyRhfllc1KvjHxDH55vwSfxJDdopvUr+Z0sI6wRWyNjJUgO2xgEI3e6EpzOq5c344RrVqoW6DJqbq1SBtRjXbKwa8RsM9rGWU+NrrOy82Rp2Vsj5Dn5VtCFFssldS9ANJrpm+64h1oass737tZ+hqaurlfyVeTuz9BbxuOXpfGwKNHJB/XF33YrV6Cw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFRrajZVclIwUnJWQXJYVVNhTkpIRDhwK1pjdWNJQkpKMjVYeG5qNXFyTUxX?= =?utf-8?B?OTQ0dEUzKzFRbHJDcWFLR1phVERKVElzZTc4ZVVLdWFKK1c0NkF1MG85RjNM?= =?utf-8?B?UStWbzZQbHZBVERrNXgvMGxQekZVTVpRVGRvUDkvdlBGcDRHMTJBWHhjenBm?= =?utf-8?B?NVE5Wld6OGZtZCtjeit1TlZyNmNBL2FTdzNicGM5dW1SYjBsRGJnY1Q5MW41?= =?utf-8?B?RUgwUnpFbGxlbkN3bnhVYmVNOU9pekQwazVQV1F2bHhoMVdjYzB5ZFFtUlU4?= =?utf-8?B?YjZ6dU4wWmxWNnJmZnlyZ3p3T2J4NE5zNVlxWHBSc1doMHFjNDBwWUtzTmla?= =?utf-8?B?d0lnbGVMRXExMk45dWZTejM2d0ZoTHVzSStMN293RVpPczkrcGRDcXEraDV0?= =?utf-8?B?bUJJNnQ0REo3V1ZDZWVuNE5rS1RiSjhjTThiNU94eXNBSnlrWjdFSnZ4MEtL?= =?utf-8?B?dzh6VWxmWllTMVk5UnhSSHRYeTF3L2VTZEwwY25wVnZkSzkxQmNJQjlYbjRS?= =?utf-8?B?QkxyZmxqaDNxSGdQMmR0NHZlNGtwbldBWUFadUNrTUkyYWdTK0hMNVNIS3ht?= =?utf-8?B?ZEJmZDVTSTNBNHdWZXlNTm50Q2Y3MyswNE9wMWxGcXNsM3FiYzVmcUkraUdq?= =?utf-8?B?bUx5emhIQzVCeHJVZDJSUm9lT3NtZ0xPcUhMZjg3ck5tcGs1UDRDQVVyc0lw?= =?utf-8?B?U1I0Q21yeUtvNjJVS1l2R2JqZ1dYUmUybmRGL3dTSUt4MlBocVVpL1pKWDdy?= =?utf-8?B?RElMZWtsYUl0cHhkcVdERE01a3NJMnN1RDVHR1JIVEdHakpsNUFUcnplMmlt?= =?utf-8?B?Z3hRN2J6V2Jvcy9QUjMxVXYybGNDM2JSelVINXcydjRRem0xUE9ZNTMzVkk2?= =?utf-8?B?cE5ISkk5Qm1PL3ZGWjFReHpWa0hrNGpvZXNrSFRFeGY2cVMwa3QrN2xoWFo5?= =?utf-8?B?REY1a2pZUFJMUDJCR2tIUUN6R1lBcUlURkluNDNGSDJrNllzSk85TnNvd3pK?= =?utf-8?B?aFFscEdCb2tWa0c1VnU1b3JhZ0lBT3F1ZGp0U0psOG9Obkwvb2NFelZYc2Rm?= =?utf-8?B?WFBoTVpvdWRSWXVoTW9Mc204WWhzV3VQSnN2ZktOUDNhQURYUEpra2tBeUIv?= =?utf-8?B?VkdFcEtWa0psaU1NRzdKYnZ0WmpKK2svczZzRXE3L0w3eXBpWTlsWDBaaWR5?= =?utf-8?B?Mk1lZHZUK1hhRndWRnFicGU0cVNybTVSV2t5R3QyQWU3RjdJRmsxbFFVb1Aw?= =?utf-8?B?OWo5U3EzVlh4TEJjLytJbmpycmp4cFNrMS9ZSUp4eDdld1dZd2p3cW9DWCtE?= =?utf-8?B?UWxNY2tRbGZXU0RPMGsxSWJMYWhuVmJnRjdzR3Z1aVVFME5tdHRyckJDVTN5?= =?utf-8?B?VWMvU2dxSUZTb0ZiWGRudXNpRjNUZ2hiQS9wYk5IbzY1NFhUZTh1WE1PSVIw?= =?utf-8?B?UlUzZHVHdlZsOFBBM0dBOU9TbTZZdmxrdDdFRlJNMzZXZkdZa1ZWblh3aUUx?= =?utf-8?B?Ry9kTnNsRDhhL3VITkRoKzdqQTkvb3VicHMxdW05bHIyMFlodHk0ZVlTTzBL?= =?utf-8?B?SE54V1krQW5yN0NPNzRjTS9qTmZadmVpVjRpL0lRc0xXOHhUSjBWNld2dFhu?= =?utf-8?B?SVF2RnJnYXI1clZ4eWJkbzdpdTRtc2FsWjltaTlwRW9zZmo1WGxMQXc5NTEy?= =?utf-8?B?R3dOVlA2M1djM0pQb2krQlRIcmxuSWJOUk5RU0FxNS85OTllY3plaHpsZSt1?= =?utf-8?B?L1gzaSs2UWxLVDlweDgxVjNQdmFOUEJLRVJMMkxqMFM4cVNVaHZRV3ZmVk9O?= =?utf-8?B?c1gzcEFnbzNPYzc4Sk1JdzIrVVJpblFkS3lFTCtXeDQ2eXpxVnRtbXNGU3BL?= =?utf-8?B?V1JEUFB6cFU4NVpiQ0JUbUVOOXFrOUtHLzhzM0orSjVrcG5abFJCUHVpaU1r?= =?utf-8?B?V25ILyt4aGR0bjVJVmVURjdpMXJxN2tSdXNiQnVUeU9PRVMycm56RmRrNC9i?= =?utf-8?B?SG0vWWt4MGZibWN0UXlmdkc5RXBCVWMwUlozV0NMM2UzNnNOSjNES3dXN0Yr?= =?utf-8?B?d2tRREl4aUJiVnZEZUM0b0dXNmM4Y01Fa21keHZZS2M3TVBaLzFmOUJ6dHlv?= =?utf-8?Q?WKlv+SLRuZlh4xmOXnonBV1C/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef6f451a-6ff2-44d8-ce2e-08dc434fc2fa X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 11:21:43.4231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vfadKRXnE5MwtPdj7Rd4Ddj13mRpkmxFNWKHuy+6V2PhBI72gmBlx51RRYlC0Bdk X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7371 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2024 2:29 PM, Brandes, Shai wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:24 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 07/33] net/ena: restructure the llq policy >> setting process >> >> CAUTION: This email originated from outside of the organization. Do not click >> links or open attachments unless you can confirm the sender and know the >> content is safe. >> >> >> >> On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: >>> From: Shai Brandes >>> >>> The driver will set the size of the LLQ header size according to the >>> recommendation from the device. >>> Replaced `enable_llq` and `large_llq_hdr` devargs with a new devarg >>> `llq_policy` that accepts the following values: >>> 0 - Disable LLQ. >>> Use with extreme caution as it leads to a huge performance >>> degradation on AWS instances from 6th generation onwards. >>> 1 - Accept device recommended LLQ policy (Default). >>> Device can recommend normal or large LLQ policy. >>> 2 - Enforce normal LLQ policy. >>> 3 - Enforce large LLQ policy. >>> Required for packets with header that exceed 96 bytes on >>> AWS instances prior to 5th generation. >>> >> >> We had similar discussion before, although dev_args is not part of the ABI, it >> is an user interface, and changes in the devargs will impact users directly. >> >> What would you think to either keep backward compatilibity in the devargs >> (like not remove old one but add new one), or do this change in >> 24.11 release? > [Brandes, Shai] understood. > The new devarg replaced the old ones and added option to enforce normal-llq mode which is critical for our release. > As you suggested, we will keep backward compatibility and add an additional devarg for enforcing normal-llq policy. > That way, we can easily replace it in future releases with a common devarg without the need to make major logic changes. > ack.