* [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name
@ 2018-04-13 15:55 Anatoly Burakov
2018-04-13 16:16 ` Tan, Jianfeng
0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2018-04-13 15:55 UTC (permalink / raw)
To: dev; +Cc: jianfeng.tan, anatoly.burakov
We are trying to notify sender that response from current process
should be ignored, but we didn't specify which request this response
was for. Fix by copying request name from the original message.
Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
Cc: anatoly.burakov@intel.com
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_proc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
index 2d3bda3..5c2acd4 100644
--- a/lib/librte_eal/common/eal_common_proc.c
+++ b/lib/librte_eal/common/eal_common_proc.c
@@ -323,6 +323,8 @@ process_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
*/
struct rte_mp_msg dummy;
memset(&dummy, 0, sizeof(dummy));
+ snprintf(dummy.name, sizeof(dummy.name),
+ "%s", msg->name);
mp_send(&dummy, s->sun_path, MP_IGN);
} else {
RTE_LOG(ERR, EAL, "Cannot find action: %s\n",
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name
2018-04-13 15:55 [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name Anatoly Burakov
@ 2018-04-13 16:16 ` Tan, Jianfeng
2018-04-16 23:28 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Tan, Jianfeng @ 2018-04-13 16:16 UTC (permalink / raw)
To: Anatoly Burakov, dev
On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
> We are trying to notify sender that response from current process
> should be ignored, but we didn't specify which request this response
> was for. Fix by copying request name from the original message.
>
> Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> lib/librte_eal/common/eal_common_proc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c
> index 2d3bda3..5c2acd4 100644
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> @@ -323,6 +323,8 @@ process_msg(struct mp_msg_internal *m, struct sockaddr_un *s)
> */
> struct rte_mp_msg dummy;
> memset(&dummy, 0, sizeof(dummy));
> + snprintf(dummy.name, sizeof(dummy.name),
> + "%s", msg->name);
> mp_send(&dummy, s->sun_path, MP_IGN);
> } else {
> RTE_LOG(ERR, EAL, "Cannot find action: %s\n",
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name
2018-04-13 16:16 ` Tan, Jianfeng
@ 2018-04-16 23:28 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-04-16 23:28 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, Tan, Jianfeng
13/04/2018 18:16, Tan, Jianfeng:
>
> On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
> > We are trying to notify sender that response from current process
> > should be ignored, but we didn't specify which request this response
> > was for. Fix by copying request name from the original message.
> >
> > Fixes: 579a4ccc345c ("eal: ignore IPC messages until init is complete")
> > Cc: anatoly.burakov@intel.com
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-16 23:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-13 15:55 [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name Anatoly Burakov
2018-04-13 16:16 ` Tan, Jianfeng
2018-04-16 23:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).