From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 195DEA0557; Sat, 22 Feb 2020 16:43:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB03D1DBD; Sat, 22 Feb 2020 16:43:18 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 17DBE3B5 for ; Sat, 22 Feb 2020 16:43:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D989B608; Sat, 22 Feb 2020 10:43:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 22 Feb 2020 10:43:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=KpixlHddbDJnJdGLQDLyDCoIuNqK1+StyLVnb6glEeU=; b=i8VZiIPh8Fp+ 41+PyaZoJ6JrWB3uj/DJUHaJKDnzyaVmgTQSk7FimxJtHeCaeT6Fp9h1mfwJHsGK j15JSVur4kGnelt/aCozU1vqDfM5RPg3QSR/Beyx9iPvfE+Cj0+wwaHH2SBYYfnl exXwUMXuHO3/mfxYoTq72L+tgJLcTIg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=KpixlHddbDJnJdGLQDLyDCoIuNqK1+StyLVnb6glE eU=; b=ztDyKTnrAq2hd3yDDUUEMFrp+VPB7/miDNTgSiwQlsPzzELkUbQURFqZC 3LGOx3sAgYCvcsLkHJjqZxj6xRUK7TIg0XLZa/7H7e3KKle4yHAbSBiSN7mn4tSl MerB/JDzznvQ6aS3yFeaYCO2jKNd2XCr8pM8eaW1dM8l4tY8fMRw+nf0zsQUm2Hp /2YxFF0OUs3ljYalCwxwRxOwquqBD5IMIr525SMI5WOvORLREuqrprbnczMdvarw QpviUfXQ6ZSwBhitmkJqhJaftbwZKYHIk2cOZHsMm0iHisw4xcahbARvH/p7OIku 82CnyHeOPueazBvnEZjYmOMclfsaA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkeeigdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepghhithdrtghinecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh honhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9BA95328005D; Sat, 22 Feb 2020 10:43:14 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Sat, 22 Feb 2020 16:43:13 +0100 Message-ID: <6486265.18pcnM708K@xps> In-Reply-To: <20200207175217.14974-1-stephen@networkplumber.org> References: <20200129155907.20556-1-stephen@networkplumber.org> <20200207175217.14974-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] devtools: add new SPDX license compliance checker X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/02/2020 18:52, Stephen Hemminger: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger > --- > devtools/spdx-check.sh | 24 ++++++++++++++++++++++++ For consistency with other scripts, it should be named check-spdx.sh Please add the new file in MAINTAINERS file in the section "Developers and Maintainers Tools". I think it should be mentioned also in the contributors guide. > --- /dev/null > +++ b/devtools/spdx-check.sh > @@ -0,0 +1,24 @@ > +#! /bin/sh > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright (c) 2019 Microsoft Corporation While talking about license, are you sure the (c) is required? > +# > +# Produce a list of files with incorrect license > +# information In order to add this script in a CI, it should return an error code. Based on the error code, the CI can report it as success, warning or failure to patchwork. > + > +echo "Files without SPDX License" > +echo "--------------------------" > + > +git grep -L SPDX-License-Identifier -- \ > + ':^.git*' ':^.ci/*' ':^.travis.yml' \ > + ':^README' ':^MAINTAINERS' ':^VERSION' ':^ABI_VERSION' \ > + ':^*/Kbuild' ':^*/README' \ > + ':^license/' ':^doc/' ':^config/' ':^buildtools/' \ > + ':^*.cocci' ':^*.abignore' \ > + ':^*.def' ':^*.map' ':^*.ini' ':^*.data' ':^*.cfg' ':^*.txt' This should be considered a critical error. > + > +echo > +echo "Files with additional license text" > +echo "----------------------------------" > + > +git grep -l Redistribution -- \ > + ':^license/' ':^/devtools/spdx-check.sh' This should be considered as a warning.