From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70E42A0093; Tue, 7 Dec 2021 14:41:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04B864114F; Tue, 7 Dec 2021 14:41:04 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id CE0A84114A; Tue, 7 Dec 2021 14:41:01 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10190"; a="237517093" X-IronPort-AV: E=Sophos;i="5.87,293,1631602800"; d="scan'208";a="237517093" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2021 05:41:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,293,1631602800"; d="scan'208";a="657709781" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 07 Dec 2021 05:41:00 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec 2021 05:40:59 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 7 Dec 2021 05:40:59 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 7 Dec 2021 05:40:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hTn9flR/KcOaqXDHK2eqZ1bMutNi7WyF07R6hftO8Qq1EpGTvJ3U6Le/+L/SXTLHgShcd844M6UG1QM4K9fqAtBBAR5MdKHKq72LffFpNd4R35nNZve93V/CHe1HYcYnTpVkrPZRk/r0Xkr4qfSTREQF5LvryhqcnVdSm3aRML5WOdkRjUKsYE7wnnj5Dj5zwNFBr7/9eLcfUtcJil1r2/S/MjG6l1MxUZivqja47kGJm19Cv5RneRgZueuHlCjiF6XCUmowIsZNxhW04BZXaKnE3P+uSaezmyEm4KRLOgSS7+Iq8rSxau6mTWfhw4J6VRD6TSAGdgsMS5fd0W828g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuCS2th7ZX/JRf4i5urRG2JOlTGARGusJhLobRJK1s4=; b=j8VpiMN5WiqJSTkElra2fSso06B+6BxFbG0hVySvYSVjtnGZ5Y5RwZsCPK5pzP/8JefSuYQW12Pw93lkgpc6FAPVrItKzvCqiEkZ4i3SHHANFpI6u9XLV1E6FJrgpXPBz4qV5tdTnGIfDz8bD3yPMO8EM0QCasB9cKCxbygldwpUaJpayQc1NjJSdxjjxWPNKrvBCfWPGmq2mG3priDYZwLIav/UmkmqIuVRIm/O7MS1aSr+1BgmEEkLqmJtiTyjp093hQFK7on53edNhHqs9/HTyPDF6+1LXfY9dbf0MtEhBbo6HEkJ2sWWJze1czE/Y3iHYm0bMDb/XuUI7if10w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuCS2th7ZX/JRf4i5urRG2JOlTGARGusJhLobRJK1s4=; b=hK5IOBen8yNcQTKgVgwd5kNwKXzttQvU6ELIk3BctXlxgRIS5a5oQF54AzsUCCeQEMAeeyfhv1dbABQw05XZCrZKAj7ISpbE/9nZ4y9ejKD3relqqUqVJKB1MPR9Z6xzrqysodUPDdso1nJjeBRP6g8uaaD2eu5C+ZPxA9a9I2s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB3558.namprd11.prod.outlook.com (2603:10b6:a03:b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Tue, 7 Dec 2021 13:40:53 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::d10a:71ec:458d:2dfd]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::d10a:71ec:458d:2dfd%8]) with mapi id 15.20.4755.021; Tue, 7 Dec 2021 13:40:53 +0000 Message-ID: <6493448f-e5a3-8834-3fea-cd1036aa097c@intel.com> Date: Tue, 7 Dec 2021 13:40:47 +0000 Content-Language: en-US To: , CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , References: <20211123183805.2905792-1-michaelba@nvidia.com> <20211123183805.2905792-4-michaelba@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs X-User: ferruhy In-Reply-To: <20211123183805.2905792-4-michaelba@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0273.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::21) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P265CA0273.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend Transport; Tue, 7 Dec 2021 13:40:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f3a7098-39ab-46f4-bce6-08d9b987303e X-MS-TrafficTypeDiagnostic: BYAPR11MB3558:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EY+gBWkiKV5UHqNVmYbXSdnGcuCd+P5jFI5wTadSolSfnlEhLFLj5KzoWp3T6nfeASmNTDfmCA9LY1MPHbuDvWsZZLaRrdNDIj2WkPPe61y2FM6ghlwBEH4XbVXzpWQPhxDBEqgpUyaVWSHgoEwewwMOIwO6CqE5VuL/tqfQ3fy/WljGIbIV6ej/8klSsC9ejpxiKhtH8RJIr3A1vN9XkrIi6byLC+RwiXT+DJmbxZ5mXY4pQ97JLEFLoVbo4DezKdIEVbqwEAe21TNt2PAdO4Ytf1KH5HvT2DOO2ZP3vVLRkzmUSLrgM0nJEntlq1ZTL141D37zlwbrbnlS5hgb4hbo14Xzd8kMJwBgghteMggLVv2F8p7SENVOdiLHCBhxWmmSNBqnQxf6mk8giHO77PNSsy8quJURf/sRoVXdPIXe7VviHp/FCvKDjoF3WzSMlQgnxBXFMm5GPl5zI2ltIA17GUOSfjrmL2PZzOvO0SZoDdhKf94R4vFJ0gd5oba9PX7pv6IBsJBEVsT2PvQveark6qKJplZ7iebX2e0Fbxv1/eml5V8r9192mvG2qGr/TJhrELvDAIAOPsgB8zV3ROTL9e69ZmDG7LWFCM1Cl/HE75LKDECAisYA8l3Ikyei2beG8/Fm4xZ2oK5OrxKTe7O9zamnld82UCWG1P+2ZWd7ObPJot718xun3le5VymVmxRAPFdY2UILXU9Z4bnlVg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(66556008)(66476007)(26005)(36756003)(53546011)(508600001)(44832011)(66946007)(6486002)(956004)(2616005)(6666004)(31686004)(186003)(4326008)(82960400001)(8936002)(2906002)(54906003)(5660300002)(83380400001)(86362001)(38100700002)(8676002)(16576012)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHJ0YkhaZHYrcW9xN0d2eUNhWVNaY3FSNC9leEg2b3ZCemRHV2RBK1JFUWhN?= =?utf-8?B?NWt5NzhaQ0hGOFRkNTgxRHNJY3pKK0N0VStVMGFXWGd3SFRQTEdtSVhVWWJj?= =?utf-8?B?RjhOMHBSRkxRbk8xTmtOSWwvRW1uQnFJRThpTWxmZXhrNjE4akZLd3dDREp6?= =?utf-8?B?aDhkdmptQWJtOGFadUs2RTdYWHl6dFJCQzhSUzkrNnFTeHNVaVBEZ25lM2Rs?= =?utf-8?B?QnR6WTR2SDdHc3Znb1BRNUhrRWxSRWp5L1BXdTNoV3FOWXNQUlU4d2NXTjYz?= =?utf-8?B?a3dqcitTd1MzTTRiZFNCOHN4eFYwMG9qSHVhTklhRzYwYWNBblgzeUp1bnln?= =?utf-8?B?TDF2L3lqcitRWm9uNXFxcHBaeHZEaldBS0dwL0xjWHJyVExRR05OV1R1SHBD?= =?utf-8?B?dUZCM0NwU1ZCWUROc05TUmw0dVNJc0NnUXRld1U4UzJmSTdsY05ydytkdDUv?= =?utf-8?B?aUJVSEhxRnBnOWlucnZKV2x6NDB4NFA4Y3NWUzU4SndOanNkUENOZVZwQmcw?= =?utf-8?B?MEZoVEVIN0dBamlIclluT01USjVFOTY3VXN6WnNGcUtqMGlINEpOK1k2OHVa?= =?utf-8?B?cTFrUWhsWFV0VGVXUmk0ZGNIYUZzMHdwZkpnbFQ2dVIvV3lvcEhvQnpqanFT?= =?utf-8?B?SHVHVFM5NnpNeG52NTY2R045VGZmbzFLNEh0MWRHWEpwMmlIUGoyMzB2V1ox?= =?utf-8?B?aDc1YnFlMlhZSENhQVVQdm9Tc2dRMjd0V1lMdEw4dE9KRjI5RnNHU3liR2hQ?= =?utf-8?B?Ky82aXF6UkhJY1cxT05aYlAyd2lJOU1DKzR0VmpoeGRVZ2VRVEdFSis4LzJj?= =?utf-8?B?dlJBTWZXaE80QWRwa3NaeVhtVE9mWDU3YTJyeTQwVFRyUG1oa1dob1kySitw?= =?utf-8?B?K21LYzRBdldjOVhwWWd6QUFOdXV1aG5EOXVoQ0hvOCtybzZVeHBCb0VoUHNT?= =?utf-8?B?NzQyRTF4OVV5SXVtVXN1OG00Q3NwdWJCUUxTcjk3NUsrV0NrS2xQa1REUmpm?= =?utf-8?B?alJLUGNTbTFYQUZYd3Q0a2U5MWlvT28wQzN4TnU5N2txamREbVRhVFA1R0pa?= =?utf-8?B?TWlScEY0aUFvSC8vWlFzd3NaTjIvQ09aMEZyR2YvRnhkODJMZFM0Vzd0UUtB?= =?utf-8?B?QlBRTXhXcVRBTTIvQnc4SVB5dWhkUklWV0RVQUJFRlFwbUxWQVdpMncyb2kr?= =?utf-8?B?dkVLM0FGSjBXOUV3L3d2ZC9xT01DZFdqSER4bUJHTGdYdmxiWCtObVlNdGl0?= =?utf-8?B?SHhTaUY1d0NUZloyb2xCSW5semQxSUNaYnNNNkl1ZXJ2blVFMG93aGttS1VJ?= =?utf-8?B?TGFtWFYvS0h1emNycFh6SUc3YXF5UnZQUUEzMVNMcVk3OTZvdlJFdmY3VTNs?= =?utf-8?B?dkwxWCtUZEhsaUZ5TVFYV08waDBCb0EvUm1rc2c3dzVCYlhTekdvaGQ1MWVt?= =?utf-8?B?MTljeGNHNTBpaUVXNEdJc29rK2dmRjU0NkxkMGxkMlk1ZUluUUpSMm0vVnlN?= =?utf-8?B?Y2h0RFJYV25GV3NCV2J5ZXc1YnlaMGUwRXR3T0VTdGZxZ29MR1RGQkd3a2VR?= =?utf-8?B?Z0V0dEloSHhJM2w4Yzd1VXpHVklIY0VFWFFUZ2NESTJ5MWhQV3I1L2ZrQjg1?= =?utf-8?B?bWdsQnB4ZWZoaUhyNG1xVlB4VlRxSUFrQ1MwUjdaM2ZkU01BMkhCbWxpaG1z?= =?utf-8?B?ZUx5V2V3bDM2dndUNVVoTEVRSzVjYzk0ZFlvR0pVWHFnbkUwVldCTXFwNFpp?= =?utf-8?B?RjdzUXdzRG9DSk5mOCs0TTRpNDkxSDVkZFI4WnVXZXQrWDhGaVNZSEJ5L2VW?= =?utf-8?B?b3JIcFVOVW45T3dWVEN5MmNXWGZvdmNqVUQ1M0lUTVFJaDMxaFJ4NllOL1dr?= =?utf-8?B?bWFCenpiTlBRMmdsTGZHS2NFWitqR0h6Lzc2andvQ1B3b0tXelJoUTVwWlc1?= =?utf-8?B?UkorRll4Q3UrSC80N1RvRE1oR2ZMZndkSFN0VjZqQ1VSR2dlWC9qNzRpSVVw?= =?utf-8?B?VEJsT09mZzd2a3lsdi9KUHVhbWFES1JTRGRuTWlPNFVyTmJWUHkwMDRwbGtC?= =?utf-8?B?b08xdWwyL2FWM2VVK3kzQmd6bS8rby94dG5jaE1uV3JvczUzb2sxNXh4dFBC?= =?utf-8?B?VmwxOUpFU3hpWTZleklzOTdPVitTS0xuSU13S3dpVUE0UmU5MklHR2xGeitv?= =?utf-8?Q?vsBwlpKBWArK1JMKIBBxiYE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3a7098-39ab-46f4-bce6-08d9b987303e X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 13:40:53.3694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5xzT4QMceS8DL1F9h0R3VDLd0pjfp9J06hUsaaw1rGkbB12/dcNVC6tVPfMVaIEwrhNwL8FAYgx810ceMU9q1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3558 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/23/2021 6:38 PM, michaelba@nvidia.com wrote: > From: Michael Baum > > In Multy-Packet RQ creation, the user can choose the number of strides Multi-Packet ? > and their size in bytes. The user updates it using specific devargs for > both of these parameters. > The above two parameters determine the size of the WQE which is actually > their product of multiplication. > > If the user selects values that are not in the supported range, the PMD > changes them to default values. However, apart from the range > limitations for each parameter individually there is also a minimum > value on their multiplication. When the user selects values that their > multiplication are lower than minimum value, no adjustment is made and > the creation of the WQE fails. > > This patch adds an adjustment in these cases as well. When the user > selects values whose multiplication is lower than the minimum, they are > replaced with the default values. > > Fixes: ecb160456aed ("net/mlx5: add device parameter for MPRQ stride size") > Cc:stable@dpdk.org > Again, not sure if we can backport this patch, this looks a behavior change more than a fix. Previously if the user provided values ends up being invalid, PMD seems returning error. With this patch, instead of returning error PMD prefers to use default values and doesn't return error. I am not sure if it is correct thing to ignore (adjust) user provided values, but that can be up to the PMD as long as the behavior is documented. But I think it is wrong to backport the behavior change. > Signed-off-by: Michael Baum > Acked-by: Matan Azrad > ---