From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB6D6A0562; Thu, 1 Apr 2021 15:36:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9752D141306; Thu, 1 Apr 2021 15:36:42 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 06852141304 for ; Thu, 1 Apr 2021 15:36:42 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A66B35C007A; Thu, 1 Apr 2021 09:36:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 01 Apr 2021 09:36:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= QH23r21JM25XVLg3WiM6uv8/jjEnbgpDqpuzGDNcSXA=; b=Xu55fO9Olzb9UbUh HrliZtEXYgQgZZr7/82mwuSo8DdCpYeZx/jHifcWD9AwLjasgxRMhK2aVih1QPdH wdFo57SIDNM9QlokeDJdT/dQkGbtzBMj9H+K9pZMEEuo2aeMTu7DQYLhlNG0rvvB NDHn0fllaL3kn0zNnSifcmcYPlqo+CTdvKXU6xnQhRCT9GW2NiCOCUa5jxIb5Ua5 gw/QAhCSVlPsYFFuy7VBpDcGLscRPyUQTWSkoaZOSZnulqzVuTdz2VxI9H/zf9Vo a4jUxTwpz5bPnsiS9lzpnAeE/5DyDqkHSshpPPGr8iO5B/0T5tcBFiQ3uzpulz1j fTU6mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=QH23r21JM25XVLg3WiM6uv8/jjEnbgpDqpuzGDNcS XA=; b=R26tALCyzqe6/+SjaZ4sLWWe5pUuk/eXB5NYCO+GWhjzkcpk0nDUrfe1k 289vQpwvvNGFpKPRVM25cyXo1PuI1ZHwMHN1jexSiFHkzws7YCHMwnSLYrBs8PnI YRoLAaXQWCPaI/crYrS3YDZAZiJob09aY5kMrpU+Kx9hCUc1TwI0lqfJmkVNckMS qyjH4c2GOa3cTgKUf88L/KLbLWLNBS2sJY1dii3gZxr/u+mzhTBL65U1xH5djNCK JG0cuna77kuvBneLxwZaNfwN23bUJYUNhZ06K0KjfvR4YYtVvNk9OLbz23v+4rl0 TIUPahlf+0VR92GBejGGiwSURsxpw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeigedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7C68324005A; Thu, 1 Apr 2021 09:36:40 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, bluca@debian.org Date: Thu, 01 Apr 2021 15:36:39 +0200 Message-ID: <6494687.Qfmhli7XZA@thomas> In-Reply-To: <20210401115009.1063844-1-bruce.richardson@intel.com> References: <20210401115009.1063844-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/04/2021 13:49, Bruce Richardson: > This RFC contains 5 changes/updates to the DPDK build and build files. These > updates all assume that the minimum version for DPDK has increased to at least > meson 0.49 as proposed in [1]. > > The changes in this set are: > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels > in the foreach loops when building library or driver components. > 2. For libraries, drop support for header-only libraries, which was added just > for the "compat" lib which had a single header, and is now part of EAL. This > similarly reduces indentation levels and makes the code easier to follow > 3. Since the larger blocks of meson code in our repo is seeing massive > whitespace changes, take the opportunity to switch our indentation style for > meson files from that of C-files using tabs, to Meson/Python style using > spaces. [More below on this for discussion] > 4. Remove the "librte_" prefix from all our library directories. While as useful > cleanup, the main driver for this was that it simplifies the matching for #5 > below. > 5. Add a "disable_libs" build option to allow the user to optionally not build > certain components. Include in this an explicit list of libraries which are > "known safe" to disable in the build. For now this is a short list of three > libs, all of which are safe because they are not buildable on FreeBSD. More > work is needed to expand this list in future. > > Of these changes, I expect #3 to be most controversial. Did you choose April 1st on purpose?