From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4B2E4369E; Thu, 7 Dec 2023 18:42:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9709542F04; Thu, 7 Dec 2023 18:42:14 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2046.outbound.protection.outlook.com [40.107.92.46]) by mails.dpdk.org (Postfix) with ESMTP id 120B042ECC for ; Thu, 7 Dec 2023 18:42:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsSTarMHRRwiwrRfxX36lQLKeT3iiViFdNrgfsxkFxEKs4bfZTEiSFg7JN3hlDgu3DpQ4g/uGrp6BVpoHLZQYIRpok5p5U9y2cE9JyFCd+RYPxvwA3jwjTTbOIuboZccw+fWp+oZHXlKIwJK1oWKfnKbpy8sOary/ebVutpbwpcxzWcoR/d1NZh1LFY6PZMX1BQ3/N4pvO8S1/+5pR7A1MtJAKugs0NKO6FYzEHouqT+lhIL0lFupDX4eRBEBn+K/3F3X304YpB4/EWe77m3SaFD1W/wpJHk7kFjtMCUp0gALHHKz4U7K1J3B7KFTbqHG2EYdLo9y+ZIPoZrXT4owQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yYSuLHBuEYPm+PjGaVjiT/fWs9bH5iTNbWAANhJAq4s=; b=YC1egPKXlABEpCr6PaIz4Iwtb08b5QXZIPfnJzhw3RjjTcI9kagJeEDF3JxwvDijxSaB18naU+XHqoiPvKQEwM54F7QFCxbPPcTWc7/Iv0O7KX7fPlBgnBHQc8KUFVWUq5Fm0+6kZIOzs9l9nRfoGRyg1SPtJRwJ7ynD9V3GRFmDqM6T1ktRZq+iXI0wvqsNRqsGtucZ2W073ddVGzCEEU8La2bot2CggCp62c0sTYA4uKcIWqsqesjBvGR+Eld5trsXnktsKPjTk0vkWJz/R+2FzIyocoHMXCxxQERrgMUXyBQ4Z/x/p5ug8DnqFrgArYKebvJt+GBEZlzN1gcugQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYSuLHBuEYPm+PjGaVjiT/fWs9bH5iTNbWAANhJAq4s=; b=v7A+hMZ0bi5gETJT67XnBjUe5faxveMQgN3+/bqJEczqPMFVKAANWJsjYsTVi3CN2QLhtpUpQmypFY2M1sUSzOaXY+x/vmcbQG6vPh/5O90T9VEbGbwysM1yCeAILKHt1tSrjZV8sKzd05pHn8poBZX75pRY+k6vjnoTn+5K89s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8129.namprd12.prod.outlook.com (2603:10b6:806:323::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Thu, 7 Dec 2023 17:42:10 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7068.025; Thu, 7 Dec 2023 17:42:10 +0000 Message-ID: <649e3352-fbb7-4ff9-b03d-52ef39abbc37@amd.com> Date: Thu, 7 Dec 2023 17:42:05 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] net/hns3: use stdatomic API Content-Language: en-US From: Ferruh Yigit To: Jie Hai , dev@dpdk.org, Yisen Zhuang Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20231111015915.2776769-1-haijie1@huawei.com> <20231207014205.4002558-1-haijie1@huawei.com> <20231207014205.4002558-5-haijie1@huawei.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0048.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8129:EE_ X-MS-Office365-Filtering-Correlation-Id: f036a1e3-2785-473a-5621-08dbf74bd6b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xhWK8TJs9LDBwLj+AVE9C/aNx3rLRUq23OuOKUEE9QqjP2PXLDfJY18RukkEY2i6/KlJMsHb+q9JR4Uz0Nq9I01vsyaDPbMaiPVrbZbER3SF7VJzCy5RgC8r67LIHdg7E3QCxQwqbp0IrlXZmJdD3rpN6uja93yT87xq/ek+ndZsHJqCdPNtUIuQv47xVErbU8Vd5mUsWERSdm0Gkt+IG/WzrPbOt8S3ixxgKz1kN/Ty6XzdkwxxZ2yJzPir5/LkSzw5ThR5h56rfNNh1ip83fPGFg92qJL1+nmzGXF+lREO3HPU+K3ry9kX2TFJtVI3ZSmlZEfyN1SwfqL20LaocFf23eKOM+LBE1IRWo+rimRTTih7u+pxJUW7lDsgMlGHmopArJj4YbVG/8teIQaA1DoMDnYiOJ4kIREd5r6ZM4f42mKOe5CHzJ7qc0Ule/XGG2k8KG7fTQY15Ru3wmxHaMfX42mjDNl4Tm7Cj22C2RJ16Vc0ir6ipZLw/HlJWXFUW9v6BRHdRH2LcvcNLaHM0c0MGHj3atPcwQj8ppIkuNSpiSMWenmH6dzQnRCn3wPKH7o/s5vfPFnCl15639COj1FgAXPUzMES4EvPar6p9HDi79jsNp6Tk9PHqkfv/nW0t7b0gqAKV9PIKh1Am4aZvIIkoSmCp4S1dMhtbJZUQ7w= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(39860400002)(346002)(366004)(376002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(4744005)(5660300002)(2906002)(41300700001)(38100700002)(31696002)(86362001)(66476007)(66556008)(66946007)(110136005)(478600001)(26005)(2616005)(53546011)(6506007)(6512007)(6666004)(966005)(83380400001)(44832011)(8936002)(6486002)(316002)(8676002)(4326008)(36756003)(31686004)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1I5dU0rUFgxbllvZnU5UlZCRjdnaXhQbkFBV00vZDBnZTdWQVlWeEtMVHRQ?= =?utf-8?B?cDQvZGxUYTdXRWc5bk16NTdUNGFKcEd2WlIzbk96YThlT2NGNGp6bmhCamVj?= =?utf-8?B?TTdSbncvUDlEbVBheFc5L3ZYbml5cWRjRDc4S20xdWRqd2xwY281eUptYVRT?= =?utf-8?B?RmdINTk2Zm9XUk9FdDhNV0VkcnBCSi8zcnBIa2lwTVp5aG9qdUJtWW1mc2hS?= =?utf-8?B?bGF0Vi9YZ1FpRG1ZK2t0Q3JrdjRPRUV6QzZVL2IxSnZWLzJhbkk5cHZwT0dy?= =?utf-8?B?RTlVclJQWHFZN1V5RFV6MjhGV1lGSzU3eW10VTg1ZU1CWXd5Zmw2bGZOZm1H?= =?utf-8?B?bXFQT0dtalV4bkdTUkZROStZZ0dIdkd6TVM0YzlPWm9ZYzc2UFRDUEQ4RGVJ?= =?utf-8?B?dlFRNXdVcllVUlBJelc0WTVmTVJ5dkNUS3BseUNYeXhkZFQ3d1VSMzZyRkt4?= =?utf-8?B?RGRra0NDejZ4aHBISzJmUjF6RUlhMUx4Vmx4UUE3bGUyRHg2Y2pYTUZQeEVk?= =?utf-8?B?MmZHNkJ0S0xuSnVCL3FTVDBkUzFIaDJCVDgraVhOS1g0dXB0b3BhbHNCTG4r?= =?utf-8?B?b0VZdW1RaXFjdlo3UTdlVnlQZXlQY2tzOWNQcUxZRlpycGdBYWovYmRCRXpi?= =?utf-8?B?MG1JWko0UzBEd0RpRGszK2xDVk9HVDhiYjBDY21NL0xQeFV5ZmE3ekE5bVly?= =?utf-8?B?UUtBckZxazlZQjF5QTZpajhYVXRJWG5BYlQ0T0YyS0VvdFVGUVFzT0Y4Mmww?= =?utf-8?B?dER5aGZ4K0t4dW1wbWJBOFlYa21ISlNrZjhsSVIvVW44S0xmMHBMcDVCT09q?= =?utf-8?B?OXVkT3N1U09hR2JaY0tGSlZnWnFRZStkOG4xYVN6dkdncTNqV2NmeTc1N21F?= =?utf-8?B?MHByRTlTd3JwTzVSbk1nNzlEU1lmSVN5L3pkSlRUZHVVMSsrY3hkRnFqT1BQ?= =?utf-8?B?d2pWUURBYXZIR2w3MEllcmJFMWJmWnBJQmVlVXl3MUZIaUhnQTVHWVI1TVV5?= =?utf-8?B?SFdPVGt2MHpjQ1BBY3MzTk1hSlRTdE5PalBQaUlXelhwZGhKeGpJSUZqc3BD?= =?utf-8?B?Z0ZGaHVuKzhIazVWZDhDSEJMaW9PWXluUFNhRmpaUHU0ZDlLNi9BNkd0d2w0?= =?utf-8?B?YzZNY3l1Y2tRREJYdjVZVWFjcEVvcnFzNjZqVEc0SXdjQUpqREF0cGh5NWNy?= =?utf-8?B?Z1lSWGRsMTFpdXA2MFo5VHoxelNFalllQWVIMXFjNVU3R2liVmsyemZ0amU0?= =?utf-8?B?NFFrVkZXcit3czQxOU44bEwyQXlvVmgzek5POGtKWUhrY0F5bzZ1ZkhtN2Vk?= =?utf-8?B?cXZ4eWc5cGhEa2E0QUZsWGYwWnBtM1phYis1QmVHREQ0bHpsSFFJM2dnL2dv?= =?utf-8?B?US80Y09rQktIYXFXRmtjSzIrNi9oSmJ6Z01sc2FxRVRjeHRzbHRJa2FZeVEr?= =?utf-8?B?aUFuUTYrZVJhT0tVWktuTnRiaHRDSGdnLzN3V2NWUFdqQ011M2d2alZ6cEdl?= =?utf-8?B?NE9LRGpYOXhrZUVSU3pRUlhoMzhLOXI5UXFrSlBPeFozWWVwNjM5SFlDMWtH?= =?utf-8?B?QWNZYUhkeHdhVjZQUzFSRE9oWUdEZGx2NCtVWDlNQ2duNmtSOXJYN1RhbUVJ?= =?utf-8?B?clRYMVVIb09Sam1vYkFvMjNYVE1XdEVJYTQ1YkxpNzAxY2xIbkJuVzZMcDln?= =?utf-8?B?QVlJeEJOcVBpSjFJRFFocGE0TFhjV1JkMHUrZURZdFl2bUVtMUlwV3B0Zi9v?= =?utf-8?B?Y3FmU0pTRmJ5M2Z3MkFsL2QvMVhlQnpaRVpDWVdTQ2NRVlBOQVZGRkRGVU56?= =?utf-8?B?ZzZxR1BLZm9pTHQzNHozc3B2akdUdnpEOVBnenplZm5YY01uRkFCY0RoNjc4?= =?utf-8?B?bHFqdUlBWHZPY2pETmo0ZU80RVYrU05YQ25JMWZ0MmxkZjdYSGNSN3FTL1hi?= =?utf-8?B?VkkxeS9Pd1I2Ky9jVnBTZnVOd3l3Uk9Nc2x5TE16TlZBWUVQbi9YZmhaRGRB?= =?utf-8?B?ZlA2S3J1SGlDa25kdk53bG1LR1FUOG8zOTlsbDE4YTJYdGxTbDJuLzRudlVR?= =?utf-8?B?WndnR0xNczQxa092K3NnZTVpemVqWjArTjZFNWc3Z3lMcldWM2k0d0xZZzAw?= =?utf-8?Q?jCatraAK1FcZOt6GOSV5vTzw7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f036a1e3-2785-473a-5621-08dbf74bd6b9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 17:42:10.3732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JGa3DDEqavZEVe/6dWXTSvEcpwxfK/XPLCofc9/kG1+q1/yx1UPS8MSnLXmdvTMW X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8129 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/7/2023 1:57 PM, Ferruh Yigit wrote: > On 12/7/2023 1:42 AM, Jie Hai wrote: >> Replace the use of gcc builtin __atomic_xxx intrinsics with >> corresponding rte_atomic_xxx optional stdatomic API. >> >> Signed-off-by: Jie Hai >> > > <...> > >> static void >> @@ -643,8 +643,8 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw) >> uint16_t exp = HNS3_PF_PUSH_LSC_CAP_UNKNOWN; >> struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw); >> >> - __atomic_store_n(&vf->pf_push_lsc_cap, HNS3_PF_PUSH_LSC_CAP_UNKNOWN, >> - __ATOMIC_RELEASE); >> + rte_atomic_load_explicit(&vf->pf_push_lsc_cap, >> + HNS3_PF_PUSH_LSC_CAP_UNKNOWN, rte_memory_order_release); >> > > I guess intension here is to use 'rte_atomic_store_explicit()', current > code cause a build error [1]. > > [1] > https://mails.dpdk.org/archives/test-report/2023-December/525759.html > > Another build error is when stdatomic enabled [2]. [2] meson setup --werror -Denable_stdatomic=true build && ninja -C build