From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F7B341D9F; Tue, 28 Feb 2023 19:35:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8085940EE6; Tue, 28 Feb 2023 19:35:40 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2083.outbound.protection.outlook.com [40.107.244.83]) by mails.dpdk.org (Postfix) with ESMTP id AC4B04021F for ; Tue, 28 Feb 2023 19:35:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wn2vcwRlHkYtU9WirQUosCQBNLLTNZ+KAvcWfOmTaav6gbcFqavKqJwLA/eiamEMox0f20W0xMXdH1sM6t2bdGftUVrLdlKZmSYgZWRY58qhOz735siGQBDaJOsJDin0HmuBkN8BAuYAV6t7P3+DUpPHS9qI5eRVLXswKbkQnoutuu276qHaoAkYKCnfvh+X8XK0AmlGbetgWXIcjVB7HyhRm1Tg3a5tg1jQWBtMoIz3g7vI8FaF2nuumRTTirOnfmZrCQWP+db4sJwnackoM12KVwYX5I5x3GkRtr3wDuvA455T1tuWBu/8U01nZRl47J6Dg0cFXybrsZzAsZbJhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ReBKNRd8lupad26lfxXX4fs6EniW91hrvV3lipocisk=; b=OSgL9q6goG5VlHyy6rFcq54AAUzhsmjrqFU8d4JfzaSEf8TcwwayqmygU+rzUwGyTzPN+fDVJwJx7gUPhJ9JN/EJ+Dhg2vfTkymCR5zA2WxRiJ/arwjB6cfiYvfVMhS4WX4UKfhHS/mWr18AfRjOzz0rg+NIzO0UzOP1PMFhjZ/i1rLO6zbGv7XsxDAbH1UQ9lRdjrArrSlCtiGiJOiV2lXsk9uDAhL+cl/LrvKpmhjyDyOT7q08Jhbeoa5oPeSS02AvtEwQjqpQ3IifpZTC5Jqmyw2nSj0utRyFbJUSqoYnNvIM4dXmoIzK7oRKFuHEdcZ1o1PgJICBryg1l7Yayg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ReBKNRd8lupad26lfxXX4fs6EniW91hrvV3lipocisk=; b=UNv2jxQMqhlo+LSWxoLPcrRuSzHZK3M2DlmX3O1vCGvkzb1eU7AQm2oLqJJIlXis+LbMJ8dJpmUC8a84G3pil891Xabu4AG4bAi4VjewqkD6XiqgDlcFhH54TVFxg6Woo8gB85VonlPBakIw7zo2GHr339HKMQ4XJ0tDfNyf5cg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH7PR12MB8039.namprd12.prod.outlook.com (2603:10b6:510:26a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 18:35:35 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7%9]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 18:35:35 +0000 Message-ID: <64a24b89-1afa-ff1d-11e9-239eabc936ba@amd.com> Date: Tue, 28 Feb 2023 18:35:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 9/9] app/testpmd: factorize fwd engine Tx Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Robin Jarry References: <20230124104742.1265439-1-david.marchand@redhat.com> <20230220183502.3348368-1-david.marchand@redhat.com> <20230220183502.3348368-10-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20230220183502.3348368-10-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0124.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::16) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH7PR12MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: e035d127-6811-4f78-5b2d-08db19ba9436 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QogOddS4QbPn5wkLUz6JYi0bSiEmyaJ6bk+WH0LAYYBDyUgtbFrTTk/1ay93G01xWuwhqdQ/T5yMHTC4RZWD9Kqv9VKqaNOdyug6fpaXP1MNzhQ/ymYQcR9Ug/CBznvvERP30NG8Cqxmis1I4VlPaFcnNF69f8aE1E7YEfHUe4pxMu3TsTwzSwqDEfcaQ3wzX3cVaqN2mLP1jA/4m6F2x7JA/X3so+qbllPFCQeKtLOyovbRWt9s2FCaCcWm/B8Hr137/71yaFZ8EVrOFw2PM3W03EFCdlzZZnMPJ17olDCq/5VOLJC/cRliN0CHwD+lbhsfeA1jNM5hq65HuSdqXYA9KdCS0cWhzv9AgxqeUHm1fraSSiJLvFkXshnfv7totSwvCxGBuFcuQYx8KuitJKfa3e6tLqDXEoVtXat3iYN0Y75R8ZYnb9f0NRpnCtgZp+5Hvf2vSCWeJv1q//jFvvBpwppFgZoFAkApJEkUkZ1Z4kUK9Ey/dAwou6dWI/7dBvwbr2qp+zSgDbNz8WGXOX/JMUK6xuk/twC7PQDBdX4tH7ygTKI/5ieW7whwQj3gOVflARYQXkfmCxkMfavEV3ZEqwDlsyybs3QdwXCxJITmJGD2TgzltfT+dlbYvwVrxRoHta+OYe5pddTbXz1piqT/NtcCP7EPfmtB5ZpPzHT8DciW4I1qzdsjHAQ7egtTE4aemToZbEhTJkRD3HL6g2RSxrQ9KN9um/el79TMRBM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(366004)(376002)(396003)(39860400002)(136003)(451199018)(38100700002)(86362001)(31696002)(36756003)(2906002)(44832011)(4744005)(8676002)(5660300002)(66946007)(66556008)(66476007)(41300700001)(8936002)(4326008)(6512007)(2616005)(53546011)(26005)(186003)(6506007)(478600001)(316002)(54906003)(6666004)(6486002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHozbUt6cmw3ZTNQSktObE9hQXJHek0rZWhXbnNIU1dDSEFUbXBJUkNjVXR0?= =?utf-8?B?aUlDQW5YTjEwZkkwM1NPMUdxVkJ0eWU5d0Q3N1B2MVlwQjlORVJQRDBaZSsz?= =?utf-8?B?YTJMRUVoMnhiYUJtcEpDdS9yQUpIMXBsYTFNQk5CSUEzNE1RNGZvK0tCZ2k0?= =?utf-8?B?bi9vcm9GbE1DZnpJZE4vRkF6TXBxQmkzVzdGYWFzTTQrS0p4UksvQ0NJVHdw?= =?utf-8?B?NUxmdEYyb21pLy9aSzRsemNUVkowcmZTU0h1YXJhSW9GMXRMS3NvNnIrdHpP?= =?utf-8?B?WDNQWTM5b2NpazdQKzVYSllGK2g1RjQ3bndrTXdWKzhkd1pWWDZXbWExakpo?= =?utf-8?B?NUhJOTZLLzlCVFVQMFRtVzJmeVZ4REJHVnR3M2t6NWJhOThKdFkrUk5waUxI?= =?utf-8?B?T05JYkFmaGhaNGpORHJ6VFdSMXoyRGhJbEpQcFNwOWJ5eEttRmJoUHRlbWE1?= =?utf-8?B?TndoWEdGeU85M1ZZUHJoalczbmtVWVdvM0M2QXhzTEI0OXpHZ24wSUhJSjBx?= =?utf-8?B?ZlE4NHpCVFA0d1dpTzZ6eldpbmVheWZ4Y1YrVXRReEdrN1JwTkVnRUZFSm11?= =?utf-8?B?eTVpTGNPdDQyTFdxdlR4emtleFRnSHdVbU9qTDJLWFUwRU91N1JwZUM4cHN6?= =?utf-8?B?Tmp6VDhlQzVwcXlkencvVnMyczN6dE9BalB3Q1pydU56L285Tk9HWmdnY29J?= =?utf-8?B?MGNHSmNZeG5ONGZOaEd5UGdsb1RSblcyelVOdHNPSUwvK29vbVZQWUF6cGla?= =?utf-8?B?Z1FBN2RkY0NqbHVwdnN4R245NzE1UFFOQTBBelErZ1RqNlMrdGEwOWlpelN0?= =?utf-8?B?S29BOS9MRE0zR2dpZHN5Mmh3WmdDejZ4Mko3cUNJR3dSRm9TbVNmaWlNU0Ur?= =?utf-8?B?dmtEMWVaZFdOWDFKN1UwanZJTXlSRm1VYmQ1SjhuQ29TUVM2K21yTnJ1NzNk?= =?utf-8?B?ZTVzVVZHTnl3b3JzRU1XV0JXK0RCa2ZFNjJ0NzBhVEdUMkkybVRxaW5QcW00?= =?utf-8?B?RG9WbTlVK2VXa2VsK0F2TVViTnNFaW84VlQzSTJuSXhyZWhHR3lKdUFLbWV3?= =?utf-8?B?enE0RXNTRE0zakthRmMrU28yTlZVb2ZpK1F0K0hldjFTNnU3VFVZMURVTzlW?= =?utf-8?B?N1pNRFI5bGx5QWk4U0xpVEo1Q21qV3ZjSXdmTGFZQ0xuaVFaNDFxekpNcU5P?= =?utf-8?B?ZERjMHZMcGJ1S1B4RkpVWWpvMEF6eHZKRmxaeklqajg3aTRIazEvbG5XL1ln?= =?utf-8?B?NnVSY1pkMG9SRldEdEtIMjdwL1QxNW9KV1lLbm00Q2orVG1RT3FmTUFGS0xs?= =?utf-8?B?d2F4S1VrN29LcGdKTkE3K1N5RnV4MytPbzJ1VEltNm9HTkdtZ1A2OUU5N08w?= =?utf-8?B?Nnlacmdxai9yMVZjUVdjNWpZN2dsUmhPTERHMGlwb2wreHBpT0c1WWtTVVRy?= =?utf-8?B?YlJGRWorSXhZaktOMGpvRG1Hc2xjT0VCOEFISmEyY0dTV2JVNG51QjZ0L2VU?= =?utf-8?B?SW1UMkFCY3FvbDN5Y0R6VDdTeWttZlRRenRJdzJpOUpMYU1yTDh5c1dtb0pZ?= =?utf-8?B?blBkMzEzdEVOL0RaVVplSm1CbWkzTUhEbmlDT09naWF0ZjJCdnVRQlhVVm03?= =?utf-8?B?U3pmTzdJQ2JXZnVzWmpMWHR1VHd4VTlnTTZEU21XTU5ZRmxLZVh1ZXhQR3RF?= =?utf-8?B?YjFXeGVjdEUxelhIazNYV0dxSW9uZ05rS2NoZTlQcjJnR1Y2Z21XbFYyd3JE?= =?utf-8?B?R1ErMzc2c0V4K1JSU3ljMFlKTS9VN2NkTllWdE1XdXZLckgyNzJKaVNBK1BI?= =?utf-8?B?dFlodlN2K3E2bWJSRkNUcUUzblArblE5dUIwNExiUHVlWDBNVHJLU00vQVpn?= =?utf-8?B?OGgxU3JoUjl6Wi94dXhyYjM0TzJhWU12bU5LYkliMXpuVlRyMjg4NHViTHlt?= =?utf-8?B?SkNPU21OL0NNRDByajdZWmVRbGhhYVllY0ZYVk9TQ2ZZZ0JxRU1NVVh3aGhy?= =?utf-8?B?MVlqL1RpUkZhckVhc1FlNkthNUJyeUtWamwySWY3WXFLWjd2ZVZRMVFpa2FC?= =?utf-8?B?eW4yVlpiUXYrOVpBQ1RLQm9kc1VBTFVIbzJxRXMrZmdpdjdCUUNlVVgvYkR1?= =?utf-8?Q?xkPZjZ/lPZJ8aE2OzqodDzqZK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e035d127-6811-4f78-5b2d-08db19ba9436 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 18:35:34.7694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 36/lL7WVF48jHWySbTaVqoJsh61Dh1RXKCE/CQhYFOj6sUC4497Wj3Qv04AhU6DS X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8039 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/20/2023 6:35 PM, David Marchand wrote: > Reduce code duplication by introducing a helper that takes care of > transmitting, retrying if enabled and incrementing tx counter. > inc_tx_burst_stats() is then unneeded and removed. > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit