From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1434DA0C4D; Fri, 20 Aug 2021 14:47:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 822D34013F; Fri, 20 Aug 2021 14:47:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id BCF5D4003E; Fri, 20 Aug 2021 14:47:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10081"; a="302355586" X-IronPort-AV: E=Sophos;i="5.84,337,1620716400"; d="scan'208";a="302355586" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2021 05:47:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,337,1620716400"; d="scan'208";a="506463270" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 20 Aug 2021 05:47:04 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 20 Aug 2021 05:47:04 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 20 Aug 2021 05:47:03 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 20 Aug 2021 05:47:03 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 20 Aug 2021 05:47:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/l39U/Dpj4Xpsl3/v9YjTcKMIN+dYWMV0NOGsenaDO86vYXBsXVeEhGyRZ+I7JNfsnRe/+yWPIeasBW3H5NuatOqZx460sNQwRJKJBN+VAhrsGKMC8vnFijb4rI28ePe0Kx2JOLAK0xF9BM+H5dG1TkNft+UC/zg/O9a8NMYN+DCFsYr3Fo4i9/uryW6YXZqo919AVksey8ObAhBt29/FL5W3cIgp2MabQ4hyrYtfsYeeEZzxr+zHg68dUdUHDhW1x7dfVzCW7grcNkwawIvwdhk1Z9biotYA2CfhrtQ5asNpKfDqpSTAlSQB/v65CM7pFRLvMqGjCtAnzsTNLyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ubxG7zEdgiKpMrjJUxen+H0ZrRoKloX7/aZZML+Ljsg=; b=id+lG2aog9X2RRWn/oNX8zB0N38277vpHmO9Z0HXPS7nJxWOsJ203yk6nnl0gWxznvAVdTaYPHE8Vv2wV5fpFIDNWRclPVIlPQEvNtmt7TUGXTEyD3KsZZ8nDY8XRpvIbmoa+F7mBHjFNUKi5IwlNmlILPenYeOTM6kRQpCjztlFQvD/lyCJMTUU27zOBo0JRm/zeK2fzN5CrlyDAhiouB2pzsoewziiiRzbE6kpbDhhkNbbQ/mSzahwt2OOKO4ky3VDpsRv4+Yc2D+6Q16/KBVcrcE/xM8JDSCZJMxyP1nVoUnDAke42GetzCnCULqvYnEZ7O+PhR8YLya8CgKOnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ubxG7zEdgiKpMrjJUxen+H0ZrRoKloX7/aZZML+Ljsg=; b=mJcf+uUv441+UKrlnBDOEe+PU3nDQxVWG8Y8VScgTpYMt9zkOpbosTbQDKTgjjhY5VPmiMGqHrW/HOZg/SNREDkyzZGJY93ZB8xhBZnikWJA5SjDQf0e/Aqg15MmgU4C6zGv+6pmBHWngO2XZUk+oFzuIm+abPnMy5AWINTFiH0= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.21; Fri, 20 Aug 2021 12:47:02 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%6]) with mapi id 15.20.4436.019; Fri, 20 Aug 2021 12:47:02 +0000 To: Somnath Kotur , CC: , Kalesh AP , "Ajit Khaparde" References: <20210810060731.30127-1-somnath.kotur@broadcom.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <64bb2ddc-f160-ee25-51c4-917141898b0c@intel.com> Date: Fri, 20 Aug 2021 13:46:57 +0100 In-Reply-To: <20210810060731.30127-1-somnath.kotur@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0079.eurprd03.prod.outlook.com (2603:10a6:6:30::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0079.eurprd03.prod.outlook.com (2603:10a6:6:30::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Fri, 20 Aug 2021 12:47:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef6662d8-054e-4dd2-6651-08d963d89b5f X-MS-TrafficTypeDiagnostic: PH0PR11MB5047: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9yI7qxP8wPxev99gIOj1rAp2iCMC/b93ShZ1ogO1sp5Dw5BJGzvrpiSDFmMDCzgsuW+yiL7CnMgPz0eJdF0aIiPGqzU3bJTaJKcIBbSwYtpqhjqK95o+G5YDr7aUb+IrLFW1CZwuPDMIkGAra7cVTtqwIBmkAEstqOOGp0r5HnJ1p3owE4XH8H37li1y2ATt4iJ53PiDgwXVV90Pzt7pJ6jPYPVWgOy2KarBe62Ehz+GIZVMZpAYipV9QWbMU/AZ6uMgFG+ZyRgtcbgOsNyFaSZQ8DHwKd/mDrY7sE4Egd85QaGifT4gKub+09lPGVQn0iI18M9D4VDbA6ZCwoDT00LFoVALq4v1oT5G0X1ieXSk8v/AuFOi1B1mlPYlMNt3bXcYdGdWWH0E5RYzhqEXgj5zz1oJrKATY/ol77QqJZK6XdBuuYYmA00hqTLPMucmMVB5jrrcrMVdbuStewlleeyaLOQHj5V50h9JYBc1nvD2xm90m/wFjVLraeht4mbH0fSgGO7tN67PMc/PGteSMNDJeeNLpmSJIcYvcbDgIiIy1dTuk7+HrZU3j2/zvLLLITHJlpch/a+BxWpvsakV5K8VrpKuU0ClgKQvHt4h9kMLB3EoysOBZYSV9VbTbapwxeP37RW35X3JGI7LuFBacCqGdQJffmBRVfPefz+58M5g7yFJ1TaSiyNGbMN5Fn8nfHBU5xTdk0lJqj0W87X1tQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(39860400002)(376002)(366004)(6486002)(66946007)(478600001)(66556008)(66476007)(316002)(36756003)(16576012)(54906003)(31686004)(38100700002)(4326008)(44832011)(5660300002)(6666004)(8676002)(83380400001)(8936002)(26005)(53546011)(31696002)(186003)(2906002)(956004)(86362001)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eS9iU0VRdjh5bWJGRlZ6NXVvUTd0ek1FYkdRZm5qRTNvSm5EQk4yZG02VVdj?= =?utf-8?B?cmYrVzVRbW82eGVzV0pDQlVVWHBGYVZTWitkdVEzWHJTS2Ztc2RHVlNzRzhW?= =?utf-8?B?cFJlM3dGOUhpZ0k0R2luSVRUUkFsT2Vqa0dxbHR4RkNXZC96Rmpxc0VtZEc2?= =?utf-8?B?Tk81ME4rS2p2djJNbnhESzhLbjlhYTF5emI1Mm1KdVpLazcwN2RNbUZ2cVVP?= =?utf-8?B?eUxJQUJSWEtWS0xNeG84aDY2SzkyQjl6QXA3dXV3MHBDSzFxdDR0ZmZnQmNQ?= =?utf-8?B?Qk5pbDRmcFdjTSsrSHZYazM4V1BlLytWMFJqUitZbjJrZUl0dGxxVXc1ZWxQ?= =?utf-8?B?T0ZId2dzNzhtQ0RlcXNqc0pGTVoxMmhDZDl2eUpRVkpjSERoNGxScFZJQmVM?= =?utf-8?B?MzkrcUxkbWJJTVowMGtEN3hUVXFvclZScWs0cnJ2bmNCY0FjcFRLdUE4b2FJ?= =?utf-8?B?ZDZ3MDZmNjRtVmZzb1FDcjVHTTl3SWZaK3VPZVJFa2xkTDFESUVWWTFMWW9J?= =?utf-8?B?ZFBRekNoL0hIenllRkt5bk9FaW9KYWJrak4yVTZPSm9jUGFpVFNqanM1MG1L?= =?utf-8?B?NU1GREdsR1R4SzdnL21ZZythV0VrWHBaemg2eTQ2L1VCV1FLSG9kem1XV1g1?= =?utf-8?B?Tk9wWEp6Rk5OVUt0SDBNM3p5ZEdPKy91dkhjcnpJRXZnQktkQ0xFZ0VnMjI3?= =?utf-8?B?TVJMa1ZsekxIVW5MaUpzY3dHcERrVStBR0hsQ3UwQnhudkg5dGJNQWMxa29q?= =?utf-8?B?V29DRW1nN2R6cXg3QkxhU0owNjBiRnovQWhNZGZFNWhJcDdtZU9mVFFLZyt5?= =?utf-8?B?OS9kenBSYzgxRnpuWDRiS1I1NFBSWDEzVjN3T05xbVducVpqdmZVeVNoNENO?= =?utf-8?B?WTZWUkFPdTR2NE44U3BJWE12a3JJak1BKzc2NFJRYlU2RG9sdGZGUGNqVDdV?= =?utf-8?B?RzVaUHdEd3dybk9VMlliV3RzR0EwZGpoM3laelZhNXIwSlZPWk5NTmFPd0Rw?= =?utf-8?B?UzFwNytTTFJyUWp6K1FjNG9WdDlwM0U0cTNJTzZ3dnhtVCtWSXlPQ1FVSmFO?= =?utf-8?B?WjVoTmJ5NVlOMTNRbUZWenduVFEvRzlXMmZ0SjJOOVd0N1dCa2VjTGx0Z1dj?= =?utf-8?B?RmVQS3hrdVRwemdPRUZIa3dnSDl5bXlqNnFUMFJ6RFVydWxINWE4WkJyc2ZJ?= =?utf-8?B?OHUxcXZoQ0FCemFXcldvWlJIdFNpNDVpTE45a3hIM2tnQjBRYWJnQzVLUi8w?= =?utf-8?B?VGcxUmlzOHBaOHZZaThYQWh2NEY1aHA3ak5hRXo5bEwrSW1zaG9hRnBwRzlt?= =?utf-8?B?dG9GWFBtNHJwbWxmeTJTM3Brd0gyNU1UZVVNa0pTbU5hMFZQN0RJNVVLeGV5?= =?utf-8?B?cTFRL3JPcW5jamtGbGJXcHhrZGVuNW9MRXkwMjUzVm5XblhjSnlDeFNCcDB1?= =?utf-8?B?L3IzdEVqL0U2R3FkWE1ZcG42NWxZMytjK0E5QlNCOUV1by9ralB4MFVjOGRT?= =?utf-8?B?WlhpY3QrV0wzZHlRVWt0OW56QmtMOXlJWTFKV08wMWs0d0xMck1FWmtORTFC?= =?utf-8?B?bmVOUTRtdDJBVWFKQXJ6MzVGWHlVZkd1ejNnSE1rSnVlNTJsOG9QL3pRODg2?= =?utf-8?B?Z1Npa0NnZ3JMcVEyYVhFYXVaYWZwcDBna0hKcW9OR0hYbjd0aGhkSWVTdHBV?= =?utf-8?B?Yys0ZHd0cW5ELzlpd0ZMNllDMEw2elcvS0sxaVdWM3FFYXBsZU55QUJwcG1Y?= =?utf-8?Q?jHhcbfS0n9v1fotlun8GZ8sYlaBKPBDZJeGYzfS?= X-MS-Exchange-CrossTenant-Network-Message-Id: ef6662d8-054e-4dd2-6651-08d963d89b5f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2021 12:47:02.1567 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xt9/bT6ZxyImAkjTou9GG6NLoeuUObC2tQs5i1mExOkPftlLu46MTItNUniu4Feu4ZXVuNU3bkQnNUVNasWivw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5047 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to reset Rx next consumer index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/10/2021 7:07 AM, Somnath Kotur wrote: > In bnxt_init_one_rx_ring(), reset this variable internal to the driver > ring to 0, so that there is no mismatch with actual value in HW on > traffic resumption. > Hi Somnath, What is the impact of the patch, what are you fixing? If the 'rx_next_cons' (next consumer index) is not matching with HW value, what happens, does the Rx fails completely and unrecoverable? Or does miss one or more packet? And when/how this happens, since driver is not new I assume this doesn't happen in first ring init. Does this happen after uninit and init again? Providing this information helps clarifying scope of the fix. Can you please send a new version with updated commit log? Thanks, ferruh > Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion") > Cc: stable@dpdk.org > > Signed-off-by: Somnath Kotur > Reviewed-by: Kalesh AP > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_rxr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index aea71703d1..73fbdd17d1 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -1379,6 +1379,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) > } > PMD_DRV_LOG(DEBUG, "TPA alloc Done!\n"); > > + /* Explicitly reset this driver internal tracker on a ring init */ > + rxr->rx_next_cons = 0; > + > return 0; > } > >