From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E327457D8; Fri, 16 Aug 2024 13:46:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A2C64025D; Fri, 16 Aug 2024 13:46:23 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 814F5400EF for ; Fri, 16 Aug 2024 13:46:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A6DD2143D; Fri, 16 Aug 2024 04:46:46 -0700 (PDT) Received: from [192.168.50.45] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3E003F73B; Fri, 16 Aug 2024 04:46:19 -0700 (PDT) Message-ID: <64c84d76-f40e-4a1e-aee0-f06d29004d4d@arm.com> Date: Fri, 16 Aug 2024 12:46:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: add L4 port to verbose output To: Stephen Hemminger , Alex Chapman Cc: dev@dpdk.org, Aman Singh , Jeremy Spewock , Honnappa Nagarahalli , =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek References: <20240815142051.531978-1-alex.chapman@arm.com> <20240815082209.5c2813bf@hermes.local> Content-Language: en-GB From: Luca Vizzarro In-Reply-To: <20240815082209.5c2813bf@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15/08/2024 16:22, Stephen Hemminger wrote: > The verbose output is already too verbose. > Maybe you would like the simpler format (which does include the port number) > see the network packet dissector patches. Hi Stephen, Thank you for the reply you left to Alex's patch. This is actually quite helpful. I've had a look at your patch series and the hexdump is actually quite great for our purpose at DTS, as it will allow us to detect a preset packet identifier in the payload. Unfortunately, your patch doesn't solve the problem that Alex is having. He's currently writing up a test suite to test the RSS hash keys and the respective queues to which the incoming packets are placed into. To correctly match the packets to the queue and hash key, he needs a way to identify them. We explored some solutions and the L4 port seemed to be the most problem-free with the least effort. Using the payload is probably best and you've already posted the required changes too. The only problem is that your hexdump output does not print the required RSS values. Would you be be keen to add these to your patch? Otherwise, do you have any ideas and/or solutions to tackle this specific problem? Thank you, Luca Vizzarro