From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62BEEA0471 for ; Thu, 15 Aug 2019 11:14:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33D631BDAC; Thu, 15 Aug 2019 11:14:56 +0200 (CEST) Received: from mr85p00im-zteg06023901.me.com (mr85p00im-zteg06023901.me.com [17.58.23.192]) by dpdk.org (Postfix) with ESMTP id 03AC51BC25 for ; Thu, 15 Aug 2019 11:14:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1565860493; bh=htotBinx/pU5IJ4OAn+VmnG0963C4jNnHAK8lU1bEzM=; h=To:From:Subject:Date:Message-id:Content-Type; b=XTBMNQlstN/9tAbOaoLXNeGFyP0eLiYItpRJLrcB8w5DDz8UawgnAGW4ycStk8evl T/5r8nbMdQIhDa36RRKC2k+G/HOKP2J6w3WLyBVSz3kkHPLqr5++lC9IPwMvKvPONL U7GzzXXH2Jzi5GtQlYt4YY6pc+OvuUPE7KuSWq8rMFZwkubNxnC+qCmyDs/EhngAom 4P8veaWcOAhdb3l0JXkfITYlQUDlub/7NKeBt1gMDWcWC7imHyS/bTj28mk3l2tt2M dtijk4dHgtcaV/N5TEkZKoXTKNWeNcl1rakTjrjjAiCCMHsVBo207R6yIN3hLNReGd khLCYXxPi8qjw== Received: from localhost (pv33p03im-webms003.me.com [17.142.224.114]) by mr85p00im-zteg06023901.me.com (Postfix) with ESMTP id EE09B961115; Thu, 15 Aug 2019 09:14:52 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, =?utf-8?B?IkNIRU5DSE9ORzEgW+mZiOWGsl0i?= , =?utf-8?B?IllFWElBT0ZFTkcxIFvlj7blsI/ls7BdIg==?= From: He Peng Date: Thu, 15 Aug 2019 09:14:52 GMT X-Mailer: iCloud MailClient1914Project39 MailServer1913B46.10000-1913B-0-be2a8866e288 Message-id: <64da2070-08b6-4e8c-9873-246f98d79ed3@me.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-15_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=893 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1908150098 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] =?utf-8?b?wqAgKnJ0ZV92aG9zdF9yeF9xdWV1ZV9jb3VudCogc2hv?= =?utf-8?q?uld__be_protected_by_vq-=3Eaccess=5Flock?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,=0A=0A=0AWould you please provide=C2=A0 a list of impacted APIs, thus w= e can=C2=A0check if our code has further issues. b.t.w, we are now using d= pdk 18.11.=0A=0A=0AThanks.=0A=0A2019=E5=B9=B48=E6=9C=8814=E6=97=A5 =E4=B8=8B= =E5=8D=8811:09=EF=BC=8CTiwei Bie =E5=86=99=E9=81=93=EF= =BC=9A=0A=0A=0AOn Wed, Aug 14, 2019 at 03:31:09AM +0000, He Peng wrote:=0A= =0AHi=EF=BC=8C=0A=0A=0AWe found that *rte_vhost_rx_queue_count* is not pro= tected by vq->access_lock,=0Aand=C2=A0the access to vq->avail->idx is not = thread-safe, since at the same time, the vq->avail=C2=A0=C2=A0might be=C2=A0= =0A=0A=0Aset by *vring_invalidate* when some vhost-user messages arrived, = such as VRING_SET_ADDRESS,=0AVRING_SET_MEM_TABLE, etc.=0A=0AYou are right.= And other similar APIs also need to be protected.=0AThanks for reporting = this!=0A=0AThanks,=0ATiwei=0A=0A=0A=0A=0A=0A=0A=0AThanks.=C2=A0=0A=0A=0A=0A= =0A=0A=0A=0A