From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BF0FA0032; Fri, 1 Oct 2021 18:48:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1747A41155; Fri, 1 Oct 2021 18:48:02 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A3C144114F for ; Fri, 1 Oct 2021 18:47:59 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10124"; a="248056584" X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="248056584" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 09:47:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="708743906" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 01 Oct 2021 09:47:57 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 1 Oct 2021 09:47:57 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 1 Oct 2021 09:47:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 1 Oct 2021 09:47:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 1 Oct 2021 09:47:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jQo25JN67+ArUNzHtiQPagBUmXbHrjqBZmjbubHNzqsNovURxK6JhC0prhBPO/f4OHP/3Qf9i98JWGm/1N9km/Pn8kRlWxafgGqUnNAOGbO0FQ8UOBhJ0mjdfs4ctvFFIOtby10Qm3uNkpejAp57j1d4dwvy2nRtnfavtUnMhM8W074p4H63F5tthqlgWgTWp1WvaHB79hen1K2v80dd3VcKVDccNwOhgMRLeaTQhuHoQaV4DSPPyst8JgfSrRd+6DCXCrANEluMycocBaVXn5vSA2jBwi0drrKnS2B4BPd5Nfo3WWCBJqIUAkeNi6LK2Ufi1spG/ukrPgbQvHxOWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRdOC3ox56MCwxGWwNZ7N+Iilttstuds1FBVXjSll5g=; b=oe12qLyT7ECBGb7P9V6eOYfee+TzpxdZs6W2YT8RZk0zJom46xNVPgsYwFhfh1CtdH3Mu7+QBVE/7WVR7HiomnbVvgvX0kKG7f/h2gPbUXjgZdEEZSmo81EeyVMXQWOmOZ44jz6trlEXgweSFimRuayuUaYrWs7cnp5V2Dx9zXgPfnGty6FYGFagu0D3ZDy3373FcRV2/dKBn+5MMLOhG8LIfucHAw31RyJEiIo5g1xUMdiHDWKAzqNPBF1o0z1MYd6UZSWes46X+M8TCdqZ7+Sb9En17YwsqXVsRdjSqINLqugfNj2MklsES0EneEgrORxTBrNSnMYHSXWS23V5iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FRdOC3ox56MCwxGWwNZ7N+Iilttstuds1FBVXjSll5g=; b=M/4MSf2JboKGKxwfvKgdg1ii36Ong7ZeO7FrMqoilWoGTlxludrC1XSbaKJKlXhcoy3IoTe+iOCDQ/uVcrdcVH6wD/Cqin2YXkf6kFWHrIhGZ/dnb4LPiYA9C0IvMEwLDyx6AV3ZQ11vfBJgKulMnPsEhFvVWx0oVyFo1zA+dHc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4821.namprd11.prod.outlook.com (2603:10b6:510:34::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct 2021 16:47:11 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.019; Fri, 1 Oct 2021 16:47:11 +0000 To: Konstantin Ananyev , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20210922140953.19388-1-konstantin.ananyev@intel.com> <20211001140255.5726-1-konstantin.ananyev@intel.com> <20211001140255.5726-5-konstantin.ananyev@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <64dd331c-8f35-38fe-998e-bac70ccc9d85@intel.com> Date: Fri, 1 Oct 2021 17:46:58 +0100 In-Reply-To: <20211001140255.5726-5-konstantin.ananyev@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR08CA0007.eurprd08.prod.outlook.com (2603:10a6:8::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR08CA0007.eurprd08.prod.outlook.com (2603:10a6:8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Fri, 1 Oct 2021 16:47:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de60cf6e-1772-45bf-4f7e-08d984fb1cfd X-MS-TrafficTypeDiagnostic: PH0PR11MB4821: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NgY+yCR1ET48kNWtKgM9UsNgpirEHBEfs5qB0eVXUTP0bZq4ZCmyRs6FD2pJHsSuzhGFyiFJ91ecuLTQpTJGUbRY48gP9FMnzJkg3IIZ9+TeUqEdDx6LWnMZDKYxplbD42x9Rs35hhxTDdtUOnBH9onkqdlVFdFRz+3VFN32NDXQxpuflMZVySeY2UZaA2M7dSpnabMu2wYJ9AVMV0X75G09LjcpnDxoBkjYYO5PI8mdX3K6cAXGJYvgIOQ2kuOabbZgV1N4bA8aHH6HRrMnFDzjMO0vGQe1HV4R4QFhftrGo1B95Z3zKiEBChwmRBUPw3I3M5VQfcTAqGd1wplUxaOb7MBqsm/Ytmm2ylL1QRcmvSomMi1EU9zHVPqbOsx7Q4CP2IAprsTolJxoQzp0aYmJ95dOqzeoe1hUWNA69WHp0cH0A7NcteKd4ReVoj8aMZ+SWN15hDofKxC9veMh3PQguXnOIuC6IrhzFMKRQepR3ds+kVs7J9UTgCO6voM8xiPcu1BFuKX6Cy9O9Eto+3HCWbadWw6o61aodwrJvZtetq4sTP3QI1ceEZG1WKDtF13ayjvnAH2Uf93mufheSybMX6G+bzB1QsezMRjbioTsF6wyGAc31i1jmgc1R8zGQx8B9hpgFE3HoIlWeCgzujNluVuT3fw8NQhP6GvLAtR9aCdsyhfXjjtJEySBlsk8HZUwcRphyFNxrdFvc1sIog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31686004)(316002)(6666004)(31696002)(86362001)(83380400001)(508600001)(107886003)(36756003)(66556008)(66476007)(186003)(44832011)(6486002)(8676002)(2906002)(66946007)(16576012)(26005)(38100700002)(8936002)(7406005)(7416002)(5660300002)(956004)(4326008)(2616005)(53546011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGh0RGd0WDZwNzhIb0hENTVEMVphcjI5Qlg4L043ZmF0RGl1ak1GZ1ZqNkpi?= =?utf-8?B?b1lxTXMvSGNZaHBVUHh1UHp1d3hxbU1BSEJxS1UzZFZaSnUzcFBGcm13OVk1?= =?utf-8?B?bFVIajB6WXJOM0t3RldnV2dyOTdMRkV3TW11STYwODBNOHpWeUQ2OHc2S09h?= =?utf-8?B?T1N5M2pYeE81VXRpQjBFeVRXNEpLbTJ4SFhLbG1ITnNWUkpWT0docWF0bzkv?= =?utf-8?B?ZTVKcnU3SksrNUcvQit4OTBUQ0NJZDVWN09tQ0pTc0F5TGE4eG1XL0NRTmhT?= =?utf-8?B?UklsNVMvSzlMWjlmNXdwbHNaajBXdmIvbWJMOWR4dGg5cTdKaEYwMHpUMUtD?= =?utf-8?B?SklMazI5ZEo3NDhReVB6SEZodHlBL3piOUxZZU1CMTJET3hURmJYK2lscmoy?= =?utf-8?B?YVVIRlkyV2IvQmJRQXRSb3ZTbUpUbzlHZGZvYjhrNUJaSC9SRDJ0eXkvcnoy?= =?utf-8?B?VTBsbU5pcGxmQWFZWXYveHdhbjZJRng1NkdLYWoxK3Bxc1pUY2tWWEFLRTRi?= =?utf-8?B?L2dmS09iQmFycHRQMlEyR0xwazdGTzd4NC9mZy9qS3o5a3Y1cERyczVxTXZ4?= =?utf-8?B?V3NGUHlUNFJRM005L0ZrQTVlMkxuRitXQnJvdlp0TFptSHlta2FoMC9uaTRY?= =?utf-8?B?Q3F3ZkFnYnV5YXdRc1dLZVdWSld4RURoTjJSNXc2YTZoN2JobUt0MlY0VzBo?= =?utf-8?B?TGJHNFZHT21KSFlqTVhUN0RJam5lQlgzbkdRSVVRTStxNzJuaUZ4SXZ1NlNr?= =?utf-8?B?SHBsaHp1SXk2bm5aMkYvcDhyRks0ekd3U25UWERaZWROV0dHNndlNXcvUWk0?= =?utf-8?B?Wm0wMm5LbWMyVkYwSHVhYUJTaUNodTMxNU5oQkQvK0l5ZVpqN3lTNWJDNURr?= =?utf-8?B?SGJLWktnS1EyS0hHUWUxMTNKcTNnL0ZQNjZwL3ZlOFI1Kzd6cEhtZzMwTVly?= =?utf-8?B?OUdCZ2pqZXloTm9mUmRHcmh6b1JDaDZXQkllRUIzMmRiNk9hY3MrWnlmeDJB?= =?utf-8?B?VkdhbngxRm9qVmNEZ0ovdDMxS2xtRE1Ic00wTFNhVXVlaEVMTjIyWXRkakVS?= =?utf-8?B?cHFHRGJrWEd1Wk5DQVBFWlFIZDU4WFo4RXZia2VBZit6d0sxNCs3RVMzOUth?= =?utf-8?B?OUZTNTFOODd4UWExWjM2RDN2M0xSVFB0emZrSHZJRDZ6Y0djMUxtbDduVXpK?= =?utf-8?B?QlgxTjJ0VG50MFl2MFpuTi9sTzJWREFSSjkzZys5TmM4QUI4MU5Ia3dGNlpT?= =?utf-8?B?UFIwSTV4b0ZJR1RQbnI2L3lySFFuTGR5WDdhUHR3TUplY3hTejM4dXdJS0hN?= =?utf-8?B?U0J2dW1MLytJSEdlZ3VQS25mS3kwaDc2UW52TTlTaGR2VHZZSHFSM25VVENK?= =?utf-8?B?bFVCM1RoK0dqblZnVkcyTERqbTJPM3plWXlkNTU0cENhNTlTWU5Gb25QN3Iv?= =?utf-8?B?SnBnRFB6eG5LQTFsNDF3LzVETWI2eGk5ejJIdkJxYXp5Y3E3c0d5V3JrZlFP?= =?utf-8?B?SGt1dXpML0RiSHBxQjZ1aU4wRFdVenY3TVBJMittYk01MnlQN2NaQjJDcnRo?= =?utf-8?B?ZEN6dkhaYzlGWTJZODhYT0ZHV2ZjeXZEQ1loVTVTRWZjZ1BDSXRsMWV2Z1Vs?= =?utf-8?B?eHdGSWppTkJzeWRmRmpFV085VlpqZVJ4SWhFSnNseVZITnVpOGZHZ1I0VVFZ?= =?utf-8?B?Y3dQd2g2em05ME5raWkxWmdvTFRBVGVWdDVwakZWQ0s2Y2l3WUtENGJYekFZ?= =?utf-8?Q?XZfWocEJa8w3fhTrW/bjaErE2RcDHgIC9uYiUk/?= X-MS-Exchange-CrossTenant-Network-Message-Id: de60cf6e-1772-45bf-4f7e-08d984fb1cfd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 16:47:11.0245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HpPnF9DFcI6JqwgmYNJkAvqD+JSn78uUK5d7NznczNnGy4u6p5vut3neXZvYIryNmMTKnSuhBlhkgii3aRKWbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4821 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 4/7] ethdev: make burst functions to use new flat array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/2021 3:02 PM, Konstantin Ananyev wrote: > Rework 'fast' burst functions to use rte_eth_fp_ops[]. > While it is an API/ABI breakage, this change is intended to be > transparent for both users (no changes in user app is required) and > PMD developers (no changes in PMD is required). > One extra thing to note - RX/TX callback invocation will cause extra > function call with these changes. That might cause some insignificant > slowdown for code-path where RX/TX callbacks are heavily involved. > > Signed-off-by: Konstantin Ananyev <...> > static inline int > rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id) > { > - struct rte_eth_dev *dev; > + struct rte_eth_fp_ops *p; > + void *qd; > + > + if (port_id >= RTE_MAX_ETHPORTS || > + queue_id >= RTE_MAX_QUEUES_PER_PORT) { > + RTE_ETHDEV_LOG(ERR, > + "Invalid port_id=%u or queue_id=%u\n", > + port_id, queue_id); > + return -EINVAL; > + } Should the checkes wrapped with '#ifdef RTE_ETHDEV_DEBUG_RX' like others? <...> > +++ b/lib/ethdev/version.map > @@ -247,11 +247,16 @@ EXPERIMENTAL { > rte_mtr_meter_policy_delete; > rte_mtr_meter_policy_update; > rte_mtr_meter_policy_validate; > + > + # added in 21.05 s/21.05/21.11/ > + __rte_eth_rx_epilog; > + __rte_eth_tx_prolog; These are directly called by application and must be part of ABI, but marked as 'internal' and has '__rte' prefix to highligh it, this may be confusing. What about making them proper, non-internal, API? > }; > > INTERNAL { > global: > > + rte_eth_fp_ops; This variable is accessed in inline function, so accessed by application, not sure if it suits the 'internal' object definition, internal should be only for objects accessed by other parts of DPDK. I think this can be added to 'DPDK_22'. > rte_eth_dev_allocate; > rte_eth_dev_allocated; > rte_eth_dev_attach_secondary; >