From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88E9441B90; Tue, 31 Jan 2023 17:51:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 608774067B; Tue, 31 Jan 2023 17:51:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DA9B540041 for ; Tue, 31 Jan 2023 17:51:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675183860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kw43Q8/z5EAvxqbmy1XDee9OzReSAqUiThF8fxBmmaU=; b=aslW7aKCn6Bcueq2qK62jAUHke5xjTHrGIdh5DgR9PAR2VE+enDSGgjRHunVFZ9+AlV2jX zDh5xTx84xC5ZrpBg8d98PCcrZuh/DFl7oS/6wbJgxlg4XyZaXa96WDPHjx4Zhx4p2VEbA W7SkHY/qrciY5f3TIaOEi7xJfIcYbWk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-Ph3e0qboM3ukCbqaS198kQ-1; Tue, 31 Jan 2023 11:50:55 -0500 X-MC-Unique: Ph3e0qboM3ukCbqaS198kQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CBC4B18E0A62; Tue, 31 Jan 2023 16:50:54 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6950D492B06; Tue, 31 Jan 2023 16:50:53 +0000 (UTC) Message-ID: <64fb93f8-5783-1132-06b2-d2f778628cbc@redhat.com> Date: Tue, 31 Jan 2023 17:50:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 4/9] vhost: annotate virtqueue access lock To: David Marchand , dev@dpdk.org Cc: stephen@networkplumber.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> <20230119184620.3195267-5-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20230119184620.3195267-5-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/19/23 19:46, David Marchand wrote: > vhost_user_lock/unlock_all_queue_pairs must be waived since clang > annotations can't express taking a runtime number of locks. > > vhost_queue_stats_update() requirement can be expressed with a required > tag. > > Signed-off-by: David Marchand > --- > Changes since RFC v3: > - removed annotations needed for vhost async which went to the next > patch, > > --- > lib/vhost/vhost_user.c | 2 ++ > lib/vhost/virtio_net.c | 4 +--- > 2 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime