From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D1FAA0471 for ; Fri, 16 Aug 2019 09:49:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4389C1BEBF; Fri, 16 Aug 2019 09:49:34 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8C57829D2 for ; Fri, 16 Aug 2019 09:49:32 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8B2F7800059; Fri, 16 Aug 2019 07:49:30 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 16 Aug 2019 08:49:11 +0100 To: , , , Ajit Khaparde , "Somnath Kotur" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Yongseok Koh , "Viacheslav Ovsiienko" , Stephen Hemminger , "K. Y. Srinivasan" , "Haiyang Zhang" , Alejandro Lucero , Nithin Dabilpuram , Kiran Kumar K , "Rasesh Mody" , Shahed Shaikh , Maciej Czekaj , Yong Wang CC: References: <20190816055511.2322-1-pbhagavatula@marvell.com> <20190816055511.2322-5-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: <650397bf-bc61-e55c-591a-6692acdad268@solarflare.com> Date: Fri, 16 Aug 2019 10:49:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190816055511.2322-5-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24850.003 X-TM-AS-Result: No-1.050700-8.000000-10 X-TMASE-MatchedRID: oTBA/+sdKaYeimh1YYHcKKfOxh7hvX71iKQhvNyRXGE7OtcKFS0EBA3/ xpI0E0FOBCrWRYMWYyhXHpcxaFNZCLmvMSppeWbN9m9PbNihg7AL8TGleseLPD9rFtnZWAgfcdQ cKpNhse3Fc/qnt8USGTutnHTM1hTvkJxwyw8wZNNK9CbrGqYI8nkamQDZ6bhfB2QWi8BF5SiArq oIZrVn16J0bVJPx7JYSnDYgIDVxzQqHnF/HDVToR2Og9Ri4HLAE7s3ncD36/2bKItl61J/yZkw8 KdMzN86KrauXd3MZDV+ULruOUpvPlUl+Kx92zQaqmxgiSIc8rVV95uvjrZB4uLMHAAoAqWfprK0 81rcmb0NLJrxC0AcEaA0ers+/lDPLa8ay5hZg/Y4tB9IMwhMcQbEQIfFpkwHBtlgFh29qnpKzBw u5JpklloKRXQm7FH3 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--1.050700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24850.003 X-MDID: 1565941771-60mb5FlSUmod Subject: Re: [dpdk-dev] [PATCH 4/7] net: update Rx RSS hash offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Prefix "net: " is typically used for lib/librte_net. It should be "drivers/net: " here. On 8/16/19 8:55 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all supported NICs. "all supported NICs" sounds wrong here.  I'd say "all PMDs which support RSS hash delivery" or something like this. > Signed-off-by: Pavan Nikhilesh > --- [snip] > diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c > index e6809bb64..695580b22 100644 > --- a/drivers/net/sfc/sfc_rx.c > +++ b/drivers/net/sfc/sfc_rx.c > @@ -618,7 +618,8 @@ struct sfc_dp_rx sfc_efx_rx = { > }, > .features = SFC_DP_RX_FEAT_INTR, > .dev_offload_capa = DEV_RX_OFFLOAD_CHECKSUM, > - .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER, > + .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER | > + DEV_RX_OFFLOAD_RSS_HASH, > .qsize_up_rings = sfc_efx_rx_qsize_up_rings, > .qcreate = sfc_efx_rx_qcreate, > .qdestroy = sfc_efx_rx_qdestroy, > Similar changes are required in sfc_ef10_essb_rx (drivers/net/sfc/sfc_ef10_essb_rx.c) and sfc_ef10_rx (drivers/net/sfc/sfc_ef10_rx.c).