From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 79FCF968
 for <dev@dpdk.org>; Mon, 18 Jun 2018 10:30:05 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 288E321DC3;
 Mon, 18 Jun 2018 04:30:05 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Mon, 18 Jun 2018 04:30:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=poOJzonz12ASVpBshdPZ8U5eCJ
 mKF/DRRJthcP2DaCs=; b=GM8HOZv9vVuvw7xO2+pphSxoljVoBXWrkEk0/xMaXK
 C0AgSBC0UXL9Orf/jzksTZJusKn0puRdLzcdqsoTMfLdQOVZ6pbuj2yfNrGSrpks
 COLf5f/WlUIIlkYAQPiKI0/EbluD61gzVdYrpd/cF3No7m2Uds2ykGFjAzR2l9n/
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=poOJzo
 nz12ASVpBshdPZ8U5eCJmKF/DRRJthcP2DaCs=; b=iRY9bNWA4qx12kO+w5vkLG
 Nvdcbgt85YzYi5LkE/0p23vVWtw7X4V/VdTXiFsbXfFa9zsYmAQXVqPkWGmcP+bR
 6vMH6kKa4QgF7v3ck0vmkSZ7RPRr/EpeojQoT1OX5BK4koRWs/p/4rkTJGQwzV2p
 odC09EK5CIuif0ZZCVc9tv5DY/FZ3d9KSX0UyN5AQD3b6iIUmuEZw1k/MTciHeKH
 mF4PGaPiyJ4jbiPn0ttMRCbmiVvKRqliYINELWLSdP6GMwMqarX9iFlcq/AdAIGn
 au2aPFhkckjbqXXCh9Tc4/25PSOhxr/1cHU2X2UP74fBWB+LiuA9V4BY41xYxT0Q
 ==
X-ME-Proxy: <xmx:jG0nW-zng3oySvoyWmZK6WaXYQYDxjQfjFHMAXF6C58KxlXAm4xjIw>
 <xmx:jG0nW-jYu0iSuCE5RYKkxZY0dDM5WY3YlW5uQii2kIgXG-hWgHEK2g>
 <xmx:jW0nWwSARsmRaNOctZruTe4Ul2NPrm80B6DhT2J7oLKxBelR56FSQQ>
 <xmx:jW0nW5qKQ6SNstD7oa7Hw69wFCnEmbSu3lEqk7Jdc5D11JqFhftvIA>
 <xmx:jW0nW1NxCF1LvRv0Wgki5CPmmdj7Bp8yZ1032dOsB4Oj6OVGkXgArQ>
 <xmx:jW0nWyCUXI6sXzGkRKnoQlnsN-X75bnkMfw3-u0qY_bnAreYxV2YqA>
X-ME-Sender: <xms:jG0nW24NHZqg2N7M2DNNAc-uRTdBxaWe7rYP3G2-YGTrt_FLMQfXkg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 157301032F;
 Mon, 18 Jun 2018 04:30:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: =?utf-8?B?TWljaGHFgg==?= Krawczyk <mk@semihalf.com>
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 "Matushevsky, Alexander" <matua@amazon.com>, ferruh.yigit@intel.com
Date: Mon, 18 Jun 2018 10:30:00 +0200
Message-ID: <6508461.cpII4DF8a3@xps>
In-Reply-To: <CAJMMOfOuB83Gq-LG_NgZZcDtnoefc2EwzrvCWuffggbSaW=Liw@mail.gmail.com>
References: <20180607094322.14312-1-mk@semihalf.com> <3540745.n2F2IE3GfD@xps>
 <CAJMMOfOuB83Gq-LG_NgZZcDtnoefc2EwzrvCWuffggbSaW=Liw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency
	for linking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2018 08:30:06 -0000

18/06/2018 08:04, Micha=C5=82 Krawczyk:
> 2018-06-18 0:37 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> > 07/06/2018 11:43, Michal Krawczyk:
> >> ENA PMD is required to use librte_timer. The appropriate depndency must
> >> be added ifin case the DPDK will be built as shared library.
> >>
> >> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> >> ---
> >>  drivers/net/ena/Makefile | 1 +
> >>  mk/rte.app.mk            | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> >> index 43339f3b9..ff9ce315b 100644
> >> --- a/drivers/net/ena/Makefile
> >> +++ b/drivers/net/ena/Makefile
> >> @@ -58,5 +58,6 @@ CFLAGS +=3D $(INCLUDES)
> >>  LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> >>  LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs
> >>  LDLIBS +=3D -lrte_bus_pci
> >> +LDLIBS +=3D -lrte_timer
> >>
> >>  include $(RTE_SDK)/mk/rte.lib.mk
> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> >> index 1e32c83e7..c70bc254e 100644
> >> --- a/mk/rte.app.mk
> >> +++ b/mk/rte.app.mk
> >> @@ -60,6 +60,7 @@ endif
> >>
> >>  _LDLIBS-y +=3D --whole-archive
> >>
> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          +=3D -lrte_timer
> >
> > Why is it added in rte.app.mk? It is already there, few lines below.
>=20
> I think that's because it wasn't present on the version I was
> preparing the patch (18.02) and I didn't notice that it was added
> meantime when I was rebasing this patch.
>=20
> This patch is already merged to dpdk-next-net. Should I add a patch
> that is reverting this change there?

I can remove it when pulling next-net today.