From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "gakhil@marvell.com" <gakhil@marvell.com>,
"abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>
Subject: bug in cryptodev enqueue/dequeue callbacks?
Date: Thu, 14 Nov 2024 14:41:05 +0000 [thread overview]
Message-ID: <6519b5dbf7fd416aa4803263f2ef7f65@huawei.com> (raw)
Hi everyone,
Looking at implementation of cryptodev callbacks
(it uses DPDK RCU), it seems like there is a bug here:
at init time we don't call rte_rcu_qsbr_thread_register().
As I understand without it rte_rcu_qsbr_check() wouldn't
work properly for that thread.
Probably need to add:
static int
cryptodev_cb_init(struct rte_cryptodev *dev)
{
....
if (rte_rcu_qsbr_init(qsbr, max_threads)) {...}
+ rte_rcu_qsbr_thread_register(qsbr, 0);
Unless I am missing something obvious here?
Konstantin
reply other threads:[~2024-11-14 14:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6519b5dbf7fd416aa4803263f2ef7f65@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=honnappa.nagarahalli@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).