From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 97B9A45D05;
	Thu, 14 Nov 2024 15:41:09 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8685B4026C;
	Thu, 14 Nov 2024 15:41:09 +0100 (CET)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com
 [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id C2B8C4025D
 for <dev@dpdk.org>; Thu, 14 Nov 2024 15:41:07 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.18.186.231])
 by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Xq2nD4zMCz6K69V;
 Thu, 14 Nov 2024 22:37:52 +0800 (CST)
Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71])
 by mail.maildlp.com (Postfix) with ESMTPS id 87351140CB1;
 Thu, 14 Nov 2024 22:41:05 +0800 (CST)
Received: from frapeml500007.china.huawei.com (7.182.85.172) by
 frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Thu, 14 Nov 2024 15:41:05 +0100
Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by
 frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039;
 Thu, 14 Nov 2024 15:41:05 +0100
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: "dev@dpdk.org" <dev@dpdk.org>
CC: "gakhil@marvell.com" <gakhil@marvell.com>, "abhinandan.gujjar@intel.com"
 <abhinandan.gujjar@intel.com>, "honnappa.nagarahalli@arm.com"
 <honnappa.nagarahalli@arm.com>
Subject: bug in cryptodev enqueue/dequeue callbacks?
Thread-Topic: bug in cryptodev enqueue/dequeue callbacks?
Thread-Index: Ads2oYpKGDdDjmiTQLOpBJddlcQhaw==
Date: Thu, 14 Nov 2024 14:41:05 +0000
Message-ID: <6519b5dbf7fd416aa4803263f2ef7f65@huawei.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.206.138.73]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi everyone,

Looking at implementation of cryptodev callbacks
(it uses DPDK RCU), it seems like there is a bug here:

at init time we don't call rte_rcu_qsbr_thread_register().
As I understand without it rte_rcu_qsbr_check() wouldn't
work properly for that thread.

Probably need to add:
static int
cryptodev_cb_init(struct rte_cryptodev *dev)
{
 	....
	if (rte_rcu_qsbr_init(qsbr, max_threads)) {...}
+	rte_rcu_qsbr_thread_register(qsbr, 0);	=09

Unless I am missing something obvious here?
Konstantin