From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E702C41C43; Wed, 8 Feb 2023 21:28:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F31F4014F; Wed, 8 Feb 2023 21:28:27 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2055.outbound.protection.outlook.com [40.107.237.55]) by mails.dpdk.org (Postfix) with ESMTP id BD9FE40141 for ; Wed, 8 Feb 2023 21:28:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IpNoFiWkAJ46mDJtomxqsh7EjZOyun6gLwiEwbw0ekyLdRqtPhjzfmsAfYaABLRSd3oYdkcKNFUKI9yuslQAWNhsKDrcxo7Cvz7VnOcj5dQG5Cz0l0oOmy6LlUXcEB1CB5+8+tLmu8iC/dsGsC/7q9Jy1+cCSFIiTxqsaqkooj7zqUTjNO7yXpJSz6cWd698Pps92N9p3nbRJDUEI3fpYwg/PvonPqnoAGksEXknxjyOi8++T6Hw03t7mumK59z++MtyYKtAO4Yrr0kMj8DUduqZUKGaO+DgS9GfCz6eIgBOrOCm+Q5d2//j5xpCx9PHc+ny+PXd6JPoRLulq1Sp0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nLHryqTgjtuQ6WiYNRbVGfwGYfMBnM9GDC5XYtGBbbM=; b=DeK/Ubphmj3cD4W+qEkWv4bT89lWxwJ3A3dN83w9tdIOa7ohmMr2Mm8M7D5UE6z7/phS9QSJFndaSD5BAd/ly0+bZO4lNG0SzNkllPP5soXj90lQ0aUmIynT1wMimOmvhRrd90j1nzeERkV6RBbnJJpm7XYZUn4iuhsRh/TCFC087+6XdbZ+HSvHX+PD6EPz5LQuqTDCy0qwuKpNQHrv2XVv83iEbtNug2AWxbk4zuZMMCw6vN/lr/ciqCI7+VbJYmHPI87L0h3noo7Ig7lwgZ3gCNMUyHfdZgO7+hiKMPNRVVWeUfdOTyQ7j5LyIek6Wb5G3hoOJmilfEjYIA7heQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nLHryqTgjtuQ6WiYNRbVGfwGYfMBnM9GDC5XYtGBbbM=; b=w3S5UpZxzDO4nxhy7j3AqaV+2BqCICl/T9J5o3JxBYyAqFUBsEk34VbnMtv2Fk517oqpJyfTGqUDRW+LCu5MAUY6jwAVWQEcyyEIqzjFc3SD7or4BocSxW+QdK7L8h8Tp8NWfiJv8JJ9hBIYsOE02lf6sDllZO9txwH4WVvP07s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB5404.namprd12.prod.outlook.com (2603:10b6:510:d7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 20:28:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%6]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 20:28:23 +0000 Message-ID: <6522842a-eed6-33f5-dcaf-503925b3e1a9@amd.com> Date: Wed, 8 Feb 2023 20:28:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5] ethdev: add flow rule group description Content-Language: en-US To: Rongwei Liu , dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net Cc: rasland@nvidia.com, Andrew Rybchenko References: <20230118154447.595231-2-rongweil@nvidia.com> <20230207025732.2890157-1-rongweil@nvidia.com> From: Ferruh Yigit In-Reply-To: <20230207025732.2890157-1-rongweil@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0345.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB5404:EE_ X-MS-Office365-Filtering-Correlation-Id: b977ae5e-add3-43b9-821a-08db0a130666 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8wr+4G3Hz1HL7l9xmyPDMN9nb2KWQV66WbuCKwhs26t3Ltgab2rV55OJ+18OZlWA0AYzCUYZZQeA00ulcE0AowAB9YiDBBFf9BIH9C0Dkhhton8x8j8OZvEVj1A/lLySRDymPA0pwFza3IzUfzZNZMOmUXCtkqJ17oFaxJj/DN6QuTQ9ZKoXNUgbBICVdnrdyI5C6HRjzRW9KHgxu/kJxwXJPzLrDsGld8FHRMyBBCg+7/z4wKbIoPUF2fE9w9c9krz77eNbeo1RAzUCSPxzPP3aSiJJI9QoILqnX3tRQTuTgm3wYgf1MhZU+0M9ZouYZ4fafGcUG+59RQY/h9gjqOvjg3xzMIyiKcGlo4QoINJZ+KrvhAvHVb0sf/Dt8l7O+9Ml6hk1rKG9eCyM9Jx5k7NqtLvWX8MRbJOFWDv14xCXR1poC3sNG4DSfBKV2bDqQdVWWRBgLKAg5gVUFdbbcv0A8LvQVy3WBTRQMH6xceMs1fZyiHN7OLLNwpgktqPcM74/ZTJbA3XHoGxbyjUPznKuYB1mppNufrbkImRfk4b7Qp7YmA3MOZijTSFymELnhf4brF3rqK46XxiKlldlFdrFWazwh5Wo09wpAyQy0zmWob2hUt5q0D4Ar6N5jCfdCda/Zif462jdjhuNz7WC9krrJe3rhdaduQObkz4w+RFTPdOLpoZiQfgmREfzAwOMYdqi8PPd6Ixv+Mso+j5yyVxypD4CgAoMlejT84jcquIdZtlMWBQQu8XDftRBaEWkMV/ose4WK9zGSChCz42I8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(451199018)(31686004)(83380400001)(36756003)(2906002)(86362001)(44832011)(8936002)(5660300002)(66556008)(31696002)(4326008)(66476007)(66946007)(8676002)(41300700001)(316002)(6666004)(38100700002)(966005)(6486002)(2616005)(6506007)(53546011)(478600001)(6512007)(26005)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEM4UkVRU3NaYnhZSkRxSXVISXJnZWxQdUpRcGdpSXNlSnZwTDh1UmZ5TkZF?= =?utf-8?B?dzhkc01Kd2JtczBxVWgrVkRpK1J0alVscmMyTDhpejVOZUNuSWFDY3lnRW1P?= =?utf-8?B?T0tGdzlORnp1eTB0UzZINEFhUmNGRnhQTEpKUlNGTFVwR2tVZEtiVTZLMnhL?= =?utf-8?B?OUhzR0IyU2lkUU9zL3dwaWJXeDA4cnZBd1JSWWhyTmhVRXR3cGttclFYL0NQ?= =?utf-8?B?anlqLzJxQXo4eWZMUkExWFZJUkV4Tk51UFJOYUwyMXhKOWJoWDRsak1MSVh4?= =?utf-8?B?M1dSVzZ1bDQ0bzRnVGRlY0RtdjhtSTBkektWNFBqNUpENVZKdEFrbHlraTlu?= =?utf-8?B?Vm9OdHM1SzZiTjZzOU5BN2t6UWJRV0luc05qZFR0b2dBUnhES0dsOGQ4bzJM?= =?utf-8?B?U0dyTkFWdEZFQWhXODB1cVR3OVRKQVZrSUNKemloWHQ0aUs3TTJVYzlWM2Y4?= =?utf-8?B?VS91c292YitUSmZ4aExiU1Jodi9wcFREQTNkN2c4b28vc241VldhaWJCSHVz?= =?utf-8?B?S3BWTFFmUVF3ZnJpakRBVU9VdkJlNTd1SmFGb09LMitaQ0lsRlA0OVNEck01?= =?utf-8?B?L0gwVk9XYVRXRmVjM25mZDFDNXMydEVhblJmSlY1TDFYL2J1WlNpK1pPb2Fh?= =?utf-8?B?ZmdiZnU0aTFiN0g5aG5XNnQzSm5BbWh0VitDakl4bHMrNGh1ZGFNbkxyc245?= =?utf-8?B?bFlWWm51VEw1OVdqYUF1eG4wVHRQNWpjTmJtN2lDelBCck9qMHM5RVpyci85?= =?utf-8?B?cW01VUdSZHZXYzlSeGE1SFNlRmV3a2ZZb0VkcU5kOGxmZVZUNjhqVFZpSHhw?= =?utf-8?B?T0svR3VzR0dndzBsNjE5U2RZUHFYS3F0VW1DcGx4SmUweTRCbWdZbzRRQmZl?= =?utf-8?B?OE5yb2xKVU5IZ0cvTUQ0SWVZWWQ0cjFOTkNFMDlwVSs5ZkpMcFZOY1pxaEhN?= =?utf-8?B?ZHBrU1NDaExxK1lNelBSd21pMzl0bXV2aWdYR2ZHL1lvemJQYmFzcXJjUG9w?= =?utf-8?B?WHl5ZXBMM2laTC9MS0V5NVdJa3BESUtQV3dkUXdzdnJpUC9OcFZITExXbmRI?= =?utf-8?B?dFVxbzlwdHFMeXhkRGwrWkRZRVhJZzBRU096bmFLd2V2YlArWTJPaU9JR0Zp?= =?utf-8?B?VnJGTmMrZU9UOFdMRmtkay9KNEVtRWNZaWF0WFQ5akYzeUt4bGx0WG02YmVG?= =?utf-8?B?Wkk1YytZL1Fsc1dTRFpyejdLeE1JQWZGM3JXVE5JRmt1ajlIUkhDMTl5SGlU?= =?utf-8?B?NVFYd2x0SkdTU3J1TmtubllnYjEvZ2IyRUU4MWxBY21JaE1XejZnRmlKNTFJ?= =?utf-8?B?YnFvUmxoY2h3TFVrUCtBTUlkdzNmVHZzcGVaYlZBSm9uYS9ySDVZbXVVdXM4?= =?utf-8?B?Ry84YW9UVXR0YWtMNy90SWpMZGVpSmtrRS92Sk5VSmZoT2ZtU0VGMHpYWjZz?= =?utf-8?B?TFJFR2pGTnBwVHJvaVdHRGc2azZGMnZYVzJtVmw2RjJrRXlaREw4dmxRUW1M?= =?utf-8?B?L1pTZ25DYlhncE1yd1BpSllLclVtOGhPSUo1dng5eis5TDJVMUFOQWdlcVRM?= =?utf-8?B?dnhpbzhBeWFkajJVNk9ObFg5R25rOEtwa1V0QUZ1SGZTSUp4NmxhT2hKaVl2?= =?utf-8?B?VlZXcFdqaFQ2NGVOeTRLUjc4SzVvUytKVUVqek9rQWtmRjNBQnk0TGF4VDda?= =?utf-8?B?bk9hdC9XWnhqakZrR3hpSU1yT3dubjFHdko5d3JmWTloTmZnNk43QWh3MzRK?= =?utf-8?B?c09PV1NyeDE2UlJEd244Uk0zNjAwVXluNjRJZEpPdXJUeUNwR0FRZVhPMStj?= =?utf-8?B?N0RBVzRnTDVCWk9CTUc4cFFYWlQ3WDRIVzM2V1cwaTA4Sjh0QkhPSnhvVjln?= =?utf-8?B?c0Y4STJ6NHpSaGliYnI2elVnWGJZcUx5dkhaalVVNU9wRmROWkQ4WnJXWGxB?= =?utf-8?B?NXhXU1BFODVTSml6bHhqY0Q0OHFBZGkyaUJMNUdYNUhmdkpBTFZLSDRaRFdh?= =?utf-8?B?WHJWdk1WT29nWkRiZHJuRWZFV0tuNG9QTFZTcTNxcnJvclZhaG5KOFViL0hh?= =?utf-8?B?WEcrZjlFdE90RytGSGlBb1VsUFU1MGlIcjlPV3BIVHlyWi9yYXFReEp2dDB2?= =?utf-8?Q?gysz9RwpeRd90MQzxzUokJx02?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b977ae5e-add3-43b9-821a-08db0a130666 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 20:28:23.3594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q6chHQU/uzNcHXETVC2fFSftwe8I1eP7LBaAOdvl2CvB+e2LRy1WowL8SU7B77ev X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5404 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2023 2:57 AM, Rongwei Liu wrote: > Add more sentences to describe the group concepts > and define group 0 as root group for traffic to search a > hit rule. > > Signed-off-by: Rongwei Liu > Acked-by: Ori Kam > --- > lib/ethdev/rte_flow.h | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b60987db4b..e71ac0c199 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -86,7 +86,18 @@ extern "C" { > * but may be valid in a few cases. > */ > struct rte_flow_attr { > - uint32_t group; /**< Priority group. */ > + /** > + * A group is a superset of multiple rules. > + * The default group is 0 and is processed for all packets. > + * The group 0 of bifurcated drivers is shared with the kernel. > + * Rules in other groups are processed only if the group is chained > + * by a jump action from a previously matched rule. > + * It means the group hierarchy is made by the flow rules, > + * and the group 0 is the hierarchy root. > + * Note there is no automatic dead loop protection. > + * @see rte_flow_action_jump > + */ > + uint32_t group; Hi Rongwei, Ori, The elaborated comment looks matching with flow API documentation [1], except there is additional information here about default group being shared with kernel for bifurcated drivers. Should this additional information added to the flow API documentation? [1] https://doc.dpdk.org/guides/prog_guide/rte_flow.html