From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 230CBA0A0C;
	Tue, 23 Mar 2021 17:22:16 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A6824140F70;
	Tue, 23 Mar 2021 17:22:15 +0100 (CET)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0223B4069E
 for <dev@dpdk.org>; Tue, 23 Mar 2021 17:22:13 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id 9B6FE5C00CA;
 Tue, 23 Mar 2021 12:22:11 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 23 Mar 2021 12:22:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 TjWaaYtptquOUOtm5iCGMllHA/ppu26JAFVWpaJY/pw=; b=bjOUQ3fw7cguP5k9
 hIqJdYqeOj1p4DzoisriqlW3b3TcLLaWhXQ2rk2fkGWZAqLuN+v4gq8u6HIuNmYV
 TDNHUb1iCnNNE4G0j7eePiPw44MAn+hErxTw27yuiKxx9nU27bDnuhHUTzShNEYq
 m1w9TTBN8wig3jTLhtdrW654uv/Zaj+JDwnXhAFttwLBAM0nN3DEKsL4Un2a4bNj
 zto0TrRddwd4TLxTV8oWaDdGoXed9nVJPfF59bcWlm475sUfxjqj0dY7u+ALrjs4
 stE9fnqCIxKGeQ4lJxqH5tAig0UpdE9HERXQVV00bwenN7Ddvaa+XjvbDJVopchU
 bHS7uw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=TjWaaYtptquOUOtm5iCGMllHA/ppu26JAFVWpaJY/
 pw=; b=LnnJsFFqquNF4bB5asW/IjCxdqqX/Pg4jEiuK1iWX3SGcRx42VTvPnDKU
 0uiF65bbaya81QE1SXVlYj7AswnyhEY8d+Duv6TI+cOj2wFAgSRG14rC/OYQcqyi
 ad/mRpt6cuoMdZwOIvBVrGVZZUlX4LncRUc1MxlUcO97V1JxZnNm17MTZVSSzc2c
 egAa588tTyKQjpTwY0bS/i4trCH7X71ar5gzCv2xdIOa95XZj7m4v88Y89SrjUuc
 IEt8rL/GzhkpT8L94j0MOuoT6h2zrJqIAmXBiGSp+O032LbEYQ6QEfFT81NdSqTO
 tg1g59uFLMg1VAl1Vy1SSC6zX/Wcg==
X-ME-Sender: <xms:sxVaYMl9nEU7I7Z0oTeNhoPyITOsXfwpF8HJp6ho1yRRUd0vVo60Yg>
 <xme:sxVaYHtkrchizkmR8sUhbusMC-BtiViP14y5xuGiBWTWot8YagyVJF34khPyaExMO
 TXsS_Xri1B9MNM_gQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegiedgkeekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure
 dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes
 mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge
 elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv
 tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:sxVaYDdbWvedaN-cifD9Qzxux0zFp0Ap_NGicm3TVvLWDYPhFFvN0Q>
 <xmx:sxVaYBaT6BYHdxSjJKSFxTq-eJro4Rz94hl_GyXzrK3TB9zU-RDA0w>
 <xmx:sxVaYD12vWBGLbpbWL24VHIIe4W_ejC_MPtJcscliyTN-Ije5oZDbA>
 <xmx:sxVaYMjitRke9ygKh_jy8gtfZozzlih1jZ103dtA-d_i7OvkMWdOcA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B57FB24033F;
 Tue, 23 Mar 2021 12:22:10 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Venkata Suresh Kumar P <venkata.suresh.kumar.p@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, churchill.khangar@intel.com,
 yogesh.jangra@intel.com
Date: Tue, 23 Mar 2021 17:22:09 +0100
Message-ID: <6532294.cV1ATAUDhe@thomas>
In-Reply-To: <1616155326-2639-1-git-send-email-venkata.suresh.kumar.p@intel.com>
References: <1616155326-2639-1-git-send-email-venkata.suresh.kumar.p@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/03/2021 13:02, Venkata Suresh Kumar P:
> Add the file descriptor input/output port type for the SWX pipeline.

I think it deserves a bit more explanation about what is FD I/O port.

>  /*
> + * tap
> + */
> +#define TAP_DEV                                            "/dev/net/tun"

Spaces are free :)


> +#ifndef TRACE_LEVEL
> +#define TRACE_LEVEL 0
> +#endif
> +
> +#if TRACE_LEVEL
> +#define TRACE(...) printf(__VA_ARGS__)
> +#else
> +#define TRACE(...)
> +#endif

Would you consider rte_trace?


> --- /dev/null
> +++ b/lib/librte_port/rte_swx_port_fd.h
> @@ -0,0 +1,57 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2016 Intel Corporation

I guess you did not create it in 2016.

> + */
> +
> +#ifndef __INCLUDE_RTE_SWX_PORT_FD_H__
> +#define __INCLUDE_RTE_SWX_PORT_FD_H__
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +/**
> + * @file
> + * RTE SWX FD Input and Output Ports
> + *
> + ***/

Useless blank line.

[...]
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif

A comment after such a far #endif is better:
	/* __INCLUDE_RTE_SWX_PORT_FD_H__ */

> --- a/lib/librte_port/version.map
> +++ b/lib/librte_port/version.map
> @@ -48,4 +48,6 @@ EXPERIMENTAL {
>         #added in 21.02

In 21.05

>         rte_swx_port_ring_reader_ops;
>         rte_swx_port_ring_writer_ops;
> +       rte_swx_port_fd_reader_ops;
> +       rte_swx_port_fd_writer_ops;

Please sort in alphabetical order.